Received-SPF: pass (google.com: domain of linux-kernel+bounces-205272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240606141222.11237-1-Harald.Mommer@opensynergy.com>
In-Reply-To: <20240606141222.11237-1-Harald.Mommer@opensynergy.com>
From: Vincent Mailhol <vincent.mailhol@gmail.com>
Date: Fri, 7 Jun 2024 12:43:51 +0900
Message-ID: <CAMZ6RqK+doMKZfsbchHsfo9xYdEoKGyQk035PHbiW0quWFM+sg@mail.gmail.com>
Subject: Re: [PATCH 1/1] virtio-can: Add link to CAN specification from ISO.
To: Harald Mommer <Harald.Mommer@opensynergy.com>
Cc: virtio-dev@lists.linux.dev, linux-can@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Wolfgang Grandegger <wg@grandegger.com>, Marc Kleine-Budde <mkl@pengutronix.de>, 
	"David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, 
	Dariusz Stojaczyk <Dariusz.Stojaczyk@opensynergy.com>
Content-Type: text/plain; charset="UTF-8"

On Thu. 6 Jun. 2024 at 23:26, Harald Mommer
<Harald.Mommer@opensynergy.com> wrote:
> Add link to the CAN specification in the ISO shop.
>
>   ISO 11898-1:2015
>   Road vehicles
>   Controller area network (CAN)
>   Part 1: Data link layer and physical signalling
>
> The specification is not freely obtainable there.
> ---
>  introduction.tex | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/introduction.tex b/introduction.tex
> index 8bcef03..72573d6 100644
> --- a/introduction.tex
> +++ b/introduction.tex

Excuse my ignorance, this is not a patch toward the Linux tree, right?
Could you let me know which git tree this patch is targetting?

> @@ -142,7 +142,8 @@ \section{Normative References}\label{sec:Normative References}
>      TRANSMISSION CONTROL PROTOCOL
>         \newline\url{https://www.rfc-editor.org/rfc/rfc793}\\
>         \phantomsection\label{intro:CAN}\textbf{[CAN]} &
> -    ISO 11898-1:2015 Road vehicles -- Controller area network (CAN) -- Part 1: Data link layer and physical signalling\\
> +    ISO 11898-1:2015 Road vehicles -- Controller area network (CAN) -- Part 1: Data link layer and physical signalling
> +       \newline\url{https://www.iso.org/standard/63648.html}\\
>  \end{longtable}

I just realised that ISO 11898-1:2024 was published last month:
https://www.iso.org/standard/86384.html.

Just for confirmation, are you keeping the reference to ISO
11898-1:2015 until CAN XL support gets added? If yes, OK as-is.

On my side, I now need to read the new ISO 11898-1:2024.

>
>  \section{Non-Normative References}
> --
> 2.34.1
>
>