Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp794217lqt; Thu, 6 Jun 2024 20:48:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVclI0OrOokG6u63nviO9fWS53tpOHAtcdf5PPQT9TjJF8hjtWrcgxEs9PtEygQkywC16B651/E1KITp3avB12VX486fdpdFV8y9AH/0w== X-Google-Smtp-Source: AGHT+IHfwW6675UQXO5W4sQg074ts/nepEH3AdAMYRYAATeB40DaP/K3zLYU3+RnJM+HRVJW9uDD X-Received: by 2002:a05:6a20:7fa6:b0:1af:f50f:cbe5 with SMTP id adf61e73a8af0-1b2c55f8371mr6554912637.8.1717732085673; Thu, 06 Jun 2024 20:48:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717732085; cv=pass; d=google.com; s=arc-20160816; b=t1Cjxg5zVN2eOc8lXynCu5yteZOYQwwyAzP8T1Bd7LeU35U0fiBXOtR1V4dVHOWKxm XP3UjK1sChdWgvXbJca1BmQqhGcorRimneyUI/MnX7oaZhQ3KhsIR3wTn3GJZyYP63ua A/sPGrXkkgr5+9LqewC6XniPdr05fKvcwgsqhb0yr64AQq6dYV6nsW8ZyP5r5oqlOdf2 sz090uvLF5LfElhOk0MY1KPb1aWgu3n0wIY8edKdcrtSpcH68U1f1u4krgOJLSg1zgS4 fjqtwLmLqr8syJxU3liA8wnV21U/cBDD6eZNTS248XaajlLBzotULQOLi5iJ60P1KIKx EkeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=k2zmVJyT6QQfw74c0ZmAvYZBQxk8PeGEZhsNEJ+y4EA=; fh=KzhwI06hRG4EPgEUOnIPbRhD08yUUh33d9oQFfqUdTA=; b=oUGoedLOEoT4BJm3EPSobOWI0PnOog74Pzv5pN6Ekn1GlIYNi6Mio+Jz2/kLWmwy8w +rVSDP3xhoXico+mnz196HwAa/NY+Hmq3QHpiqdyJfMTRs1WmaE4JGMVM1z5oD3qCx7X xTWBApR/Z+IdRbhw53JRHOy/TX8PmlJvNtd3N5t8joBMnRft4xiOsAOToy3Vt/YaTbXc qacOZ8O/dXOgKPaFhDT3pBFOUwWIZ+HsF2ami51Drfz0HCeT+nyL86S5ep2AoqfBqntV LwumMxP3wpBl9FDWGJkWDsrmop2UNakc7HoTW5kmAmSxxYop9Gf0NcHiIC2HRisgp7hB VdXA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Ebrkhen0; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-205273-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205273-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de261c9b23si2197675a12.320.2024.06.06.20.48.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 20:48:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-205273-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Ebrkhen0; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-205273-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205273-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 224C32863F0 for ; Fri, 7 Jun 2024 03:48:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7053417BB7; Fri, 7 Jun 2024 03:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ebrkhen0" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 016F611184; Fri, 7 Jun 2024 03:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717732074; cv=none; b=HN/WKCje4+ydYLqlWWoCqfbvp0ZnvGjtCNndV/9UdvR0kMSLhwFaHM4z8c9PxyV45m26XZcvd1OaD3iCnasFl3msUeG2ig44coUG+LXMM6teQEgG6ORb8CYyt5IZZgeTTXFZTPKQQqEqOtEBjp7q/iwIRR0Heou/QMN1Hn+mk6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717732074; c=relaxed/simple; bh=pPOz7QOlPRfWTnKRgHB440bhcTmrNjJhcuqoVeaZP+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GSXfn2GLKH0Nc+RfYaScuoetnhNEI07r7ziNTsjbCuvK4O4fnndB2v+RlGnlchQ5UCL8q4IIrb0C0QHTrSVkjEGKPXcYo1LvIHZKGzAiHyERsnqd75o0+VNTNll1ge1/6LAHKI8jTOvsyk94ceLWNAmD21NzjSrmUQmMi6KqoPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Ebrkhen0; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k2zmVJyT6QQfw74c0ZmAvYZBQxk8PeGEZhsNEJ+y4EA=; b=Ebrkhen0IK/KZMcd/x837fNBoQ 2ApAdNbH+867Zun3v6YnswS24eGcp3TnfUeEiCIGaoZL9nVuw6+PlmHqKodgTBIJsKvCKR1r6/kB5 kfH8pFQVT47YxQkX/IBIZlyTntzuttmTpmM/PhZPQrYyEOYKqcS8C9wDvS0Al0FwT8OTyWEtR3HjU Y9DWwi7aM9hrGDfgl+de7wm6tl9bdcDYtp65lQvaJQdfO5fVkO4s5g0lRTZFEez9eCh+H5uft+2vf WKPEsXZnXKxyVzXHtoAOfHc9IjOjjN7ZZBmZ19Gji+dqxkCBkDGKGQm6ZQlgxxggb+J4odddWgjp/ vbtrVo5g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sFQZd-00000004SlU-3wWX; Fri, 07 Jun 2024 03:47:29 +0000 Date: Fri, 7 Jun 2024 04:47:29 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, tony.luck@intel.com, bp@alien8.de, nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h Message-ID: References: <20240606063247.712575-1-linmiaohe@huawei.com> <20240606063247.712575-11-linmiaohe@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606063247.712575-11-linmiaohe@huawei.com> On Thu, Jun 06, 2024 at 02:32:44PM +0800, Miaohe Lin wrote: > +++ b/mm/internal.h > @@ -1077,6 +1077,16 @@ extern u64 hwpoison_filter_flags_mask; > extern u64 hwpoison_filter_flags_value; > extern u64 hwpoison_filter_memcg; > extern u32 hwpoison_filter_enable; > +#define MAGIC_HWPOISON 0x48575053U /* HWPS */ > +extern void SetPageHWPoisonTakenOff(struct page *page); > +extern void ClearPageHWPoisonTakenOff(struct page *page); > +extern bool take_page_off_buddy(struct page *page); > +extern bool put_page_back_buddy(struct page *page); s/extern// for function declarations.