Received-SPF: pass (google.com: domain of linux-kernel+bounces-205279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Ng, Boon Khai" <boon.khai.ng@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
	<joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@intel.com>,
	"G Thomas, Rohan" <rohan.g.thomas@intel.com>, "Looi, Hong Aun"
	<hong.aun.looi@intel.com>, Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>, "Tham, Mun Yew" <mun.yew.tham@intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Topic: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Index: AQHasBkLCj07Z540QUGXqLg1tlacPLGrb/8AgAB3OtCAALcdgIACos0AgAA0dwCAB3I7sIABIjSAgAOj/AA=
Date: Fri, 7 Jun 2024 04:09:37 +0000
Message-ID: <DM8PR11MB5751CD3D8EF4DF0B138DEB7FC1FB2@DM8PR11MB5751.namprd11.prod.outlook.com>
References: <20240527093339.30883-1-boon.khai.ng@intel.com>
 <20240527093339.30883-2-boon.khai.ng@intel.com>
 <48176576-e1d2-4c45-967a-91cabb982a21@lunn.ch>
 <DM8PR11MB5751469FAA2B01EB6CEB7B50C1F12@DM8PR11MB5751.namprd11.prod.outlook.com>
 <48673551-cada-4194-865f-bc04c1e19c29@lunn.ch>
 <DM8PR11MB5751194374C75EC5D5889D6AC1F32@DM8PR11MB5751.namprd11.prod.outlook.com>
 <322d8745-7eae-4a68-4606-d9fdb19b4662@linux.intel.com>
 <BL3PR11MB57488DF9B08EACD88D938E2FC1F82@BL3PR11MB5748.namprd11.prod.outlook.com>
 <734c0d46-63f2-457d-85bf-d97159110583@lunn.ch>
In-Reply-To: <734c0d46-63f2-457d-85bf-d97159110583@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?wBV/fKJzUOJlXo6McIC+mz9iRCDdOHYdADrsvP4v8lI/cf0dDA+qaSmStz?=
 =?iso-8859-1?Q?zsGaBLt4FuURSL3hCxMZTZhSekmsWkTowxEMX+Sq6K9zTzX/aD0CFixP3Y?=
 =?iso-8859-1?Q?XvLwm84+NFxhfKLfqdFxVFNyOG+fokncb4uTvafOEq94RWVXhaNw5iVWuA?=
 =?iso-8859-1?Q?gBeNtIj/vWr+/vdQbI49rL7W/L/Og6y7T3zMp6eayu8HbIfOQG57gjUjet?=
 =?iso-8859-1?Q?pe5P6rUx9fddWMRhhJZwGN+NOYntuF76Ufl5t2+r7bIW7ikAGMq83f3LkV?=
 =?iso-8859-1?Q?tazmJyS2CRSo6dBDJKZSYlSDVwqIoGcpie1CR0tQPdiTxivTAZ4NIdXDTy?=
 =?iso-8859-1?Q?sOGdJcqtJO8GKlGy/T9SDCiwpaFXEbrj24iMd2/DEWCdAnbmjQ30/HAq5X?=
 =?iso-8859-1?Q?26Y6WkhReON60cI+ePyBwuwb4TXjQd+DH1/T0DBOoXSlGjUizeRLK3gNHz?=
 =?iso-8859-1?Q?6bDdP7pH3qjeZtBUNb3qKdx0HReasAIM+uwFY1jAGzQqYCK1UflSxRTtXD?=
 =?iso-8859-1?Q?pEP4P9SiJ4fYcCptwBsiUub9UklsQnLywNTJPl6Q/A/L42GWC6wwnq+57U?=
 =?iso-8859-1?Q?x1nQhvLa+huB52cY17MIu9i4a5G6HsPYz+PyBEhamA86tqrMel4VBcZefo?=
 =?iso-8859-1?Q?5a6I1FUsufdIbOWaOyEPsoN0R0Kq3XctaId2Qp0zk3fV82pKBCVaVCj07G?=
 =?iso-8859-1?Q?RhI//on0bbtQJMmm0zNPuVm4iyt1cPy8fbcKMbhXGtO0l9DQC8hB0ObL6U?=
 =?iso-8859-1?Q?jl/05Ik0AcGmzwxBHXSsIBIcCgh4ZIKq1E9QcMiT28pB+kyM+8+LROF7ss?=
 =?iso-8859-1?Q?PCC4nMoZJvRFE5ax4sUzSe/BneE7FcVEjf1mo3SoFTuz5kaTH5FEFc1iN9?=
 =?iso-8859-1?Q?ReGBviMAJ9uB7o85ObO3jfH7KfILA6jxcFbiWazijp3gJ0XOhN89Wd/b+S?=
 =?iso-8859-1?Q?Tjmty0mvohzObtKKR5oFieFT7YTz+GFqhILECZgTzUSG5Fx9hLxLs76WJu?=
 =?iso-8859-1?Q?/F+0ck0TvxjPv7kDTa/KhMNVte1cxyuLsQfeTuQeujlSGvnmQnNc8b/BiO?=
 =?iso-8859-1?Q?4Ze8MVWMObYy0AqAlFNHzf4X2g+siL+gKfMc9Nxnyilo5VCcMs8HzcdVRB?=
 =?iso-8859-1?Q?MA6h7gUKmigO81S5ctnw7aLGwkPoNI96lMloQ94TnVkx6GzyksIAuVAzKy?=
 =?iso-8859-1?Q?+CBh9kgK5jDEg9Ws2hKIyOX4p2Eq0kwe9vy6bnBvuUxG+PoS762h7YCFe5?=
 =?iso-8859-1?Q?b7DvXuGgTUGzt/Rq6Ww2ekjSS5tY0u1ccNCEFr9QvUjJwJ0HS3s54wLQwh?=
 =?iso-8859-1?Q?mSv646T13MTZG+1BplwJZglHZlcqa8AZ65IIVFK5MSSpXu6a2Nj3WQSvSD?=
 =?iso-8859-1?Q?XjxeJecnyaMmbEvnvE9b1/dRJBZ6YoZhI1/W4DlA5459klsQX/MqvFq4om?=
 =?iso-8859-1?Q?Wlm29VEj2Eu+KSDvzkstkQk7cVvm7Qp6/zQy8wAWPbDX0+QgkmYiX6FtJH?=
 =?iso-8859-1?Q?A7yWXYx/IF+QKGj3xKk+liKD949cQWAljjd/kT62CZBdL+KYMr5tKOqgok?=
 =?iso-8859-1?Q?dWUgbFSdLz6oSjpT6JaP7T/y0gB3hKT0atM4//Z12+hD9U7C+d07bkdjeS?=
 =?iso-8859-1?Q?VlGiTyFHyvBltSS43T8x3UBL9M8oTwKgiF?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e48e329b-aef0-41e6-b533-08dc86a7a5ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2024 04:09:37.6867
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M9xWuZ2rtwiwSI/CB/BUX6v/k2zJ6Lu0d23LScJRQrdhj+8AUBXo22bLSg4wO0Lp8QwpAOCyEU3GkuQAnnk8CA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4620
X-OriginatorOrg: intel.com

>=20
> Do you have access to all the reference documentation for the IP driven i=
n
> dwmac4_core.c, dwxgmac2_core.c and stmmac_main.c? Is it just VLAN which
> is the same, and everything else is different? Or are other blocks of the
> hardware also identical and the code should be shared?
> If VLAN is all that is identical, then stammc_vlan.c would make sense.

Hi Andrew, I only have access to the document for=20
dwmac4_core.c and dwxgmac2_core.c, I notice that in the linux mainline
https://github.com/torvalds/linux/tree/master/drivers/net/ethernet/stmicro/
stmmac

it does have stmmac_est.c and stmmac_ptp.c to that support for both
dwmac4 and dwxgmac2, with that I think it is suitable for introducing
another file called stmmac_vlan?

Regards,
Boon Khai