Received-SPF: pass (google.com: domain of linux-kernel+bounces-205414-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Vabhav Sharma <vabhav.sharma@nxp.com>
To: Frank Li <frank.li@nxp.com>
CC: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Franck Lenormand
	<franck.lenormand@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, Shawn Guo
	<shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Peng
 Fan <peng.fan@nxp.com>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, Varun Sethi <V.Sethi@nxp.com>,
	Silvano Di Ninno <silvano.dininno@nxp.com>, Pankaj Gupta
	<pankaj.gupta@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>
Subject: RE: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree
 bindings
Thread-Topic: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree
 bindings
Thread-Index: AQHaoao2jC57TZpcF0ePF6O5Tvr8yrGOOJWAgC2zU5A=
Date: Fri, 7 Jun 2024 05:08:39 +0000
Message-ID:
 <AS1PR04MB9358D3AE83FDB89672AE9158F3FB2@AS1PR04MB9358.eurprd04.prod.outlook.com>
References: <20240509-secvio-v1-0-90fbe2baeda2@nxp.com>
 <20240509-secvio-v1-1-90fbe2baeda2@nxp.com>
 <Zjw9044yBRn9+adW@lizhi-Precision-Tower-5810>
In-Reply-To: <Zjw9044yBRn9+adW@lizhi-Precision-Tower-5810>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?3wfz+vP519aSbcmhjzeTGkafa/6nz3OATGWxFTMxKMON3Ne2eUXwOANfvDPp?=
 =?us-ascii?Q?IQryqNH72oR+IZTliCySorqU1vYaqq1sl+hyg5E8dEBfsrvX8WYlzc1MKqhw?=
 =?us-ascii?Q?FSc4QoIF35CeqpiY69OlOvOZHUahAxfdiwndsuKjQ6S0xYq9fUHmYmXtuEWO?=
 =?us-ascii?Q?ZhxCXARte7p8TXDAx91LsGh1/P4B53h93Iad4kYs9Wh3W4aKP/0eNUQbIFBx?=
 =?us-ascii?Q?RQUxqeL5E4PjXoTBwjvuU8L+DJGJSRNxlFd8I3OQmKHVN1ZLRbtS6Z5/SEB4?=
 =?us-ascii?Q?Ba9XpwpJG6Bi8AQr+nJd5LlTr39Sm9OBx7fIbxBEtg9AyohtYXoXm8AY2ZMF?=
 =?us-ascii?Q?zxryCqvvVvXsnmMLv/GBz/yf86vgef6bvNF2SS7wlz/gy7465iICEsqmJXMj?=
 =?us-ascii?Q?bqP+FMMZ0fQJlbqyLI0bfzOHG/G/pI6Md0hze2t6hpFaHTSnRApYp0hAfa86?=
 =?us-ascii?Q?RzwSa2KLhQXF70Fzfjb8tL/bfCXgBCjuLngR/bIUXZ0T60Oek+yNoA/sAafA?=
 =?us-ascii?Q?MRS08UiQTMSI/D2r39tX0Q1+bd+fpPAe6tEKM+329UVGSoDKRWmWZ1w/6Npr?=
 =?us-ascii?Q?i8xaGVdtGXL/KlJKGjxfg3jNRMmICkU2nuzepGn9G1yGaHiH9BCKzULzkPUk?=
 =?us-ascii?Q?gSukcLrRmX0HLj3nCeT9Zne15V3dfjK/uBkNHR16vE2qu7m4wSA7ErIusWPa?=
 =?us-ascii?Q?u8rDAj8PBQI0HaBc2cD1gwUls/IG6JMl9Q6PGE1ZLryASQhidqw7r2RxL8vs?=
 =?us-ascii?Q?ROXdUssPGrNk9mpZOYntIgp3+iNJFDftl77E8vXzjHxnfxh7YYk643J9Qiw7?=
 =?us-ascii?Q?V9ZRbop3ChQBqnl1ojDCc9QUb0w+LtqLevZUnn/kgnmHHglcN42l97XKD7n6?=
 =?us-ascii?Q?XWibzNy61OQgBpH2YMH4FxaJ71vf/vLS/Ob2E7GE7KiMeQ6sKOPPsmU2iZC7?=
 =?us-ascii?Q?z/pCm0j6CeO6+l95KZ0rqd2jNB6KnhWNrrfWd6wjTOd3YpS6RW03mn109hzT?=
 =?us-ascii?Q?/P0EtB5phF0Z7cW4Nl2Fxi7xCfmKI3fB5iMrIVrn9qLEfafGqvEdwPjcv88j?=
 =?us-ascii?Q?njPFwvIObB/TgPwa8qAIR+Qj8sZHoW9ULl1EiaxD7zWzigsexpva8B6aJjJV?=
 =?us-ascii?Q?jX7xOlb+DfOMapMxJpo/kFk0WsHGZ0EXg1W2vVtrk6tgVhw7PSHJl2MxOyrc?=
 =?us-ascii?Q?951Oy8diut2AVShYAoi2PI/rUWBWaMb4HD7WYa+a5EzvaqirTlAwoqEkH0IN?=
 =?us-ascii?Q?2QLx8k0BIHW7wcV5HYXduYSZjc5R6EZAVe/OWWH68vnDkHwjhdjpI13+f3tN?=
 =?us-ascii?Q?6RQNaFJrSgdKZtvaC0sOaISYGrFG7C4oHJ/EOMdWRKyZQ1Etq+JA1y5wA99j?=
 =?us-ascii?Q?tOEjrxGyA9tVNfZv17rLVDPcWvT7dnjJ51dITIjGPcwA8xiyUm3fYztbpnqd?=
 =?us-ascii?Q?40cKvVKyatjXRuWwpMQWfzDbwIK3+r3AXzPDg/runOvfzWNwcDaAgnkobbPY?=
 =?us-ascii?Q?5YOOqjYGx4CIpQFMWGfwFn4Nb5Zxa3+Cbv84/8XDH+JTN6ZDvmUTlGByMb1y?=
 =?us-ascii?Q?gpzILjXZ6C49JT4VL9AmS1y4hh0eu5ebY3P9V4eY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9358.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a91d583c-a9f0-430c-04be-08dc86afe505
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2024 05:08:39.9375
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mBxvIByGulxG89EHVpW8VbCbPWd2j2i+kzF9tYP0yQ8qgN0C3oPJR7pKp8sl1GHDr/FX0kd0Tr+nhHZbcCJNhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9219


> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: Thursday, May 9, 2024 8:37 AM
> To: Vabhav Sharma <vabhav.sharma@nxp.com>
> Cc: Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Franck
> Lenormand <franck.lenormand@nxp.com>; Aisheng Dong
> <aisheng.dong@nxp.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Peng Fan
> <peng.fan@nxp.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; imx@lists.linux.dev; linux-arm-
> kernel@lists.infradead.org; Varun Sethi <V.Sethi@nxp.com>; Silvano Di Nin=
no
> <silvano.dininno@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Daniel
> Baluta <daniel.baluta@nxp.com>
> Subject: Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree
> bindings
>=20
> On Thu, May 09, 2024 at 02:45:32AM +0200, Vabhav Sharma wrote:
> > Document the secvio device tree bindings.
>=20
> reduntant sentence.
Ok, I am removing in v3.
> >
> > The tampers are security feature available on i.MX products and
> > managed by SNVS block.The tamper goal is to detect the variation
>                         ^^ space here
>=20
> > of hardware or physical parameters, which can indicate an attack.
> >
> > The SNVS, which provides secure non-volatile storage, allows to detect
> > some hardware attacks against the SoC.They are connected
>                                                ^^ space here
> > to the security-violation ports, which send an alert when an
> > out-of-range value is detected.
> >
> > The "imx-secvio-sc" module is designed to report security violations
> > and tamper triggering via SCU firmware to the user.
> >
> > Add the imx-scu secvio sub node and secvio sub node description.
> >
> > Signed-off-by: Franck LENORMAND <franck.lenormand@nxp.com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> > ---
> >  .../bindings/arm/freescale/fsl,scu-secvio.yaml     | 35
> ++++++++++++++++++++++
> >  .../devicetree/bindings/firmware/fsl,scu.yaml      | 10 +++++++
> >  2 files changed, 45 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.yaml
> > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.yaml
> > new file mode 100644
> > index 000000000000..30dc1e21f903
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.y
> > +++ aml
> > @@ -0,0 +1,35 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/freescale/fsl,scu-secvio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NXP i.MX Security Violation driver
>=20
> Violation detect driver
Ok
>=20
> > +
> > +maintainers:
> > +  - Franck LENORMAND <franck.lenormand@nxp.com>
> > +
> > +description: |
>=20
> Needn't "|"
Ok
>=20
> > +  Receive security violation from the SNVS via the SCU firmware.
> > + Allow to  register notifier for additional processing
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx-sc-secvio
> > +
> > +  nvmem:
> > +    maxItems: 1
> > +
>=20
> any interrupt defined? how do you notify such violation event?
Yes, there is security violation interrupt bit in register map of SECVIO HW=
 block with uses RPC call to notify/enable/disable this bit using RPC API e=
xported through SCU firmware
>=20
> > +required:
> > +  - compatible
> > +  - nvmem
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    secvio {
> > +        compatible =3D "fsl,imx-sc-secvio";
> > +        nvmem =3D <&ocotp>;
> > +    };
> > diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > index 557e524786c2..b40e127fdc88 100644
> > --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > @@ -129,6 +129,11 @@ properties:
> >        RTC controller provided by the SCU
> >      $ref: /schemas/rtc/fsl,scu-rtc.yaml
> >
> > +  secvio:
> > +    description:
> > +      Receive security violation from the SNVS via the SCU firmware
> > +    $ref: /schemas/arm/freescale/fsl,scu-secvio.yaml
> > +
> >    thermal-sensor:
> >      description:
> >        Thermal sensor provided by the SCU @@ -197,6 +202,11 @@
> > examples:
> >                  compatible =3D "fsl,imx8qxp-sc-rtc";
> >              };
> >
> > +            secvio {
> > +                compatible =3D "fsl,imx-sc-secvio";
> > +                nvmem =3D <&ocotp>;
> > +            };
> > +
> >              keys {
> >                  compatible =3D "fsl,imx8qxp-sc-key", "fsl,imx-sc-key";
> >                  linux,keycodes =3D <KEY_POWER>;
> >
> > --
> > 2.25.1
> >