Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp832272lqt; Thu, 6 Jun 2024 22:49:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUSce4zJ3JKSNCb7V8we6NX2Nfe9OUW+I2F5KVUa/Z63t2+BN1oU0F1YrFkSOVSjdxbGU+U0fOPBcYpZgzwbtk02088mlf428Bz2CWhLw== X-Google-Smtp-Source: AGHT+IFyt8VJ6qoh7hsr4EhubfA9JVCBQBuWlz81lVNGRdS0eDcXPksbuw6gCF44/2fJfd+6QMVf X-Received: by 2002:a05:6a00:3d49:b0:6f8:d51b:1ccf with SMTP id d2e1a72fcca58-7040c61f7dfmr1499789b3a.6.1717739353686; Thu, 06 Jun 2024 22:49:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717739353; cv=pass; d=google.com; s=arc-20160816; b=Bw2HNSS+6wSX6PoI7ypymcmFQ82/MNXwfzQjjhL9Y3i8UphAxlKj+3F5yyMLbRMkAy CzIsnHHjI6a6eKza5TKKOc3F++vz+09zzgoDsCrXwE6iEvIyeUf6kJX6vyJC4EBpDVAA kv2HRv3l7lmbbLqpbZ2FBmzIbhAmBloSmZcDLyXkyhOIYFhWhBTuv4gEGUoTUg75HGyi PlmJJIW8iXjljgrxGpkd+/33aRuRLQJxuOrSLm/d8hoAqDuO0llYa2jBaW4dbx8toVl/ wAlWFizaR4aevgB31xWaABjw7gf6cf7XXiztRMjiSKbr98TvB0QMhLIoIOopMEURzscb B/xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MPpS30B8oQddbNIA4e5SgwQLluo/cGUrwr2ygS5Damc=; fh=Tm62UYldqwa8MagLFZNL1KWDWo2nSpgT3lnWOxF6OFI=; b=lRncco8DAgTFcNG4bj2FWgIKZOOq+3BpCvQzMosBaUjfTHwzq+K+tQa3C0dn+Bmy5H 7TyXV00duJlxz8haaZmQXfXpTww47CGsoPtpBH+3q42820nLA1bYlR4eHbhn94b3L5pm GEGI9bvvkSjrHMbG3DeGGf9e4AYhQMnYqgbHhuaD1vSx3EtqZwzIaYhQVRnsPYYg8Fl0 hpT9Oqxw+6aNEdXZBvfzKGs8sRq1rUASnnms2o1YOXvcj1qqm+GZRzfAOVQUXN2/DiSM xDWHN58RZYnsMC7EsmQ8CYLPNadCAFrB685KQg4F18Wd2Xt/aKmmV94ci6YXH5le1k60 gipg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hFIz5l6d; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-205424-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205424-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de2ae12071si2396105a12.896.2024.06.06.22.49.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 22:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-205424-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hFIz5l6d; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-205424-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205424-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 52A5C284054 for ; Fri, 7 Jun 2024 05:49:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E4FC14F111; Fri, 7 Jun 2024 05:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hFIz5l6d" Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CB014EC73 for ; Fri, 7 Jun 2024 05:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717739342; cv=none; b=pasHGZX0/nnKuTyVURjLWcyZ2N/C5fOeDBOEqe66Fz4BBlM30MWgRWtFDSBdZe7ju3ETH180G4m5pF36shX+GBzuJaRRKFOCXGM1u+rimH3JM2QnfdL3MFFQ00TZ4A33Idj99B1ogbd6mJL6MSE9y+zb9i0phwiBLH/50x01YUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717739342; c=relaxed/simple; bh=utoyZmJ3ad8EAeZqrHVGF5rFBfilwKGnsN7FpZP8jxc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q05K8dJawqrGXvkHfuim1qm3mlQC6kV6IZem0mu5Dat2QsdE0V9rwYfqD0vb2ulIkFgbr7Ix8TFlINIICB/T7Sibp3eXF/84pFx32PG6bC95lVcMGF/MK5sNZcCQr8DhJXyBmP7DHp30HKed5jL5PQ2POy8fiIFKaF3uoLIacLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hFIz5l6d; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52bc1261f45so21577e87.0 for ; Thu, 06 Jun 2024 22:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717739338; x=1718344138; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MPpS30B8oQddbNIA4e5SgwQLluo/cGUrwr2ygS5Damc=; b=hFIz5l6d+MEMEVcgMdzBtM7tePyuW+t27q6n7ZRauwsN3qcybSZZvwKMyiA8clTs3G mbU6k09lS68uGhnDGMGe0w7kxLA7PobSsA/cBP5QBVY+x0nlrhlgcZMHEfDny7qWoPtm 0FoUkAEQsOKEQ1YxN4Gd7sotpLDGptvzXQtd5+fZ4DkFs3HW5UlRDgn0mnBUnwtYwA6A E/7MlhTSjADJDJ4lTyXJXJ+9VgqZMdr3BmkKD9UnWjzT3I9XwofBuTl3g+PL8Fjy/CGL Oo8n1ubmS//QL/cJcJbbOMNxNZ8ydozDpssq+0u0gU/6O9QzueMaReoXOX6wz9Fc3osw FAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717739338; x=1718344138; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MPpS30B8oQddbNIA4e5SgwQLluo/cGUrwr2ygS5Damc=; b=VFK4yXHvaxVgXUR0flSBKV/mgUlpOPx6OU87X4tudve7Fvdja0aksZ4UvMaeJpqA3Y ykBeKjmjbpTMaOLic0RZSeho4WNCE5Yk4DjfxjIFw1ummo79hGaHiNA8dn3h2oGqYj64 Dypzc8A4MT26oFJzfdyxRL1qUbJOP21yXYchkD9R6Bo281tWE5edDoXmKtk8wcHs3lFC QlOyfRtY0Jihig8H9nLkKgQPtA70XJvIuVOJD9i3ZaxaL4sINhh916Zu6+O8wFyH44uX vQVRIc5vusKkkntCRQOtXZhiwuLoTP8Te+VFW10nIdb0n3kPK2Hqd9rHCDkzmekESixh argg== X-Forwarded-Encrypted: i=1; AJvYcCVsjY6Bm0dzUMt9/4u+GR+PyhX7t8LAXResk+93wlNJ/4Np2Bgyv0XoI6trP0hW8xnW4ZQPpH/WHOSrekQ/SjQExgQ1CHwKtgqAC6Yf X-Gm-Message-State: AOJu0YxOF8cj7uiyLWQVIH8g2MLpd/c8zXEjCIy2p+avHeh/MXIA+dmi z7SKQCiBjDb6TVn8OUrusJsskilL9fHmPZcguNRlTXE4wPCgbnSkvAduVePAT5g= X-Received: by 2002:a05:6512:39d0:b0:52b:74c4:2731 with SMTP id 2adb3069b0e04-52bb9f17605mr1374676e87.0.1717739338307; Thu, 06 Jun 2024 22:48:58 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyyykxt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::227]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52bbe91a731sm55425e87.82.2024.06.06.22.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 22:48:57 -0700 (PDT) Date: Fri, 7 Jun 2024 08:48:55 +0300 From: Dmitry Baryshkov To: Neil Armstrong Cc: Heikki Krogerus , Greg Kroah-Hartman , Bjorn Andersson , Luca Weiss , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] usb: typec-mux: ptn36502: unregister typec switch on probe error and remove Message-ID: References: <20240606-topic-sm8x50-upstream-retimer-broadcast-mode-v2-0-c6f6eae479c3@linaro.org> <20240606-topic-sm8x50-upstream-retimer-broadcast-mode-v2-1-c6f6eae479c3@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606-topic-sm8x50-upstream-retimer-broadcast-mode-v2-1-c6f6eae479c3@linaro.org> On Thu, Jun 06, 2024 at 03:11:13PM +0200, Neil Armstrong wrote: > Add the missing call to typec_switch_put() when probe fails and > the ptn36502_remove() call is called. > > Fixes: 8e99dc783648 ("usb: typec: add support for PTN36502 redriver") > Signed-off-by: Neil Armstrong > --- > drivers/usb/typec/mux/ptn36502.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry