Received-SPF: pass (google.com: domain of linux-kernel+bounces-205437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <98828510-8eab-4a82-872c-6643bef06da3@oracle.com>
Date: Fri, 7 Jun 2024 07:04:41 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 07/21] fs: xfs: align args->minlen for forced
 allocation alignment
From: John Garry <john.g.garry@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: djwong@kernel.org, hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org,
        jack@suse.cz, chandan.babu@oracle.com, willy@infradead.org,
        axboe@kernel.dk, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, ojaswin@linux.ibm.com,
        ritesh.list@gmail.com, mcgrof@kernel.org, p.raghav@samsung.com,
        linux-xfs@vger.kernel.org, catherine.hoang@oracle.com,
        Dave Chinner <dchinner@redhat.com>
References: <20240429174746.2132161-1-john.g.garry@oracle.com>
 <20240429174746.2132161-8-john.g.garry@oracle.com>
 <c9ac2f74-73f9-4eb5-819e-98a34dfb6b23@oracle.com>
 <ZmF3h2ObrJ5hNADp@dread.disaster.area>
 <bcc35a78-9446-48e4-b1ce-0f11972bd19d@oracle.com>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <bcc35a78-9446-48e4-b1ce-0f11972bd19d@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YzRVZGNacW5vN1ZSd25YRy9lZWNPNGErK3pnR3gwbDRtUjNtNjVEQXl3SEVP?=
 =?utf-8?B?ZGtLdjlQRU1FSEpzaThEcFRzTFdCcElBUDEvZ1ZCNmxHdG1NVjJjcDdGaWFS?=
 =?utf-8?B?TUNxd1VKYkd1a01pMmEvUDhuaWdiQ2ZlY1pHd1JYcVA0dzNHQVNmZzNNVkRh?=
 =?utf-8?B?R0NhNWdSMFpFVmlBMS9PNk9oV0h2WmJ4VDNPNzRIY2VLbHNST1NhdnpTYmJN?=
 =?utf-8?B?amwvYUIyV3lMK1ZmcUFPMVFGNE1lYzBuRlJwRFlKY0Z3Vm83ZTN6cW14NjZu?=
 =?utf-8?B?Ty8xYUFRUEpDbTE5ME8wd2R5YnJvWUdQenZyeTBVUXRKemxIbUo1eGZGdjRV?=
 =?utf-8?B?TEF4RFQxYUZndjRHTllMS0l4R3gyeVY0NDVqSU83REFLYmoxQ2VhbnFqY0k2?=
 =?utf-8?B?ekhKd2w3QlhVT0ppTTV0b3hoUTA3WW9sb1lLS2NDZ3duYkpNSFRxQ0phb0Rr?=
 =?utf-8?B?bmhBU3FmL3ZWUXlPNDB2TDQyL1hUQmdwYmpSS3BEdncyb280WWhoQndONmZv?=
 =?utf-8?B?Y2ZsbTRhQmxmSjl2Ty8vMnBGbitTUVRWRTdOclJhR08rUCtwSVJTVFhjeXVn?=
 =?utf-8?B?akx4ckQ5MlpsaVJSQWZES291S0JORy8xQklVd0JLTXV0d1hyZS9UUnFxKy8v?=
 =?utf-8?B?ZHBvYzlqQVhjY3plWnVmWTNXeGxMYUM3bVhqUkFLTGFLZ1NqUlBEM280ends?=
 =?utf-8?B?VGhWYXpYOVhqVkNxRFZoOVQ1UmtXTEhoUXZnNEhiNWlQQmpUdFZZYjl5UkZu?=
 =?utf-8?B?M2JFZUVySm5Cb0diWWdaV3ZoV0VnaXhibVMwUUFtUVVROGRNNVd0b2ZjR2JE?=
 =?utf-8?B?MlpZS21CelJ2eUNXTEFORS9zRGJjVUx3cm40bWRueUUxNVVocjlPcE9JUTgv?=
 =?utf-8?B?bFFKT0FucHA5aW5idTc1SkhVTzE0R0xnbDY3N05kbUd0cXoxNFdRUzM5ZFBZ?=
 =?utf-8?B?N1BKSnZnMklpYldSZXdnNkpJcXVMeGRXeU8xWHhKLzNpQzNPY1dEdmh5U1ky?=
 =?utf-8?B?YytzcjdldFhSK1hSdUN5V1dTUnN5WmZXQ3V0QkJjNk11MjV2Ui9DT3FqMFBn?=
 =?utf-8?B?TGZwdXR4M3dRdmpMMkVFdmFmMkt1dmZlZmxaQ2NPVy9seE1ra0RWc29FK0ZO?=
 =?utf-8?B?azlxT1FKU0pFcVhNS0lUbmdjR1F2ZjJMYk10Y1VZRjB0UVdUNDBXZy9DbFU4?=
 =?utf-8?B?VkFhY2hTM3JwdmRrNzNhK3hFd2JVc09ZTU9wVVFUWlB6aTBsOG5EVEQrWkg5?=
 =?utf-8?B?bTBnemV5NTRNUXNiUmhvNzZNRDBsWEZMSFg2dkFzbHpwa3lRU0xtdTFONEY0?=
 =?utf-8?B?bE1LZnZaY3NydUhFMzEwUWx1aENCQ3U2b0Uvd3dPMnhKdVVHMTdrVHNhMkxq?=
 =?utf-8?B?b3RMcGs0Z0dOMmd0cExHVzJ3UU5KSU5vWEV6V2xBWHgrWFJJUk1VeEw0T1ZY?=
 =?utf-8?B?OFdvYkRWR3k4NUdOaDZxUnFkWm9tYXRpSm5YRnlHVU9NMUVOWXVhSXAzb3J2?=
 =?utf-8?B?dUFvUXVmdUhGaXhOQmozNWNyY3hwdlplelVOWllveldHQ21yZXZOQzNOUFQ5?=
 =?utf-8?B?VVBzMkxZQzBwYS9SOEFqQ0Y0TitQbGF4SSttMWdyamVTMWNiL1BXT2lmOGxW?=
 =?utf-8?B?ejF3RWlwOGRzbG82THZwUlRZZEVZbUNUVEF1SE5XdjVObHVZa01iZVYxbm5V?=
 =?utf-8?B?YUNsSXFUb09rYytZQUZVZHlsSW9qRVlLTG1OazNNbmRQcXY0TFdYdHU3YU1P?=
 =?utf-8?B?L0RFRHlKM3VRc1NkUVV1RllYQXJ0S3dMNlNTdUNIWFN4aVdYRDVVV1VWTSs0?=
 =?utf-8?B?Y1VBR2UvL0h3ci9ZWUVNaFUxNGlWd3dsMFUxMlpVeUhjcnE5QjVOUWc3cUdi?=
 =?utf-8?B?WHNuM0xuZmlkMXMyQzgzeEljdVhCa2RJcHJIRmw1NlhsalpGaCtjaVQvK2Zq?=
 =?utf-8?B?Q3cvc2QraEdmTnhzbjNFckh1Y2REWTI0eXFHcFJMWWpwUVA5K0l0dmt3RUVJ?=
 =?utf-8?B?YXZBdmVhamxNN3VjVExsaThaYjNyZSs1N0grWjNTaDcrem1ROGp1WlNaa1I5?=
 =?utf-8?B?QmxhT0ZSb0lNY1hQcWtPNkl2QzdZMnBGRTF5MnY0UmtIdUpqb2FRZllpNmNG?=
 =?utf-8?Q?XXTG+kbh1GEaL8fgnui5wYRbS?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	F1SXnLxJqZUcGtHAshyIzCmwsrmXyHOOFzkrSZdzi5NS+skU7f7ruQNV6OMlVoZgCYn2fsAa5fKTZs9S05q8W4FjZlw4mWDgJ2a5AyS5RSaL78o/JsunRSOU+r9k5vsePfrBOY9XOVUCCyyPnFgyuiqsQKt2gk8cLOfLRwM5se03s//gMANPSTRghGaTN4ZBWsrL1Mk0GGCXZc1JnOBSBAEZVPwRRjRD7jY6M5h2MtYRFGda9E2qtIzc26cWLcKdXz2gor0ICU9yT8xP5KD5ePBUyJdIQ97oX0L4+TC64zQWZb0lsd29aGhq+TYBI1PN4ZO/Pa8UuIskIXEnEE0YMjjM9J1Yl1yILy4OlkYAKvlvwCKpXGpjYBTwLbSAHzKZH+yevlNchw1klgeIvKUYpYuTO+ZX5DgjC/hyu/eqn01sSKlPsHgfnhQsrP+ktIQ4XkCPdjZvc0FtvCqpeiHcju2pIoMtI4NJBtl3MfZ7Nfnr6nWLptVfSgvd8KwPgcnDtC3DsB0Qc23fVzHVls8yzOnxL5n5V/3IgRMxa1/l7R7Jjf4n8L/3pE+/9FtPh3liq3AdaL6TiuP1MJcPAkBp7PaPh/SL4+5MpsYYl1DGM5k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 839d032c-44d0-4670-14db-08dc86b7bc23
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 06:04:47.5714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hyP0l53iccTCigll6ma8P2FE4IaBDTH09xgYoGV/z+Sn2BRRXLXTMsFafcbSSmHii/LBj9Qy8wOvC8zEEG9WMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6423
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-06_20,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0
 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406070041
X-Proofpoint-GUID: 9gER1G0bbJLBtEX6W96Y5BKguC6oupY9
X-Proofpoint-ORIG-GUID: 9gER1G0bbJLBtEX6W96Y5BKguC6oupY9

On 06/06/2024 17:22, John Garry wrote:
> 
>> i.e. why didn't it round the start offset down to 48?
>> Answering that question will tell you where the bug is.
> 
> After xfs_bmap_compute_alignments() -> xfs_bmap_extsize_align(), 
> ap->offset=48 - that seems ok.
> 
> Maybe the problem is in xfs_bmap_process_allocated_extent(). For the 
> problematic case when calling that function:
> 
> args->fsbno=7840 args->len=16 ap->offset=48 orig_offset=56 orig_length=24
> 
> So, as the comment reads there, we could not satisfy the original length 
> request, so we move up the position of the extent.
> 
> I assume that we just don't want to do that for forcealign, correct?
> 

JFYI, after making this following change, my stress test ran overnight:

@@ -3506,13 +3513,15 @@ xfs_bmap_process_allocated_extent(
          * very fragmented so we're unlikely to be able to satisfy the
          * hints anyway.
          */
+       if (!xfs_inode_has_forcealign(ap->ip)) {
         if (ap->length <= orig_length)
                 ap->offset = orig_offset;
         else if (ap->offset + ap->length < orig_offset + orig_length)
                 ap->offset = orig_offset + orig_length - ap->length;
-
+       }
+


>>
>> Of course, if the allocation start is rounded down to 48, then
>> the length should be rounded up to 32 to cover the entire range we
>> are writing new data to.