Received-SPF: pass (google.com: domain of linux-kernel+bounces-205444-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fe0ec57b-dad3-4666-abe3-75bcb65fa7df@norik.com>
Date: Fri, 7 Jun 2024 08:14:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name
To: Mark Brown <broonie@kernel.org>, =?UTF-8?Q?P=C3=A9ter_Ujfalusi?=
 <peter.ujfalusi@gmail.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
 Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
 Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
 linux-omap@vger.kernel.org, linux-sound@vger.kernel.org,
 linux-kernel@vger.kernel.org, upstream@lists.phytec.de
References: <20240606070645.3519459-1-primoz.fiser@norik.com>
 <dac7fba4-c7e3-4be9-8072-625d723e6cf5@gmail.com>
 <71d7754e-f72c-4a04-b03e-a0ee0e24c9e0@sirena.org.uk>
From: Primoz Fiser <primoz.fiser@norik.com>
Content-Language: en-US
Organization: Norik systems d.o.o.
In-Reply-To: <71d7754e-f72c-4a04-b03e-a0ee0e24c9e0@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi,

On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
> 
>>> -	card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> -				    "HDMI %s", dev_name(ad->dssdev));
>>> -	if (!card->name)
>>> -		return -ENOMEM;
>>> -
>>> +	card->name = DRV_NAME;
> 
>> I think it would be better to name is simply "HDMI" instead
> 
> That does seem a bit more user friendly.

So card->name = "HDMI" for v2?

Thanks,
BR,
Primoz

-- 
Primoz Fiser                    | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o.            | https://www.norik.com
<https://www.norik.com>  |
Your embedded software partner  | email: info@norik.com
<mailto:info@norik.com> |
Slovenia, EU                    | phone: +386-41-540-545
<tel:+386-41-540-545> |