Received-SPF: pass (google.com: domain of linux-kernel+bounces-205449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, Dong Aisheng <aisheng.dong@nxp.com>, linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>, Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH 4/7] arm64: dts: imx8qm-mek: add pwm and i2c in lvds subsystem
Date: Fri, 07 Jun 2024 08:19:59 +0200
Message-ID: <2116653.KlZ2vcFHjT@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240606-imx8qm-dts-usb-v1-4-565721b64f25@nxp.com>
References: <20240606-imx8qm-dts-usb-v1-0-565721b64f25@nxp.com> <20240606-imx8qm-dts-usb-v1-4-565721b64f25@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi,

Am Donnerstag, 6. Juni 2024, 20:46:58 CEST schrieb Frank Li:
> Add pwm[0,1] and i2c[0,1] in lvds subsystem.
>=20
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 92 ++++++++++++++++++++++=
++++++
>  1 file changed, 92 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/bo=
ot/dts/freescale/imx8qm-mek.dts
> index dbd478af2e474..80cb834d56bc2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -93,6 +93,42 @@ rsc_table1: memory@901ff000 {
>  		};
>  	};
> =20
> +	lvds_backlight0: backlight-lvds0 {
> +		compatible =3D "pwm-backlight";
> +		pwms =3D <&pwm_lvds0 0 100000 0>;
> +
> +		brightness-levels =3D < 0  1  2  3  4  5  6  7  8  9
> +				     10 11 12 13 14 15 16 17 18 19
> +				     20 21 22 23 24 25 26 27 28 29
> +				     30 31 32 33 34 35 36 37 38 39
> +				     40 41 42 43 44 45 46 47 48 49
> +				     50 51 52 53 54 55 56 57 58 59
> +				     60 61 62 63 64 65 66 67 68 69
> +				     70 71 72 73 74 75 76 77 78 79
> +				     80 81 82 83 84 85 86 87 88 89
> +				     90 91 92 93 94 95 96 97 98 99
> +				    100>;
> +		default-brightness-level =3D <80>;
> +	};
> +
> +	lvds_backlight1: backlight-lvds1 {
> +		compatible =3D "pwm-backlight";
> +		pwms =3D <&pwm_lvds1 0 100000 0>;
> +
> +		brightness-levels =3D < 0  1  2  3  4  5  6  7  8  9
> +				     10 11 12 13 14 15 16 17 18 19
> +				     20 21 22 23 24 25 26 27 28 29
> +				     30 31 32 33 34 35 36 37 38 39
> +				     40 41 42 43 44 45 46 47 48 49
> +				     50 51 52 53 54 55 56 57 58 59
> +				     60 61 62 63 64 65 66 67 68 69
> +				     70 71 72 73 74 75 76 77 78 79
> +				     80 81 82 83 84 85 86 87 88 89
> +				     90 91 92 93 94 95 96 97 98 99
> +				    100>;
> +		default-brightness-level =3D <80>;
> +	};
> +
>  	reg_usdhc2_vmmc: usdhc2-vmmc {
>  		compatible =3D "regulator-fixed";
>  		regulator-name =3D "SD1_SPWR";
> @@ -334,6 +370,24 @@ wm8960: audio-codec@1a {
>  	};
>  };
> =20
> +&i2c1_lvds0 {
> +	#address-cells =3D <1>;
> +	#size-cells =3D <0>;

These two properties should be part of the .dtsi.

> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&pinctrl_lvds0_lpi2c1>;
> +	clock-frequency =3D <100000>;
> +	status =3D "okay";
> +};
> +
> +&i2c1_lvds1 {
> +	#address-cells =3D <1>;
> +	#size-cells =3D <0>;

These two properties should be part of the .dtsi.

Best regards,
Alexander

> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&pinctrl_lvds1_lpi2c1>;
> +	clock-frequency =3D <100000>;
> +	status =3D "okay";
> +};
> +
>  &flexcan1 {
>  	pinctrl-names =3D "default";
>  	pinctrl-0 =3D <&pinctrl_flexcan1>;
> @@ -449,6 +503,18 @@ &fec2 {
>  	status =3D "okay";
>  };
> =20
> +&pwm_lvds0 {
> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&pinctrl_pwm_lvds0>;
> +	status =3D "okay";
> +};
> +
> +&pwm_lvds1 {
> +	pinctrl-names =3D "default";
> +	pinctrl-0 =3D <&pinctrl_pwm_lvds1>;
> +	status =3D "okay";
> +};
> +
>  &usdhc1 {
>  	pinctrl-names =3D "default";
>  	pinctrl-0 =3D <&pinctrl_usdhc1>;
> @@ -675,6 +741,32 @@ IMX8QM_M41_GPIO0_01_DMA_UART3_TX			0x06000020
>  		>;
>  	};
> =20
> +	pinctrl_lvds0_lpi2c1: lvds0lpi2c1grp {
> +		fsl,pins =3D <
> +			IMX8QM_LVDS0_I2C1_SCL_LVDS0_I2C1_SCL	0xc600004c
> +			IMX8QM_LVDS0_I2C1_SDA_LVDS0_I2C1_SDA	0xc600004c
> +		>;
> +	};
> +
> +	pinctrl_lvds1_lpi2c1: lvds1lpi2c1grp {
> +		fsl,pins =3D <
> +			IMX8QM_LVDS1_I2C1_SCL_LVDS1_I2C1_SCL	0xc600004c
> +			IMX8QM_LVDS1_I2C1_SDA_LVDS1_I2C1_SDA	0xc600004c
> +		>;
> +	};
> +
> +	pinctrl_pwm_lvds0: pwmlvds0grp {
> +		fsl,pins =3D <
> +			IMX8QM_LVDS0_GPIO00_LVDS0_PWM0_OUT		0x00000020
> +		>;
> +	};
> +
> +	pinctrl_pwm_lvds1: pwmlvds1grp {
> +		fsl,pins =3D <
> +			IMX8QM_LVDS1_GPIO00_LVDS1_PWM0_OUT		0x00000020
> +		>;
> +	};
> +
>  	pinctrl_sai0: sai0grp {
>  		fsl,pins =3D <
>  			IMX8QM_SPI0_CS1_AUD_SAI0_TXC				0x0600004c
>=20
>=20


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/