Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp846215lqt; Thu, 6 Jun 2024 23:28:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvHF06KnRhRzDA4UuHrI589X6MxhS1e7m9UAcHEWt4Qy5R+soCz9rwv0gOFbpsW4oHeDmZsZkQCl+zpN3i4iePWiHmRBVzlYf61wKWRA== X-Google-Smtp-Source: AGHT+IFhkgDgadHi47POpvNxT0YIwP9UIMGKh/G5didGdlvGd8hrHOfKZVI1bFAcIEmey07AaAOI X-Received: by 2002:a05:6a00:1791:b0:702:824a:2a33 with SMTP id d2e1a72fcca58-7040c619520mr1941470b3a.7.1717741720029; Thu, 06 Jun 2024 23:28:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717741720; cv=pass; d=google.com; s=arc-20160816; b=dKNIgZ3UcaR8bRe30MJbX3x4sms9kHtbP1pgUNCiJDwlh8ueDFyeUJrI4mQ3VX4mSF 3eUhpLpzd8IbX1VQH+z2cfWFLHn585gI9G+6AHzHh0LU7k5d71TpGizv3e5sQOEG4omM W4/WxMy/ubKLco7EjA2kxD2k0i6lkrRCmncXWl8qXyU0MTGVofRdZqFTuBFRTV7aQkVw twc6SlZqhm3d4ldL7XfdLt1uEOiMaWcgB8sTQCk3re13VKYm3SefDd+M3EnsoqrrLFCt yg9galw6aWEp6k2/08VO/A8ybEtuAW4OP6kjIq93NSqlkE/cEptPnkfbX5OeFnpF0AKY egNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vLp0abxWPWeq0NDH61AYo4VII9n5wY1ynbuZau1muFU=; fh=tGbXHk/Xa4tO7XwX0ZS8jkvAguS2GMz7Ach949QfcHQ=; b=zxa9zbb9Az0iQfEyy7pfeO7l7Xi+0dyoqKjm1papwIrP+eVrndUaZEuNFgue1oUva6 Y10est+2hua14LXigAioLmcs80dKRmdnbFkgcXt+UIhq+OOXqwxLGYk7vwDADI0J5COC 5zqpGmhXzMPEEhmmzbFNSEh4ZdjN8yFkIqPKBSD4HuGcBO6G9dzi5KTHP5WCIYBK/SoI D7Eeb2xEWMOJ2Yo8Y5wYrMyR9SVpCsSEbsENJrnRc9IIOa5opXbtawaWagMfU1lOyC/K Jn7FHhAIaUSV2/AovkEFoQVLDYL0sscM0fdyiwAhhT0b3cH6OJu05irnZ6Q0ADGvpplA wgnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LXlYbMGv; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-205452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-703fd560a31si2483609b3a.308.2024.06.06.23.28.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 23:28:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-205452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LXlYbMGv; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-205452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 68BE3284184 for ; Fri, 7 Jun 2024 06:26:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 43599150985; Fri, 7 Jun 2024 06:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LXlYbMGv" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B06714F9CC for ; Fri, 7 Jun 2024 06:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717741596; cv=none; b=jdbgeOptoldWzt9v5aYwdLSGC5dSJtUh70FBHiwzR1M6Pz7nM4ayBEJ2XUGE5rohJ9Izn5H/FJT5ZILWHqZH/J8qZAR0sjjP7jbVQpkyKCkf2Ou5hqj0fgjedbv6FuzE3tvpuEQ1pXFSHnF31yd+UNAlR9TWcoLvjI/dM2dA0gY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717741596; c=relaxed/simple; bh=3ZTsHxW/IbapW9/uqLmzADDO9OOBIGtvwKgmTaxJ004=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gDShoQycl4i+I+g7clhw04fc27f/pkLZ/zC9nap/SZPfP391MgdpoaGLZyTkP7LAL+5uv7twRcH9oO/ZTsL0fDCP3wt7QvQ7femkt3kg4jpHOEm+uCUkszLGSVd5dtr9SeUKDPMoiGDM+iwEpwVd2mqnXsy1xFB3SVn+Fs8z1Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LXlYbMGv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717741594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vLp0abxWPWeq0NDH61AYo4VII9n5wY1ynbuZau1muFU=; b=LXlYbMGvZW0l15JcvKkH+AppPozYsfEMCOISkEl4YLZu1cTrue7MwPRCo1uZoSZgCCEH4d tLt/S37LZ7BHa6VcsVPkVoLnfLEJgabYelKMa6py/1ffSmjviyJgjstf+g4IwREA05Ch2K ePuWdb/myOX//wqJuoW/N+lLqKFh64E= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-cLVMIi1uP1mjK4jHSN8bWQ-1; Fri, 07 Jun 2024 02:26:27 -0400 X-MC-Unique: cLVMIi1uP1mjK4jHSN8bWQ-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECE371953949; Fri, 7 Jun 2024 06:26:25 +0000 (UTC) Received: from localhost (unknown [10.72.113.124]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B5F871955F4B; Fri, 7 Jun 2024 06:26:23 +0000 (UTC) Date: Fri, 7 Jun 2024 14:26:18 +0800 From: Baoquan He To: Wenchao Hao , Andrew Morton Cc: Vivek Goyal , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crash: Remove header files which are included more than once Message-ID: References: <20240606091427.3512314-1-haowenchao22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606091427.3512314-1-haowenchao22@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On 06/06/24 at 05:14pm, Wenchao Hao wrote: > Following warning is reported, so remove these duplicated header > including: > > ./kernel/crash_reserve.c: linux/kexec.h is included more than once. > > This is just a clean code, no logic changed. > > Signed-off-by: Wenchao Hao > --- > kernel/crash_reserve.c | 1 - > 1 file changed, 1 deletion(-) I remember someone posted patch to clean this up. Anyway, Acked-by: Baoquan He > > diff --git a/kernel/crash_reserve.c b/kernel/crash_reserve.c > index 5b2722a93a48..d3b4cd12bdd1 100644 > --- a/kernel/crash_reserve.c > +++ b/kernel/crash_reserve.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > > #include > -- > 2.38.1 >