Received-SPF: pass (google.com: domain of linux-kernel+bounces-205465-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 7 Jun 2024 14:49:57 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
CC: <acme@kernel.org>, <peterz@infradead.org>, <mingo@redhat.com>,
	<namhyung@kernel.org>, <mark.rutland@arm.com>,
	<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
	<irogers@google.com>, <adrian.hunter@intel.com>, <kan.liang@linux.intel.com>,
	<acme@redhat.com>, <atrajeev@linux.vnet.ibm.com>, <kjain@linux.ibm.com>,
	<linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf sched map: Add command-name option to filter the
 output map
Message-ID: <ZmKtlQdwk5uwha06@chenyu5-mobl2>
References: <20240417152521.80340-1-vineethr@linux.ibm.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240417152521.80340-1-vineethr@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6pTLR7J2L4W1RjgJR9np7kkJfoHrAolvVHq7Tt2wLNq2yHtjYKso8WY5yuQO?=
 =?us-ascii?Q?9RnSVzRlWAB/daPHvKs+8yXMi8lDMr0pWspN2fBszE5sEuD/xoyqH16gNgsf?=
 =?us-ascii?Q?/76fGb4BF2jz9rP0IEe74d8Sn4C19wUEYCX5QQHXZ216ZvqydQ5oWEVhZzjK?=
 =?us-ascii?Q?k6hPjqCW45E4y1pv09xvxy3l9oirjFyJyaVqmiM6WHOeACWdATfIoqQL7SFm?=
 =?us-ascii?Q?4gno5p1nW0ZKFcfY31tvRY9737SpfYGTc/3j6YvxDrfKTeBt1BUtYZsyz9wi?=
 =?us-ascii?Q?FRIXmI7XapxNzOQ7GvYN8hsQCCU84FqZ46QBI8hDBGG48YThrOD/vQWP+phu?=
 =?us-ascii?Q?dDVMWc9rG6MMeF3OVBjafYlPPC43phzULN7iH7nmPIQGEe4hH+3iFX7UX5yP?=
 =?us-ascii?Q?kEJQd4CE56Lqg+kKS3C25BfaWBed9oOolFvVqTBKzAwkg5EC+LF60EdWI61Y?=
 =?us-ascii?Q?z9TDUjrFrJLbnX/0dSXmksTZi01TA0RHHuzkNxkAUp4Lu+ITFMx2nrzEohOh?=
 =?us-ascii?Q?qs0X0UC7z5NeAtFNJjpjWtsFoZpxGGsC7hb57fFBEdAyjN8zmC47H2vT7vZs?=
 =?us-ascii?Q?Qjhw114ZRRXjw+69v4ED39Cko/hCLd6oYmehc6aqF5iQpG8L3uf+Yu3n5G61?=
 =?us-ascii?Q?fEavegTJ6zlOZP50UP5cV5Yw57HDp6GOiasaELPj60pBvaIqgW0nUiPrt277?=
 =?us-ascii?Q?GoWAI/xOlurnFz5WC7MjhGibr5z4ffimkD0Ct0N6S9orozmbMLAPwWq41qqk?=
 =?us-ascii?Q?5jKk1LFaKyYEOtpGmkIfK60b65K87570v6rvVt2nbB8RSisV1bpm8H+eKil+?=
 =?us-ascii?Q?hbDWHu7bFJq9OzxWHSgjz8NerfMteBcT5+OY18bAcpemQqUSNI5mNKDP1tHG?=
 =?us-ascii?Q?C0hKUSbH08Fm4+q1w5pFEnRBVwLjIjQKY3hWHHp5gpHfG4mBXTrwkmaKXiSB?=
 =?us-ascii?Q?1vGKYvC+VQ6hoJZAN3+7Tf+i3FKkIUz13AkjJmb0cwc+T0JOSkCDJsd8e50p?=
 =?us-ascii?Q?8CcITQzoxmNWRFCllFzhUktSf+LbmFcgQ9CHIJl9F4e/PskD2+jInFXsAFIg?=
 =?us-ascii?Q?hhkYyllLV4y90zAuA7yhv9PU1PPfwhCY2PKwvGihjc4pgYYgoaCOEvw+A+d5?=
 =?us-ascii?Q?tiiGdMXUXqaIDXy8wz01JXNXgTfkOh3xm1KwUTLZ2Z3EksGWkNajn6imYz6A?=
 =?us-ascii?Q?gRQNmiwMBJ+Xe0cP2sMhueuxsZrmfVUnbA/x99nvS8BB+0QQs/e8cgc+qWPT?=
 =?us-ascii?Q?65Dr7gBNjiFLGp6qiD/fJX9vDkFE0KjcNd5E+b3Wns1gg5zY5j/WHTw0/Dd7?=
 =?us-ascii?Q?7RuOnEOqmlOIzZPC9KaR+3FSsUBkVQkkA/kbQcQPOQXE9WRWMApBFkWTxs+a?=
 =?us-ascii?Q?OnQkfibzZQVZPiTeCiSWzlamt5cLnIZafSB/9NBWn+WnBHR3mMpX8SEl0ZGz?=
 =?us-ascii?Q?rSnyeeoR9i9IVh/NL0BikCDACxSnyKNS9JZRiBp/M2L5NVZ0WRPxM1S9XrdF?=
 =?us-ascii?Q?fWVkHcZySiseouBx5lZwiERCBoDrSh3d9LhMSJ+SzsUDEhnYw/rAujXo9RJQ?=
 =?us-ascii?Q?F6gw2TZVap73rdVw63IRVppVXYeoukurmLZEisC1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bbd2af53-15fe-4c63-b7d2-08dc86be1514
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 06:50:13.6467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cM4HQw+3+AJVUCUO3gLGMoW8bvOZrIGRtxhJHauwtq/yvRa6X4b/0QkAenl6P8nIl5FIjmXG8yswnAfz8VB0rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5047
X-OriginatorOrg: intel.com

On 2024-04-17 at 20:55:21 +0530, Madadi Vineeth Reddy wrote:
> By default, perf sched map prints sched-in events for all the tasks
> which may not be required all the time as it prints lot of symbols
> and rows to the terminal.
> 
> With --command-name option, one could specify the specific command
> for which the map has to be shown. This would help in analyzing the
> CPU usage patterns easier for that specific command. Since multiple
> PID's might have the same command name, using command-name filter
> would be more useful for debugging.
> 
> For other tasks, instead of printing the symbol, ** is printed and
> the same . is used to represent idle. ** is used instead of symbol
> for other tasks because it helps in clear visualization of command
> of interest and secondly the symbol itself doesn't mean anything
> because the sched-in of that symbol will not be printed(first sched-in
> contains pid and the corresponding symbol).
> 
> 6.8.0
> ======
>   *A0                   213864.670142 secs A0 => migration/0:18
>   *.                    213864.670148 secs .  => swapper:0
>    .  *B0               213864.670217 secs B0 => migration/1:21
>    .  *.                213864.670223 secs
>    .   .  *C0           213864.670247 secs C0 => migration/2:26
>    .   .  *.            213864.670252 secs
> 
> 6.8.0 + patch (--command-name = schbench)
> =============
>    **  .   ** *A0       213864.671055 secs A0 => schbench:104834
>   *B0  .   .   A0       213864.671156 secs B0 => schbench:104835
>   *C0  .   .   A0       213864.671187 secs C0 => schbench:104836
>   *D0  .   .   A0       213864.671219 secs D0 => schbench:104837
>   *E0  .   .   A0       213864.671250 secs E0 => schbench:104838
>    E0  .  *D0  A0
> 
> This helps in visualizing how a benchmark like schbench is spread over
> the available cpus while also knowing which cpus are idle(.) and which
> are not(**). This will be more useful as number of CPUs increase.
> 
> Signed-off-by: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
> ---
>  tools/perf/Documentation/perf-sched.txt |  4 ++++
>  tools/perf/builtin-sched.c              | 17 ++++++++++++++---
>  2 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/Documentation/perf-sched.txt b/tools/perf/Documentation/perf-sched.txt
> index 5fbe42bd599b..b04a37560935 100644
> --- a/tools/perf/Documentation/perf-sched.txt
> +++ b/tools/perf/Documentation/perf-sched.txt
> @@ -94,6 +94,10 @@ OPTIONS for 'perf sched map'
>  --color-pids::
>  	Highlight the given pids.
>  
> +--command-name::
> +	Map output only for the given command name.
> +	(** indicates other tasks while . is idle).
> +
>  OPTIONS for 'perf sched timehist'
>  ---------------------------------
>  -k::
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 0fce7d8986c0..e60836da53e5 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -156,6 +156,7 @@ struct perf_sched_map {
>  	const char		*color_pids_str;
>  	struct perf_cpu_map	*color_cpus;
>  	const char		*color_cpus_str;
> +	const char		*command;
>  	struct perf_cpu_map	*cpus;
>  	const char		*cpus_str;
>  };
> @@ -1594,8 +1595,6 @@ static int map_switch_event(struct perf_sched *sched, struct evsel *evsel,
>  
>  	sched->curr_thread[this_cpu.cpu] = thread__get(sched_in);
>  
> -	printf("  ");
> -
>  	new_shortname = 0;
>  	if (!tr->shortname[0]) {
>  		if (!strcmp(thread__comm_str(sched_in), "swapper")) {
> @@ -1605,7 +1604,8 @@ static int map_switch_event(struct perf_sched *sched, struct evsel *evsel,
>  			 */
>  			tr->shortname[0] = '.';
>  			tr->shortname[1] = ' ';
> -		} else {
> +		} else if (!sched->map.command || !strcmp(thread__comm_str(sched_in),
> +								sched->map.command)) {
>

I've tested on my machine and it looks good. One minor question, can we do
fuzzy name matching? Say, there are many tasks 'a-taskname-b',
and we can filter them via
perf sched map --command-name=taskname

thanks,
Chenyu