Received-SPF: pass (google.com: domain of linux-kernel+bounces-205467-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Subject: Re: [PATCH 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging
 reserved memory for mpss
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
        <mathieu.poirier@linaro.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
        <conor+dt@kernel.org>, <konrad.dybcio@linaro.org>,
        <manivannan.sadhasivam@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240606143858.4026-1-quic_nainmeht@quicinc.com>
 <20240606143858.4026-4-quic_nainmeht@quicinc.com>
 <c22e20f5-5ca9-485c-991f-9b45e35cd75a@kernel.org>
From: Naina Mehta <quic_nainmeht@quicinc.com>
Message-ID: <da06a758-5239-42d6-e4f8-c78418d9529d@quicinc.com>
Date: Fri, 7 Jun 2024 12:21:06 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <c22e20f5-5ca9-485c-991f-9b45e35cd75a@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 6/6/2024 8:20 PM, Krzysztof Kozlowski wrote:
> On 06/06/2024 16:38, Naina Mehta wrote:
>> The qlink_logging memory region is also used by the modem firmware,
>> add it to reserved memory regions.
>> Also split MPSS DSM region into 2 separate regions.
>>
>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
>>   1 file changed, 13 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> index 9b93f6501d55..9349b1c4e196 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> @@ -366,7 +366,12 @@
>>   			no-map;
>>   		};
>>   
>> -		qdss_mem: qdss@88800000 {
>> +		qdss_mem: qdss@88500000 {
>> +			reg = <0x0 0x88500000 0x0 0x300000>;
>> +			no-map;
>> +		};
>> +
>> +		qlink_logging_mem: qlink_logging@88800000 {
> 
> Sorry, no downstream code.
> 
> Please follow DTS coding style - no underscores in node names. This
> applies to all work sent upstream.
> 

Thanks for pointing this out. I will update in next revision.

Regards,
Naina

> 
> 
> Best regards,
> Krzysztof
>