Received-SPF: pass (google.com: domain of linux-kernel+bounces-205498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9374758d-9f81-4e4f-8405-1f972234173e@redhat.com>
Date: Fri, 7 Jun 2024 09:11:16 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm: zswap: add VM_BUG_ON() if large folio swapin is
 attempted
To: Barry Song <21cnbao@gmail.com>, Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
 Johannes Weiner <hannes@cmpxchg.org>, Nhat Pham <nphamcs@gmail.com>,
 Chengming Zhou <chengming.zhou@linux.dev>,
 Baolin Wang <baolin.wang@linux.alibaba.com>, Chris Li <chrisl@kernel.org>,
 Ryan Roberts <ryan.roberts@arm.com>, Matthew Wilcox <willy@infradead.org>,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240606184818.1566920-1-yosryahmed@google.com>
 <84d78362-e75c-40c8-b6c2-56d5d5292aa7@redhat.com>
 <CAJD7tkZH9C21nx75W9Erun=oUvmad5ujmDyGYWRRHEwPCCizUw@mail.gmail.com>
 <7507d075-9f4d-4a9b-836c-1fbb2fbd2257@redhat.com>
 <CAGsJ_4w_dEyLsPhdJCtRMReXDD116p+U979Yk-8EBu=zx5FWgQ@mail.gmail.com>
 <CAJD7tkYnZCvwUSTAx-N-08b+mVF4yHEdDTbp9oqYrVQXX8M1Cw@mail.gmail.com>
 <CAGsJ_4wAYbofjg99iEr7cEAptH9Ve9WcrSXho8A-Sw54vb8Msw@mail.gmail.com>
From: David Hildenbrand <david@redhat.com>
Content-Language: en-US
Autocrypt: addr=david@redhat.com; keydata=
 xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ
 dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL
 QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp
 XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK
 Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9
 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt
 WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc
 UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv
 jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb
 B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk
 ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW
 AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q
 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp
 rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf
 wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4
 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l
 pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd
 KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE
 BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs
 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF
 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9
 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz
 Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb
 T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A
 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk
 CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G
 NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75
 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx
 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS
 lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv
 AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa
 N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3
 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB
 boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq
 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f
 XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ
 a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq
 Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6
 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8
 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E
 th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr
 jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt
 WNyWQQ==
Organization: Red Hat
In-Reply-To: <CAGsJ_4wAYbofjg99iEr7cEAptH9Ve9WcrSXho8A-Sw54vb8Msw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 06.06.24 23:53, Barry Song wrote:
> On Fri, Jun 7, 2024 at 9:37 AM Yosry Ahmed <yosryahmed@google.com> wrote:
>>
>> On Thu, Jun 6, 2024 at 2:30 PM Barry Song <21cnbao@gmail.com> wrote:
>>>
>>> On Fri, Jun 7, 2024 at 9:17 AM David Hildenbrand <david@redhat.com> wrote:
>>>>
>>>> On 06.06.24 22:31, Yosry Ahmed wrote:
>>>>> On Thu, Jun 6, 2024 at 1:22 PM David Hildenbrand <david@redhat.com> wrote:
>>>>>>
>>>>>> On 06.06.24 20:48, Yosry Ahmed wrote:
>>>>>>> With ongoing work to support large folio swapin, it is important to make
>>>>>>> sure we do not pass large folios to zswap_load() without implementing
>>>>>>> proper support.
>>>>>>>
>>>>>>> For example, if a swapin fault observes that contiguous PTEs are
>>>>>>> pointing to contiguous swap entries and tries to swap them in as a large
>>>>>>> folio, swap_read_folio() will pass in a large folio to zswap_load(), but
>>>>>>> zswap_load() will only effectively load the first page in the folio. If
>>>>>>> the first page is not in zswap, the folio will be read from disk, even
>>>>>>> though other pages may be in zswap.
>>>>>>>
>>>>>>> In both cases, this will lead to silent data corruption.
>>>>>>>
>>>>>>> Proper large folio swapin support needs to go into zswap before zswap
>>>>>>> can be enabled in a system that supports large folio swapin.
>>>>>>>
>>>>>>> Looking at callers of swap_read_folio(), it seems like they are either
>>>>>>> allocated from __read_swap_cache_async() or do_swap_page() in the
>>>>>>> SWP_SYNCHRONOUS_IO path. Both of which allocate order-0 folios, so we
>>>>>>> are fine for now.
>>>>>>>
>>>>>>> Add a VM_BUG_ON() in zswap_load() to make sure that we detect changes in
>>>>>>> the order of those allocations without proper handling of zswap.
>>>>>>>
>>>>>>> Alternatively, swap_read_folio() (or its callers) can be updated to have
>>>>>>> a fallback mechanism that splits large folios or reads subpages
>>>>>>> separately. Similar logic may be needed anyway in case part of a large
>>>>>>> folio is already in the swapcache and the rest of it is swapped out.
>>>>>>>
>>>>>>> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>>>>>>> ---
>>>>>>>
>>>>>>> Sorry for the long CC list, I just found myself repeatedly looking at
>>>>>>> new series that add swap support for mTHPs / large folios, making sure
>>>>>>> they do not break with zswap or make incorrect assumptions. This debug
>>>>>>> check should give us some peace of mind. Hopefully this patch will also
>>>>>>> raise awareness among people who are working on this.
>>>>>>>
>>>>>>> ---
>>>>>>>     mm/zswap.c | 3 +++
>>>>>>>     1 file changed, 3 insertions(+)
>>>>>>>
>>>>>>> diff --git a/mm/zswap.c b/mm/zswap.c
>>>>>>> index b9b35ef86d9be..6007252429bb2 100644
>>>>>>> --- a/mm/zswap.c
>>>>>>> +++ b/mm/zswap.c
>>>>>>> @@ -1577,6 +1577,9 @@ bool zswap_load(struct folio *folio)
>>>>>>>         if (!entry)
>>>>>>>                 return false;
>>>>>>>
>>>>>>> +     /* Zswap loads do not handle large folio swapins correctly yet */
>>>>>>> +     VM_BUG_ON(folio_test_large(folio));
>>>>>>> +
>>>>>>
>>>>>> There is no way we could have a WARN_ON_ONCE() and recover, right?
>>>>>
>>>>> Not without making more fundamental changes to the surrounding swap
>>>>> code. Currently zswap_load() returns either true (folio was loaded
>>>>> from zswap) or false (folio is not in zswap).
>>>>>
>>>>> To handle this correctly zswap_load() would need to tell
>>>>> swap_read_folio() which subpages are in zswap and have been loaded,
>>>>> and then swap_read_folio() would need to read the remaining subpages
>>>>> from disk. This of course assumes that the caller of swap_read_folio()
>>>>> made sure that the entire folio is swapped out and protected against
>>>>> races with other swapins.
>>>>>
>>>>> Also, because swap_read_folio() cannot split the folio itself, other
>>>>> swap_read_folio_*() functions that are called from it should be
>>>>> updated to handle swapping in tail subpages, which may be questionable
>>>>> in its own right.
>>>>>
>>>>> An alternative would be that zswap_load() (or a separate interface)
>>>>> could tell swap_read_folio() that the folio is partially in zswap,
>>>>> then we can just bail and tell the caller that it cannot read the
>>>>> large folio and that it should be split.
>>>>>
>>>>> There may be other options as well, but the bottom line is that it is
>>>>> possible, but probably not something that we want to do right now.
>>>>>
>>>>> A stronger protection method would be to introduce a config option or
>>>>> boot parameter for large folio swapin, and then make CONFIG_ZSWAP
>>>>> depend on it being disabled, or have zswap check it at boot and refuse
>>>>> to be enabled if it is on.
>>>>
>>>> Right, sounds like the VM_BUG_ON() really is not that easily avoidable.
>>>>
>>>> I was wondering, if we could WARN_ON_ONCE and make the swap code detect
>>>> this like a read-error from disk.
>>>>
>>>> I think do_swap_page() detects that by checking if the folio is not
>>>> uptodate:
>>>>
>>>> if (unlikely(!folio_test_uptodate(folio))) {
>>>>          ret = VM_FAULT_SIGBUS;
>>>>          goto out_nomap;
>>>> }
>>>>
>>>> So maybe WARN_ON_ONCE() + triggering that might be a bit nicer to the
>>>> system (but the app would crash either way, there is no way around it).
>>>>
>>>
>>> I'd rather fallback to small folios swapin instead crashing apps till we fix
>>> the large folio swapin in zswap :-)
>>
>> I think David is referring to catching the buggy cases that do not
>> properly fallback to small folios with zswap, not as an alternative to
>> the fallback. This is at least what I had in mind with the patch.
> 
> Cool. Thanks for the clarification. I'm fine with keeping the fallback,
> whether it's the current VM_BUG_ON or David's recommended
> SIGBUS.
> 
> Currently, mainline doesn't support large folios swap-in, so I see
> your patch as a helpful warning for those attempting large folio
> swap-in to avoid making mistakes like loading large folios from
> zswap.
> 
> In fact, I spent a week trying to figure out why my app was crashing
> before I added 'if (zswap_is_enabled()) goto fallback'. If your patch
> had come earlier, it would have saved me that week of work :-)
> 
> To me, a direct crash seems like a more straightforward way to
> prompt people to fallback when attempting large folio swap-ins.
> So, I am slightly in favor of your current patch.

BUG_ON and friends are frowned-upon, in particular in scenarios where we 
can recover or that are so unexpected that they can be found during 
early testing.

I have no strong opinion on this one, but likely a VM_WARN_ON would also 
be sufficient to find such issues early during testing. No need to crash 
the machine.

-- 
Cheers,

David / dhildenb