Received-SPF: pass (google.com: domain of linux-kernel+bounces-205609-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 7 Jun 2024 10:34:29 +0200
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Brian Xu <brian.xu@amd.com>, Lizhi Hou <lizhi.hou@amd.com>,
	Michal Simek <michal.simek@amd.com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
	Vinod Koul <vkoul@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fixes possible threading issue
Message-ID: <ZmLGFXPEP-FqgUdn@localhost.localdomain>
Mail-Followup-To: Markus Elfring <Markus.Elfring@web.de>,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Brian Xu <brian.xu@amd.com>, Lizhi Hou <lizhi.hou@amd.com>,
	Michal Simek <michal.simek@amd.com>,
	Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
	Vinod Koul <vkoul@kernel.org>, LKML <linux-kernel@vger.kernel.org>
References: <20240527-xdma-fixes-v1-1-f31434b56842@bootlin.com>
 <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f0eaf77b-eed9-4f8e-8009-983250fa56a8@web.de>

Le 27/05/24 - 20:32, Markus Elfring a écrit :
> > The current interrupt handler in xdma.c was using xdma->stop_request
> > before locking the vchan lock.
> 
> 1. Will an additional imperative wording become helpful here?
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc1#n94
> 
> 2. How do you think about to use the summary phrase “Fix data synchronisation in xdma_channel_isr()”?

I changed the commit message and summary in the v2.
 
> 3. Will development interests grow for the usage of a statement like “guard(spin)(&xchan->vchan.lock);”?
>    https://elixir.bootlin.com/linux/v6.10-rc1/source/include/linux/cleanup.h#L124

I don't feel comfortable switching `guard` as the rest of the driver is 
not using it yet. Since this is a fix, I prefer to maintain consistency 
with the style of the rest of the driver.

Thanks,
Louis Chauvet

> 
> Regards,
> Markus
> 

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com