Received-SPF: pass (google.com: domain of linux-kernel+bounces-205631-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240530210714.364118-1-rick.p.edgecombe@intel.com> <20240530210714.364118-10-rick.p.edgecombe@intel.com>
In-Reply-To: <20240530210714.364118-10-rick.p.edgecombe@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 7 Jun 2024 10:46:15 +0200
Message-ID: <CABgObfbzjLtzFX9wC_FU2GKGF_Wq8og+O=pSnG_yD8j1Dn3jAg@mail.gmail.com>
Subject: Re: [PATCH v2 09/15] KVM: x86/tdp_mmu: Support mirror root for TDP MMU
To: Rick Edgecombe <rick.p.edgecombe@intel.com>
Cc: seanjc@google.com, kvm@vger.kernel.org, kai.huang@intel.com, 
	dmatlack@google.com, erdemaktas@google.com, isaku.yamahata@gmail.com, 
	linux-kernel@vger.kernel.org, sagis@google.com, yan.y.zhao@intel.com, 
	Isaku Yamahata <isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 30, 2024 at 11:07=E2=80=AFPM Rick Edgecombe
<rick.p.edgecombe@intel.com> wrote:
> +static inline bool kvm_on_mirror(const struct kvm *kvm, enum kvm_process=
 process)
> +{
> +       if (!kvm_has_mirrored_tdp(kvm))
> +               return false;
> +
> +       return process & KVM_PROCESS_PRIVATE;
> +}
> +
> +static inline bool kvm_on_direct(const struct kvm *kvm, enum kvm_process=
 process)
> +{
> +       if (!kvm_has_mirrored_tdp(kvm))
> +               return true;
> +
> +       return process & KVM_PROCESS_SHARED;
> +}

These helpers don't add much, it's easier to just write
kvm_process_to_root_types() as

if (process & KVM_PROCESS_SHARED)
  ret |=3D KVM_DIRECT_ROOTS;
if (process & KVM_PROCESS_PRIVATE)
  ret |=3D kvm_has_mirror_tdp(kvm) ? KVM_MIRROR_ROOTS : KVM_DIRECT_ROOTS;

WARN_ON_ONCE(!ret);
return ret;

(Here I chose to rename kvm_has_mirrored_tdp to kvm_has_mirror_tdp;
but if you prefer to call it kvm_has_external_tdp, it's just as
readable. Whatever floats your boat).

>         struct kvm *kvm =3D vcpu->kvm;
> -       struct kvm_mmu_page *root =3D root_to_sp(vcpu->arch.mmu->root.hpa=
);
> +       enum kvm_tdp_mmu_root_types root_type =3D tdp_mmu_get_fault_root_=
type(kvm, fault);
> +       struct kvm_mmu_page *root =3D tdp_mmu_get_root(vcpu, root_type);

Please make this

  struct kvm_mmu_page *root =3D tdp_mmu_get_root_for_fault(vcpu, fault);

Most other uses of tdp_mmu_get_root() don't really need a root_type,
I'll get to them in the reviews for the rest of the series.

>  enum kvm_tdp_mmu_root_types {
>         KVM_VALID_ROOTS =3D BIT(0),
> +       KVM_DIRECT_ROOTS =3D BIT(1),
> +       KVM_MIRROR_ROOTS =3D BIT(2),
>
> -       KVM_ANY_ROOTS =3D 0,
> -       KVM_ANY_VALID_ROOTS =3D KVM_VALID_ROOTS,
> +       KVM_ANY_ROOTS =3D KVM_DIRECT_ROOTS | KVM_MIRROR_ROOTS,
> +       KVM_ANY_VALID_ROOTS =3D KVM_DIRECT_ROOTS | KVM_MIRROR_ROOTS | KVM=
_VALID_ROOTS,

See previous review.

> +static inline enum kvm_tdp_mmu_root_types tdp_mmu_get_fault_root_type(st=
ruct kvm *kvm,
> +                                                                     str=
uct kvm_page_fault *fault)
> +{
> +       if (fault->is_private)
> +               return kvm_process_to_root_types(kvm, KVM_PROCESS_PRIVATE=
);
> +       return KVM_DIRECT_ROOTS;
> +}
> +
> +static inline struct kvm_mmu_page *tdp_mmu_get_root(struct kvm_vcpu *vcp=
u, enum kvm_tdp_mmu_root_types type)
> +{
> +       if (type =3D=3D KVM_MIRROR_ROOTS)
> +               return root_to_sp(vcpu->arch.mmu->mirror_root_hpa);
> +       return root_to_sp(vcpu->arch.mmu->root.hpa);
> +}

static inline struct kvm_mmu_page *
tdp_mmu_get_root_for_fault(struct kvm_vcpu *vcpu, struct kvm_page_fault *fa=
ult)
{
  hpa_t root_hpa;
  if (unlikely(fault->is_private && kvm_has_mirror_tdp(kvm)))
    root_hpa =3D vcpu->arch.mmu->mirror_root_hpa;
  else
    root_hpa =3D vcpu->arch.mmu->root.hpa;
  return root_to_sp(root_hpa);
}

Paolo