Received-SPF: pass (google.com: domain of linux-kernel+bounces-205652-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7ecabb8e342b9bd4fc2552bce29dc8c7a98971ee.camel@gmail.com>
Subject: Re: [PATCH 1/8] iio: accel: adxl313: simplify with
 spi_get_device_match_data()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Lucas Stankus
 <lucas.p.stankus@gmail.com>, Lars-Peter Clausen <lars@metafoo.de>, Michael
 Hennerich <Michael.Hennerich@analog.com>, Jonathan Cameron
 <jic23@kernel.org>, Puranjay Mohan <puranjay@kernel.org>, Ramona Bolboaca
 <ramona.bolboaca@analog.com>, Oleksij Rempel <o.rempel@pengutronix.de>,
 kernel@pengutronix.de, Cosmin Tanislav <cosmin.tanislav@analog.com>, Marius
 Cristea <marius.cristea@microchip.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 07 Jun 2024 10:57:28 +0200
In-Reply-To: <20240606-spi-match-data-v1-1-320b291ee1fe@linaro.org>
References: <20240606-spi-match-data-v1-0-320b291ee1fe@linaro.org>
	 <20240606-spi-match-data-v1-1-320b291ee1fe@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-06-06 at 16:26 +0200, Krzysztof Kozlowski wrote:
> Use spi_get_device_match_data() helper to simplify a bit the driver.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> =C2=A0drivers/iio/accel/adxl313_spi.c | 8 +-------
> =C2=A01 file changed, 1 insertion(+), 7 deletions(-)
>=20
> diff --git a/drivers/iio/accel/adxl313_spi.c b/drivers/iio/accel/adxl313_=
spi.c
> index b7cc15678a2b..6f8d73f6e5a9 100644
> --- a/drivers/iio/accel/adxl313_spi.c
> +++ b/drivers/iio/accel/adxl313_spi.c
> @@ -72,13 +72,7 @@ static int adxl313_spi_probe(struct spi_device *spi)
> =C2=A0	if (ret)
> =C2=A0		return ret;
> =C2=A0
> -	/*
> -	 * Retrieves device specific data as a pointer to a
> -	 * adxl313_chip_info structure
> -	 */
> -	chip_data =3D device_get_match_data(&spi->dev);
> -	if (!chip_data)
> -		chip_data =3D (const struct adxl313_chip_info
> *)spi_get_device_id(spi)->driver_data;
> +	chip_data =3D spi_get_device_match_data(spi);
> =C2=A0

I understand you're sticking with the original code but since you're doing =
this,
could we maybe add proper error checking for the call? Maybe Jonathan can e=
ven
tweak that while applying...

(same comment for patch 3)

- Nuno S=C3=A1