Received-SPF: pass (google.com: domain of linux-kernel+bounces-205657-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <8f74bb906951f56c753081af1462560fe98bc822.camel@gmail.com>
Subject: Re: [PATCH v6 5/9] iio: adc: ad7173: refactor ain and vref selection
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>
Date: Fri, 07 Jun 2024 11:04:30 +0200
In-Reply-To: <20240606-ad4111-v6-5-573981fb3e2e@analog.com>
References: <20240606-ad4111-v6-0-573981fb3e2e@analog.com>
	 <20240606-ad4111-v6-5-573981fb3e2e@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
> Move validation of analog inputs and reference voltage selection to
> separate functions to reduce the size of the channel config parsing
> function and improve readability.
> Add defines for the number of analog inputs in a channel.
>=20
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---
> =C2=A0drivers/iio/adc/ad7173.c | 68 +++++++++++++++++++++++++++++++++----=
----------
> -
> =C2=A01 file changed, 47 insertions(+), 21 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 8631f218b69e..4040edbd1c32 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -60,6 +60,7 @@
> =C2=A0#define AD7173_CH_SETUP_AINPOS_MASK	GENMASK(9, 5)
> =C2=A0#define AD7173_CH_SETUP_AINNEG_MASK	GENMASK(4, 0)
> =C2=A0
> +#define AD7173_NO_AINS_PER_CHANNEL	2
> =C2=A0#define AD7173_CH_ADDRESS(pos, neg) \
> =C2=A0	(FIELD_PREP(AD7173_CH_SETUP_AINPOS_MASK, pos) | \
> =C2=A0	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> @@ -629,6 +630,7 @@ static int ad7173_setup(struct iio_dev *indio_dev)
> =C2=A0static unsigned int ad7173_get_ref_voltage_milli(struct ad7173_stat=
e *st,
> =C2=A0						 u8 reference_select)
> =C2=A0{
> +	struct device *dev =3D &st->sd.spi->dev;
> =C2=A0	int vref;
> =C2=A0
> =C2=A0	switch (reference_select) {
> @@ -652,9 +654,11 @@ static unsigned int ad7173_get_ref_voltage_milli(str=
uct
> ad7173_state *st,
> =C2=A0		return -EINVAL;
> =C2=A0	}
> =C2=A0
> -	if (vref < 0)
> +	if (vref < 0) {
> +		dev_err(dev, "Cannot use reference %u. Error:%d\n",
> +			reference_select, vref);
> =C2=A0		return vref;
> -
> +	}
> =C2=A0	return vref / (MICRO / MILLI);
> =C2=A0}

unrelated?

- Nuno S=C3=A1