Received-SPF: pass (google.com: domain of linux-kernel+bounces-205658-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240606034016.82559-1-21cnbao@gmail.com> <a04dd2d6-8526-488f-b46a-80c530891415@redhat.com>
In-Reply-To: <a04dd2d6-8526-488f-b46a-80c530891415@redhat.com>
From: Barry Song <21cnbao@gmail.com>
Date: Fri, 7 Jun 2024 21:00:38 +1200
Message-ID: <CAGsJ_4wSFWMpgd38XqZNNdfDT9PHp+xNjfFYY46yHvjqwJ5QkA@mail.gmail.com>
Subject: Re: [PATCH] mm: introduce pmd|pte_need_soft_dirty_wp helpers for
 softdirty write-protect
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, chrisl@kernel.org, 
	kasong@tencent.com, linux-kernel@vger.kernel.org, minchan@kernel.org, 
	ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, 
	willy@infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 7, 2024 at 8:46=E2=80=AFPM David Hildenbrand <david@redhat.com>=
 wrote:
>
> On 06.06.24 05:40, Barry Song wrote:
> > From: Barry Song <v-songbaohua@oppo.com>
> >
> > This patch introduces the pte_need_soft_dirty_wp and
> > pmd_need_soft_dirty_wp helpers to determine if write protection is
> > required for softdirty tracking. This can enhance code readability
> > and improve its overall appearance.
> >
> > These new helpers are utilized in gup, huge_memory, and protect,
> > and are particularly applied in do_swap_page() to optimize a
> > softdirty scenario where mkwrite can still be performed.
>
> [...]
>
> > +static inline bool pmd_need_soft_dirty_wp(struct vm_area_struct *vma, =
pmd_t pmd)
> > +{
> > +     return vma_soft_dirty_enabled(vma) && !pmd_soft_dirty(pmd);
> > +}
> > +
> > +static inline bool pte_need_soft_dirty_wp(struct vm_area_struct *vma, =
pte_t pte)
> > +{
> > +     return vma_soft_dirty_enabled(vma) && !pte_soft_dirty(pte);
> > +}
> > +
>
> Should these be "needs" ? I tend to like these names/semantics.

yes. "needs" is better. Glad to know you have the common liking
for these names.

>
>
> >   static inline void vma_iter_config(struct vma_iterator *vmi,
> >               unsigned long index, unsigned long last)
> >   {
> > diff --git a/mm/memory.c b/mm/memory.c
> > index db9130488231..6307c43796aa 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -4322,7 +4322,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
> >       if (!folio_test_ksm(folio) &&
> >           (exclusive || folio_ref_count(folio) =3D=3D 1)) {
> >               if ((vma->vm_flags & VM_WRITE) && !userfaultfd_pte_wp(vma=
, pte) &&
> > -                 !vma_soft_dirty_enabled(vma)) {
> > +                 !pte_need_soft_dirty_wp(vma, pte)) {
> >                       pte =3D pte_mkwrite(pte, vma);
>
> I would move that into a separate patch, as it's not a simple conversion.
>

cool. will separate it in v2.

> --
> Cheers,
>
> David / dhildenb
>

Thanks
Barry