Received-SPF: pass (google.com: domain of linux-kernel+bounces-205702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <389546877ae11b18928b432e86710acf83974f67.camel@gmail.com>
Subject: Re: [PATCH v6 9/9] iio: adc: ad7173: Add support for AD411x devices
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org, Dumitru Ceclan
 <mitrutzceclan@gmail.com>
Date: Fri, 07 Jun 2024 11:20:52 +0200
In-Reply-To: <20240606-ad4111-v6-9-573981fb3e2e@analog.com>
References: <20240606-ad4111-v6-0-573981fb3e2e@analog.com>
	 <20240606-ad4111-v6-9-573981fb3e2e@analog.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>=20
> Add support for AD4111/AD4112/AD4114/AD4115/AD4116.
>=20
> The AD411X family encompasses a series of low power, low noise, 24-bit,
> sigma-delta analog-to-digital converters that offer a versatile range of
> specifications.
>=20
> This family of ADCs integrates an analog front end suitable for processin=
g
> both fully differential and single-ended, bipolar voltage inputs
> addressing a wide array of industrial and instrumentation requirements.
>=20
> - All ADCs have inputs with a precision voltage divider with a division
> =C2=A0 ratio of 10.
> - AD4116 has 5 low level inputs without a voltage divider.
> - AD4111 and AD4112 support current inputs (0 mA to 20 mA) using a 50ohm
> =C2=A0 shunt resistor.
>=20
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---
> =C2=A0drivers/iio/adc/ad7173.c | 317 ++++++++++++++++++++++++++++++++++++=
++++++----
> -
> =C2=A01 file changed, 285 insertions(+), 32 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 58da5717fd36..cfcd12447e24 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
>=20
...

> =C2=A0static const struct ad7173_device_info ad7172_2_device_info =3D {
> =C2=A0	.name =3D "ad7172-2",
> =C2=A0	.id =3D AD7172_2_ID,
> -	.num_inputs =3D 5,
> +	.num_voltage_in =3D 5,
> =C2=A0	.num_channels =3D 4,
> =C2=A0	.num_configs =3D 4,
> =C2=A0	.num_gpios =3D 2,
> +	.higher_gpio_bits =3D false,

No need to explicitly set to 'false'. Ditto for the other places...

...

>=20
> =C2=A0static int ad7173_validate_voltage_ain_inputs(struct ad7173_state *=
st,
> =C2=A0					=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unsigned int ain0, unsigned int
> ain1)
> =C2=A0{
> @@ -946,15 +1145,30 @@ static int ad7173_validate_voltage_ain_inputs(stru=
ct
> ad7173_state *st,
> =C2=A0	=C2=A0=C2=A0=C2=A0 st->info->has_pow_supply_monitoring)
> =C2=A0		return 0;
> =C2=A0
> -	special_input0 =3D AD7173_IS_REF_INPUT(ain0);
> -	special_input1 =3D AD7173_IS_REF_INPUT(ain1);
> +	special_input0 =3D AD7173_IS_REF_INPUT(ain0) ||
> +			 (ain0 =3D=3D AD4111_VINCOM_INPUT && st->info-
> >has_vincom_input);
> +	special_input1 =3D AD7173_IS_REF_INPUT(ain1) ||
> +			 (ain1 =3D=3D AD4111_VINCOM_INPUT && st->info-
> >has_vincom_input);
> +

Wondering... can ain1 (or ain0) be AD4111_VINCOM_INPUT and !st->info-
>has_vincom_input? Would that actually be acceptable? It would assume it's =
not
so we should check that right? Or am I missing something?

- Nuno S=C3=A1