Received-SPF: pass (google.com: domain of linux-kernel+bounces-205733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 7 Jun 2024 11:30:53 +0200
From: Joel Granados <j.granados@samsung.com>
To: Kees Cook <kees@kernel.org>,
	=?utf-8?B?PT91dGYtOD9xP1Rob21hc19XZWk9QzM9OUZzY2h1aD89?=
	<linux@weissschuh.net>
CC: Luis Chamberlain <mcgrof@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Current state of the sysctl constification effort
Message-ID: <20240607093053.ig6cqrr3xdxhbbt5@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <202406061143.27C12F44A3@keescook>
CMS-TYPE: 201P
References: <7823ff95-1490-4c1b-b489-a9c05adad645@t-8ch.de>
	<CGME20240531163128eucas1p20976d08e829373bfa8aa04fda1c7bec4@eucas1p2.samsung.com>
	<202405310930.5E2728A@keescook>
	<20240605082625.6hwdc3haim66rr7v@joelS2.panther.com>
	<202406061143.27C12F44A3@keescook>

On Thu, Jun 06, 2024 at 11:52:25AM -0700, Kees Cook wrote:
> On Wed, Jun 05, 2024 at 10:26:25AM +0200, Joel Granados wrote:
> > On Fri, May 31, 2024 at 09:31:24AM -0700, Kees Cook wrote:
...
> > @kees: Since you have probably done these before, I'll ask you the
> > questions:
> > 
> > 1. The idea is to send Linus the treewide-constify patch on its own at
> >    the end of the merge window for 6.11. Right?
> 
> Right. The best time is likely around Wed on the second week of the merge
> window, assuming all dependencies have landed. And it could be sent
> earlier if all the dependencies land sooner than that.
That makes sense. I have added a reminder to myself to do this when the
time comes. Feel free (@kees and @thomas) to scream at me if you see
that I might be forgetting :)

> 
> > 2. Is there a special way to send these treewide patches? Or is it just
> >    a regular PR with an explanation on why it is being done?
> 
> I would do a regular PR with all the details for Linus to do the change
> himself, but many times people send these as an explicit patch. For
> example, include the full Coccinelle script, or the "sed" command
> line, etc, and then detail any "by hand" changes that were needed on
> top of that.
@Thomas: have you sent the 11/11 patch on its own to the lists? I cant
find it in my history. Please send it as a stand-alone patch, so It can
go into sysctl just like the others.

> 
> > 3. Can you please send (if there are any) me any examples where this has
> >    been done in the past. Maybe some lore.kernel.org links?
> 
> I found this one that is a good example, though it's a PATCH not a GIT PULL:
> 
> https://lore.kernel.org/lkml/20221220134519.3dd1318b@gandalf.local.home/
> became
> https://git.kernel.org/linus/292a089d78d3e2f7944e60bb897c977785a321e3
> 

Thx for the help

Best

-- 

Joel Granados