Received-SPF: pass (google.com: domain of linux-kernel+bounces-205786-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <06c41273-47c3-421a-8fbe-dbcf8321de7e@collabora.com>
Date: Fri, 7 Jun 2024 15:04:01 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, cmllamas@google.com,
 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 kernel-team@android.com, llvm@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [PATCH v1 1/2] selftests/mm: Include linux/mman.h
To: Edward Liaw <edliaw@google.com>, shuah@kernel.org,
 Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling
 <morbo@google.com>, Justin Stitt <justinstitt@google.com>,
 Andrew Morton <akpm@linux-foundation.org>
References: <20240605223637.1374969-1-edliaw@google.com>
 <20240605223637.1374969-2-edliaw@google.com>
 <b5e4ca79-8be0-4085-adfa-e8ee1c855fdb@collabora.com>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <b5e4ca79-8be0-4085-adfa-e8ee1c855fdb@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 6/7/24 2:44 PM, Muhammad Usama Anjum wrote:
> On 6/6/24 3:36 AM, Edward Liaw wrote:
>> thuge-gen defines MAP_HUGE_* macros that are provided by linux/mman.h
>> since 4.15. Removes the macros and includes linux/mman.h instead.
>>
>> Signed-off-by: Edward Liaw <edliaw@google.com>
>> ---
>>  tools/testing/selftests/mm/thuge-gen.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
>> index ea7fd8fe2876..034635317935 100644
>> --- a/tools/testing/selftests/mm/thuge-gen.c
>> +++ b/tools/testing/selftests/mm/thuge-gen.c
>> @@ -15,6 +15,7 @@
>>  
>>  #define _GNU_SOURCE 1
>>  #include <sys/mman.h>
>> +#include <linux/mman.h>
>>  #include <stdlib.h>
>>  #include <stdio.h>
>>  #include <sys/ipc.h>
>> @@ -28,10 +29,6 @@
>>  #include "vm_util.h"
>>  #include "../kselftest.h"
>>  
>> -#define MAP_HUGE_2MB    (21 << MAP_HUGE_SHIFT)
>> -#define MAP_HUGE_1GB    (30 << MAP_HUGE_SHIFT)
>> -#define MAP_HUGE_SHIFT  26
>> -#define MAP_HUGE_MASK   0x3f
> Totally makes sense.
> Reviewed-by: Muhammad Usama Anjum <usama.anju@collabora.com>
Fixing typo:
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> 
>>  #if !defined(MAP_HUGETLB)
>>  #define MAP_HUGETLB	0x40000
>>  #endif
> 

-- 
BR,
Muhammad Usama Anjum