Received-SPF: pass (google.com: domain of linux-kernel+bounces-205799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <329d2f78f55f7df1f03d8581cd108b51f01da86a.camel@gmail.com>
Subject: Re: [PATCH v6 3/9] iio: adc: ad_sigma_delta: add disable_one
 callback
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>, dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Fri, 07 Jun 2024 12:16:06 +0200
In-Reply-To: <c361a87c-f447-4a40-8972-ff2399795ee3@gmail.com>
References: <20240606-ad4111-v6-0-573981fb3e2e@analog.com>
	 <20240606-ad4111-v6-3-573981fb3e2e@analog.com>
	 <be5c166e088e28e8c1e4a09da0ed71163fae727e.camel@gmail.com>
	 <c361a87c-f447-4a40-8972-ff2399795ee3@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 12:29 +0300, Ceclan, Dumitru wrote:
> On 07/06/2024 12:02, Nuno S=C3=A1 wrote:
> > On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > >=20
> > > Sigma delta ADCs with a sequencer need to disable the previously enab=
led
> > > channel when reading using ad_sigma_delta_single_conversion(). This w=
as
> > > done manually in drivers for devices with sequencers.
> > >=20
> > > This patch implements handling of single channel disabling after a
> > > single conversion.
> > >=20
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > > ---
> >=20
> > You could have this done in separate patches... Oh well, this is simple
> > enough
> > that I don't care much.
> >=20
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> >=20
>=20
> Separate patches would break driver functionality then fix it.
> The drivers would not probe as disable_one() callback is missing.
>=20
> This would have been alright?
>=20

No, it's not... I mean, you could also only enforce the disable_one() prese=
nce
after updating all users but I agree this is simple enough to go in one pat=
ch.

- Nuno S=C3=A1