Received-SPF: pass (google.com: domain of linux-kernel+bounces-205819-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <4b1d0a0cc9f05f68d586e9ac8d40b8028a96e341.camel@gmail.com>
Subject: Re: [PATCH v6 6/9] iio: adc: ad7173: add support for special inputs
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>, dumitru.ceclan@analog.com
Cc: Lars-Peter Clausen <lars@metafoo.de>, Michael Hennerich
 <Michael.Hennerich@analog.com>, Jonathan Cameron <jic23@kernel.org>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 David Lechner <dlechner@baylibre.com>,  linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org
Date: Fri, 07 Jun 2024 12:29:36 +0200
In-Reply-To: <849357a8-848e-4b9f-9683-1db2eeda39af@gmail.com>
References: <20240606-ad4111-v6-0-573981fb3e2e@analog.com>
	 <20240606-ad4111-v6-6-573981fb3e2e@analog.com>
	 <822eec36a530f659e4924886ad8d2bf272accd59.camel@gmail.com>
	 <849357a8-848e-4b9f-9683-1db2eeda39af@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 12:34 +0300, Ceclan, Dumitru wrote:
> On 07/06/2024 12:06, Nuno S=C3=A1 wrote:
> > On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > >=20
> > > =C2=A0Add support for selecting REF+ and REF- inputs on all models.
> > > =C2=A0Add support for selecting ((AVDD1 =E2=88=92 AVSS)/5) inputs
> > > =C2=A0 on supported models.
> > >=20
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> > > ---
> > > =C2=A0drivers/iio/adc/ad7173.c | 29 +++++++++++++++++++++++++++--
> > > =C2=A01 file changed, 27 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> > > index 4040edbd1c32..d16fa081a285 100644
> > > --- a/drivers/iio/adc/ad7173.c
> > > +++ b/drivers/iio/adc/ad7173.c
> > > @@ -66,6 +66,13 @@
> > > =C2=A0	 FIELD_PREP(AD7173_CH_SETUP_AINNEG_MASK, neg))
> > > =C2=A0#define AD7173_AIN_TEMP_POS	17
> > > =C2=A0#define AD7173_AIN_TEMP_NEG	18
> > > +#define AD7173_AIN_POW_MON_POS	19
> > > +#define AD7173_AIN_POW_MON_NEG	20
> > > +#define AD7173_AIN_REF_POS	21
> > > +#define AD7173_AIN_REF_NEG	22
> > > +
> > > +#define AD7173_IS_REF_INPUT(x)		((x) =3D=3D AD7173_AIN_REF_POS || \
> > > +					(x) =3D=3D AD7173_AIN_REF_NEG)
> > > =C2=A0
> > > =C2=A0#define AD7172_2_ID			0x00d0
> > > =C2=A0#define AD7175_ID			0x0cd0
> > > @@ -146,6 +153,8 @@ struct ad7173_device_info {
> > > =C2=A0	unsigned int id;
> > > =C2=A0	char *name;
> > > =C2=A0	bool has_temp;
> > > +	/* ((AVDD1 =E2=88=92 AVSS)/5) */
> > > +	bool has_pow_supply_monitoring;
> > > =C2=A0	bool has_input_buf;
> > > =C2=A0	bool has_int_ref;
> > > =C2=A0	bool has_ref2;
> > > @@ -216,6 +225,7 @@ static const struct ad7173_device_info
> > > ad7173_device_info[] =3D {
> > > =C2=A0		.has_temp =3D true,
> > > =C2=A0		.has_input_buf =3D true,
> > > =C2=A0		.has_int_ref =3D true,
> > > +		.has_pow_supply_monitoring =3D true,
> > > =C2=A0		.clock =3D 2 * HZ_PER_MHZ,
> > > =C2=A0		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
> > > =C2=A0		.num_sinc5_data_rates =3D
> > > ARRAY_SIZE(ad7173_sinc5_data_rates),
> > > @@ -230,6 +240,7 @@ static const struct ad7173_device_info
> > > ad7173_device_info[] =3D {
> > > =C2=A0		.has_temp =3D false,
> > > =C2=A0		.has_input_buf =3D true,
> > > =C2=A0		.has_ref2 =3D true,
> > > +		.has_pow_supply_monitoring =3D true,
> > > =C2=A0		.clock =3D 2 * HZ_PER_MHZ,
> > > =C2=A0		.sinc5_data_rates =3D ad7173_sinc5_data_rates,
> > > =C2=A0		.num_sinc5_data_rates =3D
> > > ARRAY_SIZE(ad7173_sinc5_data_rates),
> > > @@ -245,6 +256,7 @@ static const struct ad7173_device_info
> > > ad7173_device_info[] =3D {
> > > =C2=A0		.has_input_buf =3D true,
> > > =C2=A0		.has_int_ref =3D true,
> > > =C2=A0		.has_ref2 =3D true,
> > > +		.has_pow_supply_monitoring =3D false,
> >=20
> > No need to set the 'false' cases...
> >=20
> >=20
> > - Nuno S=C3=A1
>=20
> This was suggested by David Lechner to ensure consistency with has_temp
> regarding another field, I considered that it would apply here as well.
> https://lore.kernel.org/all/CAMknhBGaJxXvsQ8cZkgDsKLVjOY5y2pzox-99hdOCrUa=
oZdsxg@mail.gmail.com/
>=20

Well, I would argue that the has_temp flag being set to 0 is also unneeded =
and
can be removed (in another patch).
> This would also increase visibility towards what features does a specific
> model support as it is clearly stated with "=3D false" rather than lookin=
g
> for what fields are not set within the struct.

IMO, the omission of the flag is already pretty clear that the feature is n=
ot
available. Typically we don't initialize things that do not need to be
initialized (less LOC)...

- Nuno S=C3=A1