Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp956545lqt; Fri, 7 Jun 2024 04:05:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV2uHLKV+17rcBrhJuVIYNf9zShG3ONeVmzKuIZFTA/fwO0jruVsIws26E5vDrdqdoSp4FhUeJbub/kL1841+3RbvqN1uPXW7WC6izVLA== X-Google-Smtp-Source: AGHT+IE8tB3F8864VX2tnx747pZMOWX3+qhWJM1PImvYskp0Dg6YC9Ab85+n6vBqu7ZK8+rERVtX X-Received: by 2002:a05:620a:318c:b0:795:2d5c:2a4e with SMTP id af79cd13be357-7952f0d63e7mr941423185a.13.1717758323781; Fri, 07 Jun 2024 04:05:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717758323; cv=pass; d=google.com; s=arc-20160816; b=bCJQKpBQxZDBc9mqvETDa2cgdR0gK9co89tP9XBwmxoe3l//EwFcbA7M7Om5dWOjh6 c+kS/pys8+C/bw0UGGX3lW9AvecFjP83yB1oW/Lu+7kEns8OsOpF0naxT5QoAcPL1+k1 dtRoR0ucI4ZbgE2T/oXn8XN6/QHWc5Xa9N4G8asP5ytpexQdCfVP33FTq3e2QNONg4bx uUm1Jr0YlN/5OcjviDNyIO93ZJfsayrPq6L4GHYQSnbXGe/UfGomjDdHBXcIj83gLINf kv9b09yOyxfsO0h50uHkMagMKw9uoyPSr0PmG6mF4aWxfOQ/kU8EmrM8XQEhRIjVznZ9 PLKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=AmIjA5nwSCeFSX1hJqzM4hW+dHzSCRSbJz8VnGZAtFA=; fh=qnN3uoouU3hQrTsokjPpROjLAxsv/zo2RBEBE/97V8E=; b=nKwHbk4ftSLts5Y1d6t7qZF7yPVxluqoilPaDEbAxLsm29zTaPGImMNhYxSz70oiFE AFX92J3oQLd+LaEX5VswjVTcKVLOPQnEiz+H0WYQrt3NNxNJRvjm892QVvj093h/Nzvi f5Cy84yXYG5U8SZpBMaACe8mgwLXRUPZge7HN/jATV1oTywNsFcUaprDeFAabbj4nErn kQr7FpRdU1IplTBSt/+h82LNYef/im1Ey/bULcG/ulmKC/xtdWsN0jLDV6AewPkcdEAG XwqswC/imBgmj8SiiT2EE2Xoz8BVSZ+gRSDZg1dpJJQ6XAWP015IibCTAF1NHibAjU4V y41A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-205868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205868-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-44038b77cb0si32237011cf.692.2024.06.07.04.05.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 04:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-205868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=sina.com); spf=pass (google.com: domain of linux-kernel+bounces-205868-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-205868-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7D2181C2259F for ; Fri, 7 Jun 2024 11:05:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 19301187321; Fri, 7 Jun 2024 11:05:17 +0000 (UTC) Received: from mail78-36.sinamail.sina.com.cn (mail78-36.sinamail.sina.com.cn [219.142.78.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606C715E5A3 for ; Fri, 7 Jun 2024 11:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=219.142.78.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717758316; cv=none; b=GlCgP4lpMkFok2zsN0duMINgKt465igFt9XFRvkiaVf7xTDdmQ0U/sMhnWQIFPM6pOnwQOv0NR4tpRoSqR3LCVzq+8WmzXdxSyxwZo2lqM3Ez1JMyTIUebn0bAKh/HFbIo6YviBFeb45Va1D34bp1MWGASaeOIaZdIewcfDuxWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717758316; c=relaxed/simple; bh=2hIGzyAM/ydipJ0a6gCRQYGh6EjForkYrE3iRYGhVM4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UV6pHOi5ejfk/0dyp0mbwkGng+Zc2WVHpkPi/PmraOGIXXs0AZvKB7W7AoyOqfNLb6+R0AJ4mae113IZ3caBqAMVsxfvjUOBxbWSsfLVgNmAItKrqkTqCmw3xbTnoI8Uc4m+h3ZdvBwNnSkjFB4/n4DaIePlIb4Foz9s/qNplB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; arc=none smtp.client-ip=219.142.78.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.25.117.214]) by sina.com (172.16.235.25) with ESMTP id 6662E937000036D1; Fri, 7 Jun 2024 19:04:26 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 27571434210352 X-SMAIL-UIID: 7075AAB57E174405BDF22D17F8609E62-20240607-190426-1 From: Hillf Danton To: Leon Romanovsky Cc: Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org, Dan Williams , Linus Torvalds , RDMA mailing list Subject: Re: [PATCH -rc] workqueue: Reimplement UAF fix to avoid lockdep worning Date: Fri, 7 Jun 2024 19:04:14 +0800 Message-Id: <20240607110414.1953-1-hdanton@sina.com> In-Reply-To: <20240606102921.GE13732@unreal> References: <4c4f1fb769a609a61010cb6d884ab2841ef716d3.1716885172.git.leon@kernel.org> <20240531034851.GF3884@unreal> <20240604105456.1668-1-hdanton@sina.com> <20240604113834.GO3884@unreal> <20240605111055.1843-1-hdanton@sina.com> <20240606073801.GA13732@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 6 Jun 2024 13:29:21 +0300 Leon Romanovsky wrote: > On Thu, Jun 06, 2024 at 10:38:01AM +0300, Leon Romanovsky wrote: > > > > Thanks, I started to run our tests with Dan's revert. > > https://lore.kernel.org/all/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com/ > > > > As premature results, it fixed my lockdep warnings, but it will take time till I get full confidence. > > Don't series fixed reported issue. > I am happy to nominate you for the 2024 Kidding Lore Award ($2) if the uaf in the subject line got fixed with Dan's revert.