Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932143AbYBFBo1 (ORCPT ); Tue, 5 Feb 2008 20:44:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756568AbYBFBoS (ORCPT ); Tue, 5 Feb 2008 20:44:18 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:55207 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756504AbYBFBoR (ORCPT ); Tue, 5 Feb 2008 20:44:17 -0500 From: "Rafael J. Wysocki" To: "H. Peter Anvin" Subject: Re: [rft] s2ram wakeup moves to .c, could fix few machines Date: Wed, 6 Feb 2008 02:42:14 +0100 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Pavel Machek , kernel list , Linux-pm mailing list References: <20080205190600.GB11613@elf.ucw.cz> <200802060227.14385.rjw@sisk.pl> <47A90F23.80009@zytor.com> In-Reply-To: <47A90F23.80009@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802060242.15097.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 948 Lines: 22 On Wednesday, 6 of February 2008, H. Peter Anvin wrote: > Rafael J. Wysocki wrote: > > On Tuesday, 5 of February 2008, Pavel Machek wrote: > >> This rewrites wakeup code to .c, and it fixes stack (should use movl > >> ,%esp, not movw). Testers wanted. Makefile infrastructure was done by > >> hpa, cleanups by rjw. > > > > I'll test it tomorrow and I still have some more cleanups (I was distracted by > > a nasty scheduler issue in the current mainline). > > The asm() for making beeps really need to be moved to a function and > cleaned up (redone in C using inb()/outb()) if they are to be retained > at all. Yes, they are. For some people they're the only tool to debug broken resume. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/