Received-SPF: pass (google.com: domain of linux-kernel+bounces-205904-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240521095536.3869399-1-fshao@chromium.org> <9f73dffc48394e6304263ac2293a2b18864ae3dd.camel@collabora.com>
In-Reply-To: <9f73dffc48394e6304263ac2293a2b18864ae3dd.camel@collabora.com>
From: Fei Shao <fshao@chromium.org>
Date: Fri, 7 Jun 2024 19:20:04 +0800
Message-ID: <CAC=S1njnqrdrQqJZYQ7mffgmAUUxtoO7utZumED0dmX=Fa9+Qw@mail.gmail.com>
Subject: Re: [PATCH] media: mediatek: vcodec: Reduce msg queue trans buffer size
To: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, 
	Hans Verkuil <hverkuil-cisco@xs4all.nl>, Yunfei Dong <yunfei.dong@mediatek.com>, 
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>, Dan Carpenter <dan.carpenter@linaro.org>, 
	Matthias Brugger <matthias.bgg@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, 
	Tiffany Lin <tiffany.lin@mediatek.com>, Xiaoyong Lu <xiaoyong.lu@mediatek.com>, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 
	linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 31, 2024 at 8:47=E2=80=AFPM Nicolas Dufresne
<nicolas.dufresne@collabora.com> wrote:
>
> Le mardi 21 mai 2024 =C3=A0 17:54 +0800, Fei Shao a =C3=A9crit :
> > In the MediaTek HW vcodec pipeline, the `trans` buffer is used to
> > transfer the data decoded by the lat decoder to the core decoder.
> >
> > In the beginning, 6MB and 30MB were allocated for the trans buffer to
> > handle FHD and higher-resolution contents respectively, but it turns ou=
t
> > that's more than enough in practice and there's room for improvement.
> >
> > The buffer sizes were reduced to 5MB / 8MB respectively and the decoder=
s
> > have been validated to work normally on the MediaTek Android products.
> > It's time to adopt that change in the upstream MediaTek vcodec driver.
> >
> > Reduce the msg queue trans buffer size to 5MB / 8MB respectively to
> > optimize the memory usage per decoder instance and improve the overall
> > system performance.
>
> I don't disagree with the change, but it feels like this is has hack over=
 a
> hack. We have an entropy decoder (LAT) metadata buffer, which of course i=
s
> resolution dependent, for which we hardcore two sizes.
>
> Any chance Mediatek can document this blob, or at least document the prop=
er
> relation between the size and the resolution ? This way we could dynamica=
lly
> size the buffer for the chosen resolution and trust it to remain big enou=
gh for
> a long time. Removing the non scientific claim of "have been validated", =
which
> is producible for anyone hitting issue with that change in the future.
>
> Nicolas
>

Sorry for the delayed reply. I totally agree with your point, but last
time I was told these are what they are using internally so I guess
it's not there... or it could be me that didn't ask the right question
(we want to do this with finer granularity or dynamically).
If we don't get an answer here, I can also bring this up to MediaTek
next time and see if they can provide more details.

Regards,
Fei