Received-SPF: pass (google.com: domain of linux-kernel+bounces-205925-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8c3db3d5-8ddc-427c-8db2-980b14afb258@arm.com>
Date: Fri, 7 Jun 2024 12:34:42 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Documentation: Add ARM64 for reserving ZONE_MOVABLE
Content-Language: en-GB
To: Dev Jain <dev.jain@arm.com>, linux-arm-kernel@lists.infradead.org,
 catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net,
 linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com,
 suzuki.poulose@arm.com, broonie@kernel.org, James.Morse@arm.com,
 Anshuman.Khandual@arm.com
References: <20240604052856.546183-1-dev.jain@arm.com>
From: Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <20240604052856.546183-1-dev.jain@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 04/06/2024 06:28, Dev Jain wrote:
> kernelcore and movablecore kernel command line works for ARM64. Update
> the Documentation to reflect the same.
> 
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index b600df82669d..7282d6057e32 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2544,7 +2544,7 @@
>  
>  	keepinitrd	[HW,ARM] See retain_initrd.
>  
> -	kernelcore=	[KNL,X86,IA-64,PPC,EARLY]
> +	kernelcore=	[KNL,X86,IA-64,PPC,ARM64,EARLY]

Given these are both arch-agnostic parameters, wouldn't the correct change be to
remove all the arch-specific labels, i.e. [KNL,EARLY]? In fact, wasn't IA-64
removed from the kernel?

>  			Format: nn[KMGTPE] | nn% | "mirror"
>  			This parameter specifies the amount of memory usable by
>  			the kernel for non-movable allocations.  The requested
> @@ -3612,7 +3612,7 @@
>  	mousedev.yres=	[MOUSE] Vertical screen resolution, used for devices
>  			reporting absolute coordinates, such as tablets
>  
> -	movablecore=	[KNL,X86,IA-64,PPC,EARLY]
> +	movablecore=	[KNL,X86,IA-64,PPC,ARM64,EARLY]
>  			Format: nn[KMGTPE] | nn%
>  			This parameter is the complement to kernelcore=, it
>  			specifies the amount of memory used for migratable