Received-SPF: pass (google.com: domain of linux-kernel+bounces-205948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Crescent Hsieh <crescentcy.hsieh@moxa.com>
To: Jiri Slaby <jirislaby@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	Crescent Hsieh <crescentcy.hsieh@moxa.com>
Subject: [PATCH 5/6] tty: serial: 8250: Add support for Moxa PCIe boards to switch interface
Date: Fri,  7 Jun 2024 19:43:35 +0800
Message-Id: <20240607114336.4496-6-crescentcy.hsieh@moxa.com>
In-Reply-To: <20240607114336.4496-1-crescentcy.hsieh@moxa.com>
References: <20240607114336.4496-1-crescentcy.hsieh@moxa.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Se63jfOWaFb2afB1Erg3JNpH5dCHav4YIw70rZjQFrbq1m3ezs/t8L01nFes?=
 =?us-ascii?Q?rml7HtHXoD5y7j8x2LCccgXwFkGEsntydY5STnyohu0ZwRw7zUt3Isef2F86?=
 =?us-ascii?Q?ryljOEPXAHao2PBqxPSWO5w5DHCo+gBIuinHh6g/ZNCGb+Iqs9uiuz6UbEkE?=
 =?us-ascii?Q?0qdgl/tuS+WwOh+7KnLRq40vhoO7zmGxW8GHYGIuTxhnIygRBjjFSIo6NfQJ?=
 =?us-ascii?Q?aA55fUafv8izN6cE4aguDe8NtMHoI4n+zP0NDwX+W6isR7dMjGKhUVifEUNb?=
 =?us-ascii?Q?bmUba1JnsiEIxzsxTPSv53HfrtO4VPM3l4/zB6g9J1mfzwYSvnek8qcKmoYG?=
 =?us-ascii?Q?FW1pyqyaxFbb6LG2ULVHdUT8s3xFL1TvLVrzEG1Sw5niyl752B1ziE2QEwUg?=
 =?us-ascii?Q?IA5bOYzvQZfAE1egyV8e6+CeWyv/UYnHjfBIyNC96sABK3aVjujdBIwe9/OH?=
 =?us-ascii?Q?JgOkeHxjXU8tGpdMw/3dvoPBlohdtd8ZAQVQrFw49EN6AfO3XiQgk4atrty6?=
 =?us-ascii?Q?dTtzO+bhbQk5LY656xmxXZD+wygofTytE1pthv42w2sSm4wAupCQEUr+iC0K?=
 =?us-ascii?Q?IXmJmANZ0ik/CUeYhl6N7IFZiCJCecXFsKrYLrE6EE1VDSFUlHC3xVb0O36I?=
 =?us-ascii?Q?biL3LpG78A/MFLQdsR0DZEN49z/qRKMX2exvZQedMEWyVlxaSgkQ80l0xl29?=
 =?us-ascii?Q?QSbaFz2pY8PJ7zw3/+g3LihwPbMVHSAAk8dGlFHovPuzUYl+z3i9owrWhEPI?=
 =?us-ascii?Q?NYcdPpfVSoG8vuUN2g0TAMrio3nT+j1YReZpF7ZF41G7njXbXVtLuHhTtYKm?=
 =?us-ascii?Q?jsP4XNpsQMrnKN9QRsechjsCvhCvNeTw4dOJsrFalo8KUGfW3wHyNpWbvdne?=
 =?us-ascii?Q?oCrDUDdfbrD0DIiSWfqr8REdoly1x2DO4Xjjrw0RlxsH80c53lThVrxRtjdh?=
 =?us-ascii?Q?AUucqknsNHVLaKLroOUNBhlNX0kSUo4FUdX5H9FvorLSOV5SqyvQ25wLV7qO?=
 =?us-ascii?Q?wcvRianC5zl4oNeYrPZ+HtfjIexauJFbpUOKXAYNoi3JE/nGqge3dkwuSqEq?=
 =?us-ascii?Q?Nn7Tqr7o0zXqajswK0iW6EUdu8xFyUJh2hwRHsazt/1gEPocwtRkBkDQpFWZ?=
 =?us-ascii?Q?4LnHgOcY+ta+vU34RYjSGGxHnmv5SMBGHo9hQ1ewKTXR/0eP67FwJnXoyYFT?=
 =?us-ascii?Q?lNRm8rv37NKmUyM5AnFxN5rfx4WQ31EtGsXTVBgN7VrwbgiHkI+Xm9aTSV/i?=
 =?us-ascii?Q?VYq25ea3Vvp7bkNjNn1KgqCNIF2BRRhBGC+LrytqjCES/RXQVvS7yKpw0MfQ?=
 =?us-ascii?Q?rTgXiGtcD5QAk8O6dDt0jPoT+DvqmStiTX14cQhQ3mNdx7ZMhZREWKFw/ZAM?=
 =?us-ascii?Q?hsZvW7ESr7KG3lwkNAgFV8GZoBcLzB/t7Wgzw6Cba0w/lidNP9aqF2u1XnU/?=
 =?us-ascii?Q?THf0v0M1I/SzOljUAuxew2wxJmqp1Xn5RMMzDsJ+qy2towzEIK7eN81WPE6g?=
 =?us-ascii?Q?+ywBrgMlmp84yVjV29h5q8Wnb/7QSJuxc4bT3cH+GdheNNXus4JhnvMXQH/O?=
 =?us-ascii?Q?gSWJZkTNRXqTt6u9DWlrRt9He+5Zqfdouck2v6lvbFbtY6KfA4+dQpqf9EMC?=
 =?us-ascii?Q?0A=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f167d30-2afa-4679-52ca-08dc86e7192b
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 11:43:49.8787
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JP/5iJRWJcoRSSL2BqUePbyr52cSQ00oEia+QvuAfKUpEkudfWys6tIN6ggkhUMHzW5HZJ8+0GnYjOrganCsmZYVHc+k7440H7HFBtFtUik=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR01MB5588

This patch adds support for Moxa PCIe serial boards to switch the serial
interface by using ioctl() command "TIOCSRS485" with the flags of struct
"serial_rs485":

    - RS232                  = (no flags are set)
    - RS422                  = SER_RS485_ENABLED | SER_RS485_MODE_RS422
    - RS485_2W (half-duplex) = SER_RS485_ENABLED
    - RS485_4W (full-duplex) = SER_RS485_ENABLED | SER_RS485_RX_DURING_TX

Signed-off-by: Crescent Hsieh <crescentcy.hsieh@moxa.com>
---
 drivers/tty/serial/8250/8250_pci.c | 46 ++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index e4e6493a5497..e2fcddec9ab5 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -2010,6 +2010,10 @@ enum {
 	MOXA_SUPP_RS485 = BIT(2),
 };
 
+static const struct serial_rs485 pci_moxa_rs485_supported = {
+	.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RX_DURING_TX | SER_RS485_MODE_RS422,
+};
+
 static bool pci_moxa_is_pcie(unsigned short device)
 {
 	if (device == PCI_DEVICE_ID_MOXA_CP102E     ||
@@ -2078,6 +2082,37 @@ static int pci_moxa_set_interface(const struct pci_dev *dev,
 	return 0;
 }
 
+/*
+ * Moxa PCIe boards support switching the serial interface using the ioctl()
+ * command "TIOCSRS485".
+ *
+ *      RS232                   = (no flags are set)
+ *      RS422                   = SER_RS485_ENABLED | SER_RS485_MODE_RS422
+ *      RS485_2W (half-duplex)  = SER_RS485_ENABLED
+ *      RS485_4W (full-duplex)  = SER_RS485_ENABLED | SER_RS485_RX_DURING_TX
+ */
+static int pci_moxa_rs485_config(struct uart_port *port,
+				 struct ktermios *termios,
+				 struct serial_rs485 *rs485)
+{
+	struct pci_dev *dev = to_pci_dev(port->dev);
+	u8 mode = MOXA_RS232;
+
+	if (rs485->flags & SER_RS485_ENABLED) {
+		if (rs485->flags & SER_RS485_MODE_RS422)
+			mode = MOXA_RS422;
+		else if (rs485->flags & SER_RS485_RX_DURING_TX)
+			mode = MOXA_RS485_4W;
+		else
+			mode = MOXA_RS485_2W;
+	} else {
+		if (!(pci_moxa_supported_rs(dev) & MOXA_SUPP_RS232))
+			return -ENODEV;
+	}
+
+	return pci_moxa_set_interface(dev, port->port_id, mode);
+}
+
 static int pci_moxa_init(struct pci_dev *dev)
 {
 	unsigned short device = dev->device;
@@ -2120,9 +2155,20 @@ pci_moxa_setup(struct serial_private *priv,
 		const struct pciserial_board *board,
 		struct uart_8250_port *port, int idx)
 {
+	struct pci_dev *dev = priv->dev;
 	unsigned int bar = FL_GET_BASE(board->flags);
 	int offset;
 
+	if (pci_moxa_is_pcie(dev->device) || pci_moxa_is_mini_pcie(dev->device)) {
+		if (pci_moxa_supported_rs(dev) & MOXA_SUPP_RS485) {
+			port->port.rs485_config = pci_moxa_rs485_config;
+			port->port.rs485_supported = pci_moxa_rs485_supported;
+
+			if (!(pci_moxa_supported_rs(dev) & MOXA_SUPP_RS232))
+				port->port.rs485.flags = SER_RS485_ENABLED | SER_RS485_MODE_RS422;
+		}
+	}
+
 	if (board->num_ports == 4 && idx == 3)
 		offset = 7 * board->uart_offset;
 	else
-- 
2.34.1