Received-SPF: pass (google.com: domain of linux-kernel+bounces-205725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 7 Jun 2024 09:27:39 +0000
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hao Ge <hao.ge@linux.dev>
Cc: bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org,
	hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hao Ge <gehao@kylinos.cn>
Subject: Re: [PATCH] media: intel/ipu6: Fix a null pointer dereference in
 ipu6_isys_query_stream_by_source
Message-ID: <ZmLSi6y4cYBplGpN@kekkonen.localdomain>
References: <20240607082542.380166-1-hao.ge@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240607082542.380166-1-hao.ge@linux.dev>

Hi Hao,

Thanks for the patch.

On Fri, Jun 07, 2024 at 04:25:42PM +0800, Hao Ge wrote:
> From: Hao Ge <gehao@kylinos.cn>
> 
> stream is NULL when source is less than 0 in
> ipu6_isys_query_stream_by_source. It's a null
> pointer dereference.

Applied. Rewrapped this, lines can be up to 75 characters long.

> 
> Actually, this should be isys->adev->auxdev.dev.
> 
> Fixes: 3c1dfb5a69cf ("media: intel/ipu6: input system video nodes and buffer queues")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> index c8a33e1e910c..06090cc0a476 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> @@ -943,7 +943,7 @@ ipu6_isys_query_stream_by_source(struct ipu6_isys *isys, int source, u8 vc)
>  		return NULL;
>  
>  	if (source < 0) {
> -		dev_err(&stream->isys->adev->auxdev.dev,
> +		dev_err(&isys->adev->auxdev.dev,
>  			"query stream with invalid port number\n");
>  		return NULL;
>  	}

-- 
Regards,

Sakari Ailus