Received-SPF: pass (google.com: domain of linux-kernel+bounces-206049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ff4e0e14-9f3e-4d8b-a2a6-75dfc1f6e96b@gmail.com>
Date: Fri, 7 Jun 2024 13:31:07 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v10 06/14] page_pool: convert to use netmem
To: Steven Rostedt <rostedt@goodmis.org>,
 Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org,
 linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
 sparclinux@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
 linux-arch@vger.kernel.org, bpf@vger.kernel.org,
 linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
 dri-devel@lists.freedesktop.org, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Donald Hunter <donald.hunter@gmail.com>,
 Jonathan Corbet <corbet@lwn.net>,
 Richard Henderson <richard.henderson@linaro.org>,
 Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner
 <mattst88@gmail.com>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
 Helge Deller <deller@gmx.de>, Andreas Larsson <andreas@gaisler.com>,
 Jesper Dangaard Brouer <hawk@kernel.org>,
 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
 Masami Hiramatsu <mhiramat@kernel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Arnd Bergmann <arnd@arndb.de>, Alexei Starovoitov <ast@kernel.org>,
 Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>,
 Martin KaFai Lau <martin.lau@linux.dev>, Eduard Zingerman
 <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
 Yonghong Song <yonghong.song@linux.dev>,
 John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>,
 Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
 Jiri Olsa <jolsa@kernel.org>, Steffen Klassert
 <steffen.klassert@secunet.com>, Herbert Xu <herbert@gondor.apana.org.au>,
 David Ahern <dsahern@kernel.org>,
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
 Shuah Khan <shuah@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 David Wei <dw@davidwei.uk>, Jason Gunthorpe <jgg@ziepe.ca>,
 Yunsheng Lin <linyunsheng@huawei.com>, Shailend Chand <shailend@google.com>,
 Harshitha Ramamurthy <hramamurthy@google.com>,
 Shakeel Butt <shakeel.butt@linux.dev>, Jeroen de Borst
 <jeroendb@google.com>, Praveen Kaligineedi <pkaligineedi@google.com>,
 linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>
References: <20240530201616.1316526-1-almasrymina@google.com>
 <20240530201616.1316526-7-almasrymina@google.com>
 <20240605214837.44efcc6f@gandalf.local.home>
Content-Language: en-US
From: Pavel Begunkov <asml.silence@gmail.com>
In-Reply-To: <20240605214837.44efcc6f@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/6/24 02:48, Steven Rostedt wrote:
> On Thu, 30 May 2024 20:16:05 +0000
> Mina Almasry <almasrymina@google.com> wrote:
> 
>> @@ -42,51 +42,52 @@ TRACE_EVENT(page_pool_release,
>>   TRACE_EVENT(page_pool_state_release,
>>   
>>   	TP_PROTO(const struct page_pool *pool,
>> -		 const struct page *page, u32 release),
>> +		 netmem_ref netmem, u32 release),
>>   
>> -	TP_ARGS(pool, page, release),
>> +	TP_ARGS(pool, netmem, release),
>>   
>>   	TP_STRUCT__entry(
>>   		__field(const struct page_pool *,	pool)
>> -		__field(const struct page *,		page)
>> +		__field(netmem_ref,			netmem)
> 
> Why make this of type "netmem_ref" and not just "unsigned long"?
> 
>>   		__field(u32,				release)
>>   		__field(unsigned long,			pfn)
>>   	),
>>   
>>   	TP_fast_assign(
>>   		__entry->pool		= pool;
>> -		__entry->page		= page;
>> +		__entry->netmem		= netmem;
> 
> You could have this be:
> 
> 		__entry->netmem		= (__force unsigned long)netmem;
> 
>>   		__entry->release	= release;
>> -		__entry->pfn		= page_to_pfn(page);
>> +		__entry->pfn		= netmem_to_pfn(netmem);
>>   	),
>>   
>> -	TP_printk("page_pool=%p page=%p pfn=0x%lx release=%u",
>> -		  __entry->pool, __entry->page, __entry->pfn, __entry->release)
>> +	TP_printk("page_pool=%p netmem=%lu pfn=0x%lx release=%u",
>> +		  __entry->pool, (__force unsigned long)__entry->netmem,
> 
> And not have to expose the above text to user space (look at the format
> file it produces).
> 
> It being of type "netmem_ref" in the ring buffer is useless.

netmem is a pointer with one bit serving as a flag, considering
mangling it might be better to %p it and perhaps also print its
type (page* vs iov) separately.

-- 
Pavel Begunkov