Received-SPF: pass (google.com: domain of linux-kernel+bounces-206082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0a578e84-6a28-4477-9aa4-dcfb37fc28b0@arm.com>
Date: Fri, 7 Jun 2024 13:50:28 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/6] perf: build: Setup PKG_CONFIG_LIBDIR for cross
 compilation
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>, James Clark <james.clark@arm.com>,
 Ian Rogers <irogers@google.com>, "Liang, Kan" <kan.liang@linux.intel.com>,
 Nick Terrell <terrelln@fb.com>, Thomas Richter <tmricht@linux.ibm.com>,
 Changbin Du <changbin.du@huawei.com>, Fangrui Song <maskray@google.com>,
 Mateusz Kowalczyk <fuuzetsu@fuuzetsu.co.uk>, linux-kernel@vger.kernel.org,
 linux-perf-users@vger.kernel.org
References: <20240604093223.1934236-1-leo.yan@arm.com>
 <20240604093223.1934236-2-leo.yan@arm.com> <ZmHx2EFK9cSWgUIK@google.com>
Content-Language: en-US
From: Leo Yan <leo.yan@arm.com>
In-Reply-To: <ZmHx2EFK9cSWgUIK@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Namhyung,

On 6/6/24 18:28, Namhyung Kim wrote:

>> --- a/tools/build/feature/Makefile
>> +++ b/tools/build/feature/Makefile
>> @@ -82,7 +82,19 @@ FILES=                                          \
>>
>>   FILES := $(addprefix $(OUTPUT),$(FILES))
>>
>> -PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
>> +PKG_CONFIG ?= pkg-config
>> +
>> +ifdef CROSS_COMPILE
>> +  ifndef PKG_CONFIG_LIBDIR
> 
> Can we do that only if the cross-compile-pkg-config is not available?

Makes sense for me.  I will update for this.

Thanks,
Leo