Received-SPF: pass (google.com: domain of linux-kernel+bounces-206181-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <10ccfd56-eef6-4b13-ea89-d0df1c432d40@ti.com>
Date: Fri, 7 Jun 2024 19:12:14 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v12 02/13] media: imagination: Add E5010 JPEG Encoder
 driver
Content-Language: en-US
To: Sebastian Fricke <sebastian.fricke@collabora.com>
CC: <mchehab@kernel.org>, <robh@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <hverkuil-cisco@xs4all.nl>, <linux-media@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <benjamin.gaignard@collabora.com>, <laurent.pinchart@ideasonboard.com>,
        <praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>,
        <j-luthra@ti.com>, <b-brnich@ti.com>, <detheridge@ti.com>,
        <p-mantena@ti.com>, <vijayp@ti.com>, <andrzej.p@collabora.com>,
        <nicolas@ndufresne.ca>
References: <20240604104001.2235082-1-devarsht@ti.com>
 <20240604104729.2247253-1-devarsht@ti.com>
 <20240606154234.xfrgi3un667qcjqq@basti-XPS-13-9310>
From: Devarsh Thakkar <devarsht@ti.com>
In-Reply-To: <20240606154234.xfrgi3un667qcjqq@basti-XPS-13-9310>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

Hi Sebastian,

On 06/06/24 21:12, Sebastian Fricke wrote:
> Hey Devarsh,
> 
> please see below a warning that I found.
> 
> Otherwise I think the patches are ready, so if you can just send a quick
> fix for that, then I can send the pull requests.
> 
[...]

>> +
>> +static void e5010_stop_streaming(struct vb2_queue *q)
>> +{
>> +    struct e5010_context *ctx = vb2_get_drv_priv(q);
>> +    struct e5010_q_data *queue;
> 
> drivers/media/platform/imagination/e5010-jpeg-enc.c: In function
> ‘e5010_stop_streaming’:
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1331:30: warning: variable
> ‘queue’ set but not used [-Wunused-but-set-variable]
>  1331 |         struct e5010_q_data *queue;
>       |                              ^~~~~
> drivers/media/platform/imagination/e5010-jpeg-enc.c:1331:30: warning: variable
> ‘queue’ set but not used [-Wunused-but-set-variable]
> 
> Regards,
> Sebastian
> 

Thanks for sharing this.
I have fixed above (and other reported) warnings in V13 series [1]. I have
also shared the delta w.r.t previous series here [2].
Kindly let me know if it looks okay to pull in now or any other comments.

[1]: https://lore.kernel.org/all/20240607131900.3535250-1-devarsht@ti.com/
[2]: https://gist.github.com/devarsht/0bd2e90b7352ed4831252a7962fff65d

Regards
Devarsh