Received-SPF: pass (google.com: domain of linux-kernel+bounces-206182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 7 Jun 2024 14:42:16 +0100
From: Mark Brown <broonie@kernel.org>
To: Dev Jain <dev.jain@arm.com>
Cc: shuah@kernel.org, oleg@redhat.com, stsp2@yandex.ru, mingo@kernel.org,
	tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com,
	suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
	DeepakKumar.Mishra@arm.com, AneeshKumar.KizhakeVeetil@arm.com,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: Add a test mangling with uc_sigmask
Message-ID: <ZmMOOOEg06SWQ05m@finisterre.sirena.org.uk>
References: <20240607122319.768640-1-dev.jain@arm.com>
 <20240607122319.768640-3-dev.jain@arm.com>
 <ZmMHNZcYfNMW1Ft7@finisterre.sirena.org.uk>
 <5d26ac17-a50a-46c4-8fcb-68eaa6d0ce2a@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="KdpYJiuDislmVCvA"
Content-Disposition: inline
In-Reply-To: <5d26ac17-a50a-46c4-8fcb-68eaa6d0ce2a@arm.com>


--KdpYJiuDislmVCvA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 07, 2024 at 06:53:27PM +0530, Dev Jain wrote:
> On 6/7/24 18:42, Mark Brown wrote:
> > On Fri, Jun 07, 2024 at 05:53:19PM +0530, Dev Jain wrote:

> > > + * Test describing a clear distinction between signal states - delivered and
> > > + * blocked, and their relation with ucontext.

> > This would be clearer if it said more positiviely what the relationship
> > between these things is actually expected to be and how they're tested.
> > Right now it's a bit hard to tell what the test is actually verifying.

> I thought I had described that quite well in the code comments.

> Anyways, I shall incorporate some detail into the initial test
> description too.

If the overview is confusing and people have to read the code to figure
out what it means then that's an issue...

--KdpYJiuDislmVCvA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZjDjcACgkQJNaLcl1U
h9AImgf/a1wxtfKdUfwR7J0Cwo6VJYBSYn+dtTzBjhLAThbVpCClJm+TL11ij1vh
u+eV3XGaXWT81O+QtY3PVYKokM1UcGaX8+HTFPQbqSehpgxlpHMIUuoTVn8LS/ZS
dewUr3B+ed2nGSkDoNwvQMKRMEH7LfPPtbD4Svn/9rvC2yjwbzbp7prDoUZ+OdT2
yFU8gJy8bmjsodYkDi48SZrvZ3biLot1Oc5QCcM6GDra6d/v1RuS6JpIAhtgx0pF
yZ0tXur+Dce2hDmgDC9jx+7q230dxSlkHhaXZmhTizs6flsUsB2p2GquOba4y2u4
DZMSvwueWkHWDskke9iE08/547j3Bw==
=cJgK
-----END PGP SIGNATURE-----

--KdpYJiuDislmVCvA--