Received-SPF: pass (google.com: domain of linux-kernel+bounces-206195-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 7 Jun 2024 14:50:00 +0100
From: Mark Brown <broonie@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>, lars@metafoo.de,
	Michael.Hennerich@analog.com, jic23@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	nuno.sa@analog.com, dlechner@baylibre.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] spi: Add SPI mode bit for MOSI idle state
 configuration
Message-ID: <ZmMQCDCZxyGwqodL@finisterre.sirena.org.uk>
References: <cover.1717539384.git.marcelo.schmitt@analog.com>
 <e1d5d57f7a7481c84f64a764f9898122e278739b.1717539384.git.marcelo.schmitt@analog.com>
 <0a716b10-0ae0-425f-919a-ea5d8b7975b6@sirena.org.uk>
 <ZmIUwHhjAUzZnfW5@debian-BULLSEYE-live-builder-AMD64>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qI6iHgwpg0f9g5j0"
Content-Disposition: inline
In-Reply-To: <ZmIUwHhjAUzZnfW5@debian-BULLSEYE-live-builder-AMD64>


--qI6iHgwpg0f9g5j0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 06, 2024 at 04:57:52PM -0300, Marcelo Schmitt wrote:

> As far as I searched, the definitions for SPI protocol usually don't spec=
ify any
> behavior for the MOSI line when the controller is not clocking out data.
> So, I think SPI controllers that are not capable of implementing any type
> of MOSI idle configuration are anyway compliant to what is usual SPI.
> For those that can implement such feature, I thought peripherals could re=
quest
> it by setting SPI mode bits.

The issue here is the one that Richard highlighted with it not being
clear exactly what the intended behaviour is.

> But yeah, it's not that evident what this patch set is all about and why =
this is
> wanted so I made a wiki page to explain the reasoning for this set.
> https://wiki.analog.com/software/linux/docs/spi/spi_copi_idle?rev=3D17176=
99755
> Hopefully the figures with timing diagrams and transfer captures there wi=
ll=20
> provide quicker understanding of this rather than I try to explain it with
> only text.

It needs to be apparent to someone looking at the kernel what the code
is intended to do.

> If you still think we need feature detection for MOSI idle capability jus=
t let
> me know, I'll implement what be needed.

If the devices actually require this mode then we can't just randomly
ignore them when they request it.

--qI6iHgwpg0f9g5j0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZjEAgACgkQJNaLcl1U
h9AqnQf/Sw3+3u1jlifM436XxwiJrI915dgJkJtO8XgDa7yq3BbchNaCXyysgWcw
F+1obK5dbZTYucs9pQTRZH8nEBaSp9L0gig10FOl7yCn/9lU38OsTdoSaLdpIRrR
3R8I7+cvb/MSuXtEr//60B/FdwqJWIr6MrcGUthcfaLmqCKG0hAhnS6xApTMe7Vm
nIr34BLwguhZV4XLYrwDQyHykrUb3AXE4ZjeRl1KoLkBLFnIClA9xtERhChfBV6w
cVigAm+47zM9rFDMMEVpNSJrvxKVsiBHLCPQeb2s1PV6W6zFNo92DvbWJ25JHorg
1DTAfQye0KFPWH3791yHviAmyx2biA==
=oZkx
-----END PGP SIGNATURE-----

--qI6iHgwpg0f9g5j0--