Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1055411lqt; Fri, 7 Jun 2024 07:00:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXnqIuyikCGFDjU5eOcLBmuaAv5hCEj9hYoRuJRCXFDtvPcp+YzVlDCeQ8g3bFHMXWS1xHZ0u+g8CpQe/w4UmjTOitZHF5gMJyjUaq2aA== X-Google-Smtp-Source: AGHT+IEyguQYdJLvqz62bqkAJn05B+xXlokwlOMInf78pJ52w/hlPOmdd4Bwa7WDXzC44n845AsE X-Received: by 2002:a17:906:409b:b0:a63:5b17:bb69 with SMTP id a640c23a62f3a-a6cd675c3cemr182803566b.20.1717768840460; Fri, 07 Jun 2024 07:00:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717768840; cv=pass; d=google.com; s=arc-20160816; b=VXCHLU6WSHbaHpFtUC/945vbrsUA9i8eWDXiQVP40AUHf+S2P1HY82VoxYN7TxowYd ABz13M9BvbwYAnTkUb+W60fBCuP4CZ1wJluJpc+kANKz6ARSDjsbSAuLjbNdWsRBMwXx 0TE0kaLxUXh6oQL18NJUaza7qMXncslMdf/zxqVf+86S0kYh6ahfKDFlKNskOTaclsag aogJk91ydTepnoauFAFLbHt4bjp2429js6lfOwrcBn7Dc3ynucUpk4motoWW7UbZ1Qdu cLeaplixYCSJ2dL/hbzwMl6NvdH7OE/LXuWs7BMmJquUAJFHhTPeV+OHwA0vlZDWsugN Zn5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=jKigPxOyIsTI2bSkZ71iXyzsI+rxMVn90vvi1arrb7c=; fh=v1pV8Ug3TG7+qHf6rGHz1c05sqwfJu5/ZqzsGhIP9Dk=; b=YHvzUTan27r0i0lKr71w2M81d/GxdSTyYEb99rc+NjMJtrmlDlRrthySRpKyVDEYiI zLxpXfH0Ss4+i7Wxi6QR2JaKdC8djFEmC3n89wtCFZR+apauwd4B6qjE+22dlR+bZqFW WzYnPjLnkW9AxzfXaEeYnqFX25eBoIObEjXhSyFEV8q3jWlctE0lNialRRnj1RR3lYpr XNv5vbk9KPfRbTBIAofAYyoSKCaX+ySC6waCVUBwGZiivTWifNmw9rTFCWki90hdow+B VEwBPc4LusRMVDRRJ5+5k5PdeiTRLn4xGxKLKgTmNzOjZL0gylbpkGyIsL2a9TTjjb9s 5YvQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pWqigHdY; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-206210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206210-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c805d0921si185666266b.248.2024.06.07.07.00.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 07:00:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-206210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pWqigHdY; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-206210-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206210-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 09F3E1F21E78 for ; Fri, 7 Jun 2024 14:00:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B827319643F; Fri, 7 Jun 2024 14:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pWqigHdY" Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034F8FC0A for ; Fri, 7 Jun 2024 14:00:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717768827; cv=none; b=hAaU4oGG7O2cg5tKxLPAlzdrXDYs2+7e1MUOOLyfAV81+FXztIqv2H0HPRWUTQ7kz+V4FOA1CzDam558AblAM1a/RgfYIrZfww8nQyjP13Ky5Ixhm8PXFWQlIhSu0yjBlpLLIOLKKhbdMP5QHdN4VcZ8coB7ZpBScdlw9kGg+oM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717768827; c=relaxed/simple; bh=OOA1+hRiYDrMPbwUCoHpN5UM+d1N1dzdE5Ks/+ep6J0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=IfZVD8cudzfGkx7k1BRzJzsgslBTdEuriU9xegrHjuikEfCZjiDmGw4TujsLqaqK3leLND2Y+ClQknAeKAarIB278dUZEyNBAlvmQgK88DPUUhjMDpgf7abk0coZjwKZpteQv3qclTD1PLcAKhEgAHIggubNpn/vcTwI7jd88ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pWqigHdY; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-356c4e926a3so2039291f8f.1 for ; Fri, 07 Jun 2024 07:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717768824; x=1718373624; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=jKigPxOyIsTI2bSkZ71iXyzsI+rxMVn90vvi1arrb7c=; b=pWqigHdY7H5UzJb/4d65Yp+BMSKX/xXgd1rRa1S1p+YwyfnSeY93A1qkWMz6rYWCuR edM8qysAVJr5/J+hP43jx2spRHu3dDYmFyX5Y1b9y4hYi48MADKZAI7a2sBqfwynfWz7 LDKRlcAS5DQb7Y/al7xE/4Oh+f8Ub7b8ZMGbBrAoIZUod394XwL98xys6zgk1VWNkekr YbVJ66BfBFv9a/3VG/C+2DLV49U8nO0OqdKisx2d5lIeWT8vn8jxSfc0p4kDesuvFTpC WuqfFr4iGhiQS6avYKl3e/qL7J+7qpQVd2U/Ssg9zm0ySFlTJ7QRPi/9FdygkbYo5BKz R+1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717768824; x=1718373624; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jKigPxOyIsTI2bSkZ71iXyzsI+rxMVn90vvi1arrb7c=; b=dIq4OuT/nD026L8DHSS7Z4t18NPucnMZYH0jSJKDPWgRwWeAYmG+T1b86khA49Eksf 8Dn0h669M7r1zOV6WjWBrK/xrmM0rBO9YNUR1CwvSE/n65UMcyJCzM8MI+iPSOHnjn9F 0cliIOmQDtFQBUxxRbQ3ceGURXqWxecmxYaKtpEAym3GGJUyZ5vvQ7To+OpNQCb4kqIu xFZFFF5ymgyMqRSF/nTd3MsyjsSe9u+42G5W+Cd3nTitpTNG7YddDlr9cpVBKh/TrbFz SQuRTVSfY+YQOgwvLGZ9O8M3B9cFkjXFtDbbLkn1pNgus/YYN74+5qIhQKFKSjr0Aq1+ ajKA== X-Forwarded-Encrypted: i=1; AJvYcCXt6WQ2YfbrRvJdp5tf8UWNI41O+jS5yDPZPfyGOhqyFZVLlHfjzCQ/k0bgEoJaI0ApEj0gBzCAVQIC553u4p7pw17xidG/0BV2sFXL X-Gm-Message-State: AOJu0YwFafOPYezIou+hlB1a1lcWF7BeZU0qHApQ9Apx1GrY/mT3ozIT K+jRhlEINNQx2eB1SyJ4FG/aSMvf1dqca7cPPIht5OStNmTcRRQpVFmr4haLJeg= X-Received: by 2002:a5d:4acb:0:b0:354:f142:65b0 with SMTP id ffacd0b85a97d-35efed534c9mr1907495f8f.37.1717768824112; Fri, 07 Jun 2024 07:00:24 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:7e4b:b0d3:6a34:6404? ([2a01:e0a:982:cbb0:7e4b:b0d3:6a34:6404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5fc11fcsm4056145f8f.99.2024.06.07.07.00.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 07:00:23 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 16:00:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/4] usb: typec-mux: nb7vpq904m: unregister typec switch on probe error and remove To: Dmitry Baryshkov Cc: Heikki Krogerus , Greg Kroah-Hartman , Bjorn Andersson , Luca Weiss , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240606-topic-sm8x50-upstream-retimer-broadcast-mode-v2-0-c6f6eae479c3@linaro.org> <20240606-topic-sm8x50-upstream-retimer-broadcast-mode-v2-2-c6f6eae479c3@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/06/2024 07:50, Dmitry Baryshkov wrote: > On Thu, Jun 06, 2024 at 03:11:14PM +0200, Neil Armstrong wrote: >> Add the missing call to typec_switch_put() when probe fails and >> the nb7vpq904m_remove() call is called. >> >> Fixes: 348359e7c232 ("usb: typec: nb7vpq904m: Add an error handling path in nb7vpq904m_probe()") >> Signed-off-by: Neil Armstrong >> --- >> drivers/usb/typec/mux/nb7vpq904m.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) > > I'd say: > > Fixes: 88d8f3ac9c67 ("usb: typec: add support for the nb7vpq904m Type-C Linear Redriver") I should add both yes, it won't apply with only 88d8f3ac9c67 > > Nevertheless: > > Reviewed-by: Dmitry Baryshkov > > >