Received-SPF: pass (google.com: domain of linux-kernel+bounces-206256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 7 Jun 2024 10:23:35 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>, sidhartha.kumar@oracle.com,
        Matthew Wilcox <willy@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>, linux-fsdevel@vger.kernel.org,
        bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] mm/mmap: Split do_vmi_align_munmap() into a
 gather and complete operation
Message-ID: <cpufg5nonojewqgjjjzyyxhkrxxenwe2vvtakvcbe5oleym35j@yzwccr6qim7q>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Suren Baghdasaryan <surenb@google.com>, Andrii Nakryiko <andrii.nakryiko@gmail.com>, 
	Vlastimil Babka <vbabka@suse.cz>, sidhartha.kumar@oracle.com, Matthew Wilcox <willy@infradead.org>, 
	Lorenzo Stoakes <lstoakes@gmail.com>, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240531163217.1584450-1-Liam.Howlett@oracle.com>
 <20240531163217.1584450-3-Liam.Howlett@oracle.com>
 <CAJuCfpFDW-=35GyRikn3-yZPPrKx_aFbaJj-yFqGut4dJfCsdw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAJuCfpFDW-=35GyRikn3-yZPPrKx_aFbaJj-yFqGut4dJfCsdw@mail.gmail.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NndrcERiVEgxdEtHRUdBalEyZmFkdmIzVG5WSWVSQ0RXcXV3Y0RwU1RUa1Jn?=
 =?utf-8?B?dkpsV1UyalBQSGpyM254dUxIaXZRT0lMcWpjM2tGNy9ScmFhWE8yMkpmZ2tx?=
 =?utf-8?B?ZmF6Q0VzV0JEekRIYWQvSzRLeWxsVjBUVlo4VjRIT21uaHZiZThaM2k4WndO?=
 =?utf-8?B?Rk5MRzJyTkxMV1FPcFhxWGZLbG0wT2tld1RsNFM0VDBTUm1hRHlIeUVicndn?=
 =?utf-8?B?MTZwYUZiVG9laVBJVTVYbHZBTUJEeWNLcUNHN0dhZDl5ZUlVU3lJczFpUnNv?=
 =?utf-8?B?Zy80VVJUUzVVNHM0VkdLRkVSL2xrZ2JMd3I2RU9HWnM0amMwNmxVbXFEb0xC?=
 =?utf-8?B?WUxsUDYvc2RaeHRqMkUrSjlWaVc3UzVPd1N6M1F1TFYySFJiN0F0MlFRR0NQ?=
 =?utf-8?B?emxxOVNmTTVBL1FLMUZBL2NJRHpSMXFNbkxhU3VzOWowemlPVFlBMCtwdGQw?=
 =?utf-8?B?eHMwaldIb2I2SzBUUFNvMnF0TWVJV3kvNHJuamR2WWFEMVpEMEdOaGZkcXZz?=
 =?utf-8?B?S1JHOFlzZE1wU2dLK0M5UkFETlNBSGxJMjJVaEY0cHRadXIvMFdSNHAwV3p3?=
 =?utf-8?B?NllKcmFrVmgvNUh0M2hZNDN3anZaL09JdkpSK2dvVGpheHFPUC8zVVQrdFpC?=
 =?utf-8?B?ZmdkVG5kUncyMDJ5M0FURDVsVHRwZW5JU3kzVTRxS0g5UzV2NUdMMXZmWGcw?=
 =?utf-8?B?QUY3UXN3ak50V1BjazNocXRHQlV5dmJvUW9lRzVzOUQwNkhPUXduM0J5cFI1?=
 =?utf-8?B?TzBJZndDQ0VsaEZuM0VaZ2dCQ21SSzZFd3dZdUhsOGoxSU84ZkZodTB6aFRt?=
 =?utf-8?B?ODY5aVNLTHBpWS9wckdsblNVV3RiZmhieW9pcDYxcExjYmRDS0pKNFVkOUVT?=
 =?utf-8?B?dC9aMU5xUEZ3T2RDVHVZU2g4YkgveGFvWmJVMngwK3FZWmF5MXdUdUJBVDJB?=
 =?utf-8?B?bHVacjZiMURmaFZrT1ZCUG9rTXhCSGZ6VTRaUkg5OEcrY0hvd0dVZ0x2S29S?=
 =?utf-8?B?RHhudUxYSFo2Z3dzNUJQaWVxekNXYS9LR0E3aW1xU3hZZ2RFQ0c4eHZXS21I?=
 =?utf-8?B?RGJiNXMwK21qNlFycGFBczMySm1pelYwbjUrblZwSGlKc3lGQnZLaU8vNG9q?=
 =?utf-8?B?MnRxc2dFM0d4eXNQRU40b2lyYTdmUW1kbUR5MXZkQjhKN2UyU0gzNXgvSTll?=
 =?utf-8?B?T20xaWxmNGlGRk96cjJBNWFUSmMyeVErTExQYUFFd25pNVpOdlZBeG9XNGFn?=
 =?utf-8?B?NWVmTzd4Yk5Qbmt1R3Z3STczdnZHdXg5Z1VSNGFQc2doK2NPeWZzQkNoMlA0?=
 =?utf-8?B?ZEVwUkRKRjlDNERXYWRQQmVFK01ibHZiNitNdXhrQnFpbVhmb254ZG9KMitX?=
 =?utf-8?B?bUhDd0xMS0ZVbEhpNDJSZldNR01XL1ZwcmVlelozdExDTUhaSlYzcDFIY2Zj?=
 =?utf-8?B?OWhJY1VlVk1Xem4vVHhhYW94NFRhU0NERjVXR1o0Z24zZ05adTRGa1c2WWNY?=
 =?utf-8?B?dGZNakMyVEdRL3FSVEZ1aFRBa1kxQzZYWmc3ZVhhSUdEcFcySVBGQlUyN3lm?=
 =?utf-8?B?b0lrMUNycmo0VDlsVTBwdnRQRi9JRllpOWs0VDl2ZWNXWWYydFVOQ0ZZMmRT?=
 =?utf-8?B?ck92U1RoZEk1RG1yR1krWWVLNmxkOGtWZFRtTkxEbC9Mckt2ODhBbFoxY1Y4?=
 =?utf-8?B?emdtVnNRN2ZNSmRwayttT2hvMmdBOGt2UG5iRlRRM0N0SmYyL2JHTkNGeXNu?=
 =?utf-8?B?d0ptQlE4ZTBlMnM3aTlEa2ljTnh0dEY4MW4yelNpWkl2bWJEUEgxQkFCNzhV?=
 =?utf-8?B?U1ErVm1uNjBOUWw4UFIwS1I5SGp4Y1NJZTFXN21EbmhGZkN4dDFPTFIzNlk4?=
 =?utf-8?B?ZnhoOHpzWjIrNmhDTjNSL21jWXVqOExTenZjMTN3MmtKUDl6b3pGQ0NmSFo2?=
 =?utf-8?B?YjFralJHMlo5eUNFK3d2czRyR244UW4wSjZOandzeCtDQ1RKd1JzMTFReFVa?=
 =?utf-8?B?cVNSOHdwQjdqZjN3d3NycFlEMVlaUWJ0T09wOVFtdldvN0Z6dG10TiswQWc1?=
 =?utf-8?B?TlM1OE1OdG42MEM0RytOQ1pOd0toL2lDMmdaSGlua1k0RGQzcWRGM0p5Q2ow?=
 =?utf-8?Q?0v0+udh0jVtLnEVIBId9jv4P3?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	iYagl8X/3OwIoUyAX306wIahSI7v3QahJEiBCLXaNelhKulfJvQB2Ar3jax9ogOZ92i+FxuxI6r55NdXk7hnLwCtViAXwjsBkZOu+edYD8Fl4h5qfm7T+iK/stTwFVNZej+6spA5LeD+ZeTnBq2zoAC4BQmAgXulAQ+MPngGysnAsAtdkuYtmraA2XKH8kvJUNW7D46wGwVPZb8e0DrIh06F3luPbFj5rIF1zUWYv1vgvdA2Pvyjk7UHv8MpG282KT6TNPUdC8Qv5zlu0wlSYea81QTVbooxusFUaHjQBuWHrjpbsDG1XdaL4wVku9AuFa8dYhsnQ7HSd42CQqO0LNpaKxPUBaVMX6nzopw9c3t9F23SutvRG/o+jVKJ2nyEx0Jr4rZ6Ryngh0Akj/yvJkMdblNSnqyKAowf1NbazAQ1PQC7/NYX3pM2cmTBPNDoy3AyHxeLbSigAZDbu3fMOP7MssiCdm2NlAwMgjQXXypcHUpKfgOPyOOXxLYfXfvd2ZzOZK+tf+KkYSLfC9iU9Au6fEWUGDjrdhKdMnHKxCwQLS3gkPCuAqdTa4isEPifO41ls4uZDpPCozmEZrebhDehMNTdhfASO0RUmKYofek=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f67a58d-ae68-4e93-3736-08dc86fd6bfb
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 14:23:37.7244
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /CJsVvrQ/RkKORSrYKMePvycFBNPMFSYucmRNtgFfqoTKekvCTck3zgiqM9xcUMf8PtHdI/E8P6+YrqAAU2THA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6322
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-07_08,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406070106
X-Proofpoint-GUID: miiO_sadDP3CTxLkcfwmu4XdmdBgdSzF
X-Proofpoint-ORIG-GUID: miiO_sadDP3CTxLkcfwmu4XdmdBgdSzF

* Suren Baghdasaryan <surenb@google.com> [240606 20:14]:
> On Fri, May 31, 2024 at 9:33=E2=80=AFAM Liam R. Howlett <Liam.Howlett@ora=
cle.com> wrote:
> >
> > Split the munmap function into a gathering of vmas and a cleanup of the
> > gathered vmas.  This is necessary for the later patches in the series.
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>=20
> The refactoring looks correct but it's quite painful to verify all the
> pieces. Not sure if it could have been refactored in more gradual
> steps...

Okay, I'll see if I can make this into smaller patches that still work.

>=20
> Reviewed-by: Suren Baghdasaryan <surenb@google.com>
>=20
> > ---
> >  mm/mmap.c | 143 ++++++++++++++++++++++++++++++++++++++----------------
> >  1 file changed, 101 insertions(+), 42 deletions(-)
> >
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index 31d464e6a656..fad40d604c64 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -2340,6 +2340,7 @@ static inline void remove_mt(struct mm_struct *mm=
, struct ma_state *mas)
> >
> >                 if (vma->vm_flags & VM_ACCOUNT)
> >                         nr_accounted +=3D nrpages;
> > +
>=20
> nit: here and below a couple of unnecessary empty lines.

Thanks.  I'll remove them in the next revision.