Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1090556lqt; Fri, 7 Jun 2024 07:48:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+VrSlbifAJzuxA4Q5rkdRsjZMfT3KDE0JWxsdyil8K+nnCFLzPs4WNNh+i9aDuXxjZqx1MN4QAjPdlLdR68WJNuDHLV7j+FwNg8hoAQ== X-Google-Smtp-Source: AGHT+IE4T7oYQTAbBBWcOk48kMi/Ch4Ab2zP1TNOp2QEsRRIX1NdPnTWnJcOSJ0KT42nbgbOsJMp X-Received: by 2002:a05:6a00:1ac9:b0:6ed:5f64:2ff4 with SMTP id d2e1a72fcca58-7040c65b58cmr2933902b3a.14.1717771705416; Fri, 07 Jun 2024 07:48:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717771705; cv=pass; d=google.com; s=arc-20160816; b=Hh0vjviT3EfNnmb9wGz9MDaa637ZIjMiJ1draOPWhc0KYCF3gR1fWKfAaXiOhNfFPW T8VeaNtRf5ORTOSAJxJyGftqY1jJsF6ozb2y3V8B1bWimnja6vRozOUcIdF3wCO8FuZ6 H58Xsg5ezwDt6aucG1FSdke2cSoPYRi7caYwj0sSBPlJnIHtRI6YHGFSKUxrKTtlhVE9 04Esmd92or9ZakO62+/GAS5CSKvT3o9vV7x2+zofrmJaVSTDRQVpJerwVyjxqzmGC2wY 1L8XAWadlG2Hx9lawBHQ72vEYU1F3IxGmENxz+SWb50LuUBtIVielcWE3KEHnSmRhw7k wqdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=dkim-signature:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=XAEyN4AkCHtTFKYLX9Yy5JtVjbYzN1yPHYJt3534IMA=; fh=Vfzw9MtkDq+k22niiwX87PDkR5MLbubNjpcboFf0V4I=; b=AeDSzvcm+IfcU7XxXNTbUQ+dQ+DQXYXkfkh0Wyfj3BY5dmzaBlZ4+loM01jtD27IRS 1ROOwfPTQknr8qToeV2GW+/kDcLQY7bmV+aqzgy+xnYRrAPuprWUcGinnzl5CCqy8K9L Zo/qVpO9Q9th8/ZbIVZY0iu2OGVue5BeLvaksi0ifHpazQ03m/ZMYmVcgKk45DYtlaz1 oL290PmLO8P1PJAltU+lR1s/H7ZKnxvBfyoBD12+5349yokW+C8k8qNP9CyFcFI6dHQG bW9PYfpEQegAro0ahGjyiqYZGnsgimRrgyizCVJOA1tCYQsAdcs8lLoBqBHH7hjKk/iB 6JAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b="a/gaYwcM"; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-206261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206261-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de2ae0ee71si3251679a12.868.2024.06.07.07.48.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 07:48:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-206261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@peacevolution.org header.s=dkim header.b="a/gaYwcM"; arc=pass (i=1 spf=pass spfdomain=peacevolution.org dkim=pass dkdomain=peacevolution.org dmarc=pass fromdomain=peacevolution.org); spf=pass (google.com: domain of linux-kernel+bounces-206261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206261-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=peacevolution.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0A41CB219DD for ; Fri, 7 Jun 2024 14:26:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FDCD196D86; Fri, 7 Jun 2024 14:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b="a/gaYwcM" Received: from a.peacevolution.org (a.peacevolution.org [206.189.193.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908491667DE; Fri, 7 Jun 2024 14:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=206.189.193.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717770396; cv=none; b=Ggnn6jFibAqLoPXPz8iMMCEYXvyNLzE9kHNN1uQ9yPu5FRlT0Xvrevzf68Uy3N/TiM5EphJJ/NQNnO63r/Tt+pGnPckZuNhkW1wHdSzY7zrH7aFPE/mj5TxiEKXOggmCi5jCDo9lOXBcSkm69lxQBvUpVgp477LJGoMKARKrkDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717770396; c=relaxed/simple; bh=HhNF4gEO9wpQcZi+i8Hge7O/z4YF0BVJjH5/9mep+YA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qXOYZu1rLO2o5yL509pCafY7RjJ5JC/P1hSd0gyRm4lxJdrKymE8H01XL1uL1e472uRENUrtLGoRfwZj7DC4bB0nnKVE4v084JiyWQFKGYyrgdd5P7e/mK2/+ZIcMkviPbVonfgy9HJ2oAfXEdf0XhkEHJeCZl1bYmtINSWl85I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org; spf=pass smtp.mailfrom=peacevolution.org; dkim=pass (1024-bit key) header.d=peacevolution.org header.i=@peacevolution.org header.b=a/gaYwcM; arc=none smtp.client-ip=206.189.193.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peacevolution.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peacevolution.org Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by a.peacevolution.org (Postfix) with ESMTPA id D016947E7E; Fri, 7 Jun 2024 14:19:18 +0000 (UTC) Date: Fri, 7 Jun 2024 10:19:16 -0400 From: Aren To: Jonathan Cameron Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Andy Shevchenko , Ondrej Jirman , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, phone-devel@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Willow Barraco Subject: Re: [PATCH v2 2/6] iio: light: stk3310: Implement vdd supply and power it off during suspend Message-ID: References: <20240423223309.1468198-2-aren@peacevolution.org> <20240423223309.1468198-4-aren@peacevolution.org> <20240428175337.61850e2a@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240428175337.61850e2a@jic23-huawei> X-Spamd-Bar: / Authentication-Results: auth=pass smtp.auth=aren@peacevolution.org smtp.mailfrom=aren@peacevolution.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peacevolution.org; s=dkim; t=1717769960; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to:references; bh=XAEyN4AkCHtTFKYLX9Yy5JtVjbYzN1yPHYJt3534IMA=; b=a/gaYwcMwCH5yEh0swQaVtYVZwoEyr5KOx8OT9hrOGq/WzYIGxag68OcknO+ioNpWPzqrp +X0ZhZ+6Ayy4OAseVLcHTZAifciqwFAPQE/uGytxwiMUbCR9bxIRvauaNsb1jnaUQ987R0 LyF1ukyJzdq4QZ7RUzLNGqVnAlzBfPY= On Sun, Apr 28, 2024 at 05:53:37PM GMT, Jonathan Cameron wrote: > On Tue, 23 Apr 2024 18:33:05 -0400 > Aren Moynihan wrote: > > > From: Ondrej Jirman > > > > VDD power input can be used to completely power off the chip during > > system suspend. Do so if available. > > > > Signed-off-by: Ondrej Jirman > > Signed-off-by: Aren Moynihan > > Suggestions inline. Key thing is take the whole thing devm_ managed > and your life gets much easier. It is mixing the two approaches that > causes problems and often the best plan is to do everything in probe/remove > with devm_ calls to do the cleanup for you. Thank you for writing this up. I've been a bit distracted lately, but I'm hoping to find some time to implement this in a new revision soon. - Aren