Received-SPF: pass (google.com: domain of linux-kernel+bounces-206367-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Witold Sadowski <wsadowski@marvell.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
        "oe-kbuild@lists.linux.dev"
	<oe-kbuild@lists.linux.dev>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org"
	<linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>
CC: "lkp@intel.com" <lkp@intel.com>,
        "oe-kbuild-all@lists.linux.dev"
	<oe-kbuild-all@lists.linux.dev>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh@kernel.org" <robh@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org"
	<conor+dt@kernel.org>,
        "pthombar@cadence.com" <pthombar@cadence.com>
Subject: RE: [EXTERNAL] Re: [PATCH v7 2/4] spi: cadence: Add Marvell xSPI IP
 overlay changes
Thread-Topic: [EXTERNAL] Re: [PATCH v7 2/4] spi: cadence: Add Marvell xSPI IP
 overlay changes
Thread-Index: AQHashOxQrxXgjczM0KWa5pVXoAx/LG3XAsAgAUaNdA=
Date: Fri, 7 Jun 2024 15:14:45 +0000
Message-ID: 
 <CO6PR18MB40986EC61B5D226FF562AA02B0FB2@CO6PR18MB4098.namprd18.prod.outlook.com>
References: <20240529220026.1644986-3-wsadowski@marvell.com>
 <8428babf-5504-4710-9138-a2b6e5fc2a84@moroto.mountain>
In-Reply-To: <8428babf-5504-4710-9138-a2b6e5fc2a84@moroto.mountain>
Accept-Language: en-US, pl-PL
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?3lWuGBF+6g2+lwthmSKz7dem/a4mlrh+5z0ePaK74LWl4aKDnkbHEPqHsUWI?=
 =?us-ascii?Q?c0TfdBx9qu+8fgYJeb9EDI9ljRiGXZCT+2+G2gXKXp/YmPE9+RVN5nbAx26f?=
 =?us-ascii?Q?yvIMfskQXbWX/cxOH06xJJWmz9wXTJVcvZh0W7ZEfF5U2KrzdorSjoQon6nc?=
 =?us-ascii?Q?O905/3zXJbnvPFgMdCcQzhtr3aXwEiMOgotO7VQD9Ruj3RKv777IxetfCYli?=
 =?us-ascii?Q?nqnbU9OTv3x5YOCiyAUXiRDWlBUN7MpwN3RWw2ekAO8tv2L4y0vqdj/zWp68?=
 =?us-ascii?Q?AlWYJkeIDzYYX4Z0mPewpRUBPgcZQFiikdXlEEN7fEeSF5xHjoDjbdYHX1C8?=
 =?us-ascii?Q?eOQ2K8WGjwaiTIC6hs64f0XXieVNp6Y6rW/7MBjzC/Y/p9cN9hS0PUxys4tG?=
 =?us-ascii?Q?eZ0OuVx9u9gbX0kAy+qsT3s6b4miFB0dFG8C2NW1OBgiFSUIQC5q4qAtLrjo?=
 =?us-ascii?Q?LxN+kpZ6mJUORtsZu8HI8acF947W78VjS9YW/V9a/+9yzBl4FQDYAtUCb882?=
 =?us-ascii?Q?GLPBXetUQC6fd7xQmbPLWnoi1iExqHIp8VyHr9roFxZFjqrL6PCtgZhfyDkg?=
 =?us-ascii?Q?jRBzTGVI5CLuopWlhGQXMIlYY+Odl3hvzENLIC738v/1okQqaRURpZaMs68e?=
 =?us-ascii?Q?D2H6ObYf+31x97QojHq5XL/Mqb7NP9Dlp0qfUyBIX4NRSi3IHn+ReYH/OOrX?=
 =?us-ascii?Q?xQJTTWtjZmJU7+ykz1q5geMb2mXdp5lhEA0+59xiiDwhAli3rV10j69wPnE5?=
 =?us-ascii?Q?fT0gdo4w4x7xLXwbJn0fa/BK6Aom7gB/Cy34yhKPz1QjK+aiDeBW8KunoVgA?=
 =?us-ascii?Q?6s1ug3WRGfCCSuCaw7uP9P/51zFIn/xKkd/G9cywaDz4eID11rmY++rsYXX6?=
 =?us-ascii?Q?VAjdnVu8T1HzuiONoauHE8xaTLL3E1mPK3oj4MYoaDRtciiuCtkAb+iCg5La?=
 =?us-ascii?Q?cpOdfccvU365G+6onnqddSOOOIiXpm5AMx5XFl6U9WjosKF0N1OZOZZNunEx?=
 =?us-ascii?Q?QJCtDJMgYD6gvOChHNlV20u9fgvM0Jkfm272DagO560dvjowyn/Y2zpYAKtY?=
 =?us-ascii?Q?1jqBxRXEvDLxvOQ6qkYG8F+SQbsquBYr7kuEQBhe6ZFUAjgBtgQjmXAaNC5g?=
 =?us-ascii?Q?r8ppUJB+B9YBC5N3k4bkiRx0R++lVxJQBJegrT8kf/1Ad8zi5YKzYHv895SZ?=
 =?us-ascii?Q?0YvP0EmsVRRROTotSdbGPtNoXFEGN38MxMcwK5GBzz89ATLHGQjPyEBZzk6N?=
 =?us-ascii?Q?yRP7OSdK3pJq35NGQhVDDP1TH8ZQ8PM0+MYz8hN4Gcd0trgo6CS+PEn0FiI0?=
 =?us-ascii?Q?gZkYhNe2fIIbiR6m+oyZ+U7u5i8/Q5tHOWmvffUNNtafMmBV7XCvgN4ab+ot?=
 =?us-ascii?Q?Og9TQ78lw+36rGPPdy3e4QxwKM1NMNHnAX+HBSsOzPk+4WMliZ0akVH9zsFe?=
 =?us-ascii?Q?/m/hP+lLygeapCSbRIzF8pw+nRGcx6AYJdJLYzK4tMksTWKa6ONcTKwtwlfS?=
 =?us-ascii?Q?00OJ/LyvaywiRzPzVTXsvoV+BSO5RBZjqLPGJNT7GuAlyT6XLf2qRSyVI0GJ?=
 =?us-ascii?Q?VPmtlSqCBjG7RjE8E/q5CXMUC87ijovnpeY2XLa1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4098.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca0daa21-d4d8-4a52-7ad2-08dc870490bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2024 15:14:45.7325
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tW//6oyS//rLKbID/T+1eWXnEGQtFO+g1cn7xh+0PYNJOGf33l76LNFlArH3fJXVuFLr9E1nSb004nRivrHzWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4334
X-Proofpoint-ORIG-GUID: XHdpwllpKqkyczg96kcdF13oJIOaIsTC
X-Proofpoint-GUID: XHdpwllpKqkyczg96kcdF13oJIOaIsTC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-07_08,2024-06-06_02,2024-05-17_01

> 5828a861b01b62 Witold Sadowski 2024-05-29  302  static bool
> cdns_xspi_reset_dll(struct cdns_xspi_dev *cdns_xspi)
> 5828a861b01b62 Witold Sadowski 2024-05-29  303  {
> 5828a861b01b62 Witold Sadowski 2024-05-29  304  	u32 dll_cntrl =3D
> readl(cdns_xspi->iobase +
> 5828a861b01b62 Witold Sadowski 2024-05-29  305
> CDNS_XSPI_RF_MINICTRL_REGS_DLL_PHY_CTRL);
> 5828a861b01b62 Witold Sadowski 2024-05-29  306  	u32 dll_lock;
> 5828a861b01b62 Witold Sadowski 2024-05-29  307
> 5828a861b01b62 Witold Sadowski 2024-05-29  308  	/* Reset DLL */
> 5828a861b01b62 Witold Sadowski 2024-05-29  309  	dll_cntrl |=3D
> CDNS_XSPI_DLL_RST_N;
> 5828a861b01b62 Witold Sadowski 2024-05-29  310  	writel(dll_cntrl,
> cdns_xspi->iobase +
> 5828a861b01b62 Witold Sadowski 2024-05-29  311
> CDNS_XSPI_RF_MINICTRL_REGS_DLL_PHY_CTRL);
> 5828a861b01b62 Witold Sadowski 2024-05-29  312
> 5828a861b01b62 Witold Sadowski 2024-05-29  313  	/* Wait for DLL lock
> */
> 5828a861b01b62 Witold Sadowski 2024-05-29 @314  	return
> readl_relaxed_poll_timeout(cdns_xspi->iobase +
> 5828a861b01b62 Witold Sadowski 2024-05-29  315
> 	CDNS_XSPI_INTR_STATUS_REG,
> 5828a861b01b62 Witold Sadowski 2024-05-29  316  		dll_lock,
> ((dll_lock & CDNS_XSPI_DLL_LOCK) =3D=3D 1), 10, 10000);
>=20
> Functions which return true/false should have names which say what the
> return means.  Like access_ok() or is_something().  Returning true for
> failure and false for success is a backwards anti-pattern.  This error
> return value gets propagated back until it is eventually ignored so it
> doesn't affect runtime.

Ok, I will rework dll reset and lock into separate functions.

>=20
> 5828a861b01b62 Witold Sadowski 2024-05-29  317  }
>=20
> --
> 0-DAY CI Kernel Test Service
> https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__github.com_intel_l=
kp-
> 2Dtests_wiki&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DGKgcn-g6ZX-
> JmCL3S2qKgVQhvhv7hu2n8En-
> dZbLTa8&m=3D2Tyu1l8OLops5Wk0jhMClv2KWeHzTLpsaAhANwtcG2B1koElBL9h8zS_z_-
> T8On7&s=3D01Illw-eCdS6pP0W-BnXjtntuLsuJSnvQTwS_t_TVcc&e=3D

Regards
Witek