Received-SPF: pass (google.com: domain of linux-kernel+bounces-206358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Witold Sadowski <wsadowski@marvell.com>
To: Rob Herring <robh@kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "pthombar@cadence.com"
	<pthombar@cadence.com>
Subject: RE: [EXTERNAL] Re: [PATCH v7 1/4] spi: dt-bindings: cadence: Add
 Marvell overlay bindings documentation for Cadence XSPI
Thread-Topic: [EXTERNAL] Re: [PATCH v7 1/4] spi: dt-bindings: cadence: Add
 Marvell overlay bindings documentation for Cadence XSPI
Thread-Index: AQHashOgPo1FoeQZpkWJe/LJw4DVobGwlLeAgAvhSkA=
Date: Fri, 7 Jun 2024 15:12:53 +0000
Message-ID: 
 <CO6PR18MB409866472BE353D6DAB3E361B0FB2@CO6PR18MB4098.namprd18.prod.outlook.com>
References: <20240529220026.1644986-1-wsadowski@marvell.com>
 <20240529220026.1644986-2-wsadowski@marvell.com>
 <20240531014703.GA3691352-robh@kernel.org>
In-Reply-To: <20240531014703.GA3691352-robh@kernel.org>
Accept-Language: en-US, pl-PL
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?6t6T6PRy6r4ARW6An5JkEZx79qHCC9bKLkhi9/uIqPgwz9CtnL7AqpKVtDru?=
 =?us-ascii?Q?996QcA2YIm8J89DnQIJRybiC0Cj37qkXChfURQTPq1iwKyNLZCB1iHIXV4wE?=
 =?us-ascii?Q?/N969uAxS49abDyikhN2KniXluOnXcQ3AJehWBU/RAENz2YwtPyC8hdhoywW?=
 =?us-ascii?Q?+moRDuIPNsfl6d6jf02xI3t53yCgPDUuLoBasrYKlIsIzMcGbeKdyLFBwy7b?=
 =?us-ascii?Q?RCzc2JpseW6nZxr023R7aW7aOV0+EEkdSIWPDQFzqPaFs+S4ZI4WdtoBJHtB?=
 =?us-ascii?Q?vH30pue9h03oHhkazPXiwrE9NoZLMKGOoGZeXyp1JnPjvRNhmuDkJRLvs14e?=
 =?us-ascii?Q?7BTzFeeb5LbyV8sAFf9DJJ17vdzof8oYB5zmLKpzZyzyuIYu6//ElT+IEQPS?=
 =?us-ascii?Q?/lcYFi36gqDTKQL4oOaVlBFWdfOOYJChceK5QvokjDy4wKKo9TJd14UIHH5o?=
 =?us-ascii?Q?eJX+JE0Ybn4F9/QxSfyXeYfusFfXTyBfQeDa68XFvsY5x9O2MfpOGA/uwlS4?=
 =?us-ascii?Q?s9yhr5iBOQ0uyW0GLQtZ9UOUXAanzOMpGfzXbHQExnuEZGsLlQb2WRFlH8rz?=
 =?us-ascii?Q?vDZ2nsfYb3NipzM/ICbuhi0qWHCRwtIlwCcWvgfmouJg/s+81ZKtN3qyjsVn?=
 =?us-ascii?Q?n3VLZi3UDWECXOA4RBqC6xffM9AwBm5ZtrXhDqQjnGwNa5LobU7fO2SkkLPG?=
 =?us-ascii?Q?zONePTdNGFpXt1A+ATpN//ORw49WMR1sfZOYMkL1Ouz/+PZQEuwj/a6ck36n?=
 =?us-ascii?Q?AfP0SVdaivNreVY9yidAuAMMWCi9koctxNolzCI26WDT3RfekoLlWXdg3LdS?=
 =?us-ascii?Q?oMPZqRWqwdWZRlNxIy/H0/VaUsidbOrE32tOybK/5roiJAFY5YApWY01LZvQ?=
 =?us-ascii?Q?P2PxluRpZoiwx62qKOvH5ivM96yZG89MCPUMV3hlfLxRZuQljJpLkEJThWq2?=
 =?us-ascii?Q?xu9ckLSkpF9+4O9j3kMe2T6O/k8p0Q0wBUII3rSf39bVBQPQpAFZaVtF9fP3?=
 =?us-ascii?Q?lPe5yMPFIpdeI6KZUIa7AgNIBOXBOSxom6aeShas69z2XuaDSaKRm+4roRef?=
 =?us-ascii?Q?SWF3BdZxJpjfWKMfoZlNTF6SqppZdH0jCQFJa7dutJDqEkUi4k+2S+pbB3z0?=
 =?us-ascii?Q?DMao/j2eA6KGy8AZnbhEJ5j3pGKGtvVzsu4lc4YsFPdBCZK5ab8HAbVaeHvK?=
 =?us-ascii?Q?MwcWCNVQfYMkn5ksag3hwKIb9nIfy1LQJDxpECg/nQT5ixWMZdtl5ysRVi6w?=
 =?us-ascii?Q?Ha0FXKgs3fIekClPjbM2QVFqHZExEa8AObXjFR/hTGx6HyOozpsTfAtyI/lQ?=
 =?us-ascii?Q?+VVaggN5ubWfDlQ8rE+YzEw71rsv0Zj3EWtdkB+joz+cMHnjlbmkVvyG0337?=
 =?us-ascii?Q?TKLso5XH5mD7P01RijBZ7DHCA3KLbRu9aHraCbZZIeQ/7Ts/3R8pCi2ZGHf+?=
 =?us-ascii?Q?2ncrd5MlQQE1noUUHWWptsDP9M92gh0U+Ne+z9U3wxgNFfVGogaLHwG8BR9m?=
 =?us-ascii?Q?Mh0cPLB9mv1Ulv5UY3b4eO4fHKnTgXRLzhjlhKbbgoTz/gyCji/UkMMoPcVz?=
 =?us-ascii?Q?KUFa6IWU9J/uXPSumAsuYoYjI+xEfBZDi+mhYmgV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4098.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c266470e-5397-4e3d-2602-08dc87044dec
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2024 15:12:53.6563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /z9+NN91KRneHAR4AlHL6OBeKiRQQbqEsOkCoxzKeXCBs25rccRJo3UtTZssZCUOQmpj5V4BvUlZgZQqovJYkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3665
X-Proofpoint-ORIG-GUID: ErNQWYr-Bl1-TNQ_nIewuZEBGn4oc66t
X-Proofpoint-GUID: ErNQWYr-Bl1-TNQ_nIewuZEBGn4oc66t
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-07_08,2024-06-06_02,2024-05-17_01

> ----------------------------------------------------------------------
> On Wed, May 29, 2024 at 03:00:23PM -0700, Witold Sadowski wrote:
> > Add new bindings for the v2 Marvell xSPI overlay:
> > marvell,cn10-xspi-nor compatible string. This new compatible string
> > distinguishes between the original and modified xSPI block.
> >
> > Also add an optional base for the xfer register set with an additional
> > reg field to allocate the xSPI Marvell overlay XFER block.
> >
> > Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
>=20
> Missing a tag.
>=20
> But since you want it reviewed again...
>=20
> > ---
> >  .../devicetree/bindings/spi/cdns,xspi.yaml    | 32 ++++++++++++++++---
> >  1 file changed, 28 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > index eb0f92468185..49c6a2c82fc4 100644
> > --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> > @@ -15,24 +15,27 @@ description: |
> >    single, dual, quad or octal wire transmission modes for
> >    read/write access to slaves such as SPI-NOR flash.
> >
> > -allOf:
> > -  - $ref: spi-controller.yaml#
> > -
> >  properties:
> >    compatible:
> > -    const: cdns,xspi-nor
> > +    enum:
> > +      - cdns,xspi-nor
> > +      - marvell,cn10-xspi-nor
> >
> >    reg:
> >      items:
> >        - description: address and length of the controller register set
> >        - description: address and length of the Slave DMA data port
> >        - description: address and length of the auxiliary registers
> > +      - description: address and length of the xfer registers
> > +    minItems: 3
> >
> >    reg-names:
> >      items:
> >        - const: io
> >        - const: sdma
> >        - const: aux
> > +      - const: xferbase
>=20
> 'base' is redundant.

Ok

>=20
> > +    minItems: 3
> >
> >    interrupts:
> >      maxItems: 1
> > @@ -42,6 +45,27 @@ required:
> >    - reg
> >    - interrupts
> >
> > +allOf:
> > +  - $ref: spi-controller.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - marvell,cn10-xspi-nor
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 4
> > +        reg-names:
> > +          minItems: 4
> > +    else:
> > +      properties:
> > +        reg:
> > +          maxItems: 3
> > +        reg-names:
> > +          maxItems: 3
> > +
> >  unevaluatedProperties: false
> >
> >  examples:
> > --
> > 2.43.0
> >