Received-SPF: pass (google.com: domain of linux-kernel+bounces-206376-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 7 Jun 2024 11:19:25 -0400
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: andersson@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	festevam@gmail.com, imx@lists.linux.dev, kernel@pengutronix.de,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	mathieu.poirier@linaro.org, peng.fan@nxp.com, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems
 for power-domain
Message-ID: <ZmMk/T3I1jNcxKOB@lizhi-Precision-Tower-5810>
References: <20240606150030.3067015-1-Frank.Li@nxp.com>
 <19058054-5138-4d37-860f-dd430abd3a0f@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <19058054-5138-4d37-860f-dd430abd3a0f@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ekJNv7Z9qFggu730EZRQ3QMJoTiaQRs1kSlYJ9wzviCzSdmOeK36tgdqTKRY?=
 =?us-ascii?Q?Xw5JlTBf6lPdsDagPSKIJatvLWyo1f+5bGrAEjKSwDleNyQCezue9985qF9q?=
 =?us-ascii?Q?uwpOJjce7tvPK54GsaOSiizD6PVyHcUMA0WZx5XCVmMAFLHfdDo2jIQyiZmW?=
 =?us-ascii?Q?s0uAb4nz4aun5Kk0VoeKKIcakUOfW8DrJTSVNK68vCQz5qnc7btzLWm3e4N2?=
 =?us-ascii?Q?yDJtJ8GEXgV50FKq9uirFu1vSYj3/z70Abb4WDQJTF7eZvfUXYI43x76uccD?=
 =?us-ascii?Q?AYFWze2ve4DJgeqc1LIzohCwZ696Jt0UA7al+indQjR1zhhlMJxwrOLeZ5q1?=
 =?us-ascii?Q?nUomrqXp0IAa+QWqSF8TBN4SB868YkET9S6VuE1sTw3uhsrWTF8W+Skyd+bJ?=
 =?us-ascii?Q?eBp8cZiDLFfModJRfsk9qpmhOGms3PWd1KMC3W83u/NkZPNtfTJVVvjqcnm5?=
 =?us-ascii?Q?VJJi8LMONPHzcBEEi94tJdQQifqbjArs2BikkMDZibZ+V0sxeSrwyZNSXP0q?=
 =?us-ascii?Q?weKl74yM4uVZRMgBY4bfQS2dEJuD1q+CzpN9gOCpZ2XgDyy+irv5y0IR+vru?=
 =?us-ascii?Q?kNQiy+8FjCVZQy7C/bEEMfsWngutadbrCPgeo5rbXZfLUQJMnvOCGTKbhWfv?=
 =?us-ascii?Q?6Cug5J6CKzpbR4QoF2XevPu5SGjR0IXqEKJWfc6V/X12KASyQHjLG8GS0HeN?=
 =?us-ascii?Q?tfpkv/6Qvi/wNcEd56KlJ1SHlmN8hgCRH0v+fEr0nVwmQTz9/2TJZ5Kq8LMT?=
 =?us-ascii?Q?K02dBF5QGCqSW2WyoQ6Yg/kuBb3069k2tDlDGgQ41Mso431N+VlUJvCC2jjP?=
 =?us-ascii?Q?cNziars/y7IRSQz9nMjt7yKUPTPUt7DhFlcquzKvj/WFU+CgHpViMM39BFO4?=
 =?us-ascii?Q?7h5RTB5Ixzzy8zmDzPhh/+/UWRLJ0RBUVrQry4FGGBe6IoxFUghIrqZdMzTH?=
 =?us-ascii?Q?G8wx02vKJyXdmBOSkNhvcm1ttR6n3+7+kBtup3gD3aeH9XxwIc7UCjzTQGHe?=
 =?us-ascii?Q?iMBTb5vH5RkgBbdB7vVX93HW1XH+2siOg0xKCldRaHMjDwx4tdhTU7CmNr1V?=
 =?us-ascii?Q?26Z21dEmnjHR1uzZxr/Ov0pucMiSbgMhXIINuuEY00Kt7eI/QJJIO4nfi11R?=
 =?us-ascii?Q?rK3ZVv2Xyu40nUoWmIspQkuIaWeDf/OAPz24GG4afmwAydqj5kd6xyZbx82E?=
 =?us-ascii?Q?CsbwjUlFEubfAn2p32QVFhWx8+RPilx8jql3TDoiaY0S3JfLVXVWRliGijc9?=
 =?us-ascii?Q?oP417eeBb1sFydozVJqRzDGulnagpNkXAWJhdEzzF4X9peaA8iMktnSb3Wax?=
 =?us-ascii?Q?vwp8z8IgOckWv8JAJSq++uXKmM2UDMUuH2/dhDLqHuAvWwWJ+vDDTLTXTQLt?=
 =?us-ascii?Q?ij28TWW7IwXYrEZm1VqWsrBI3Pso2UkUCkpeIV+UG78gNo7bmZ4pE/M+47pl?=
 =?us-ascii?Q?L0wYrBBs1rXndEqCPqc1EYs4L6lxR+Bui6m1na/zUv1s7ovqn6T+gMvUvgSF?=
 =?us-ascii?Q?S1KpEsYA9hvvSDbunyUmE7j+YQV/xetfakg7Hx9H0lsbwlt8UPzUGu3phNAK?=
 =?us-ascii?Q?OD0aRlCs9Oi9+pcRr/K4iBOF5XZ8r/AV9ZEPT2/v?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7aec2b50-3b71-4ffd-fb17-08dc87053dde
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 15:19:36.5173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DhSoULCLd63KruNETzNTYlykYd+BHU2e7tARvOM792rtMCQmq/VM3LVlPooM3Eg5vwrRvPoYcmiLuFPXTTYwYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10266

On Fri, Jun 07, 2024 at 09:32:26AM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2024 17:00, Frank Li wrote:
> > "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep
> > the same restriction for other compatible string.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v1 to v2
> >     - set minitem to 2 at top
> >     - Add imx8qm compatible string also
> >     - use not logic to handle difference compatible string restriction
> >     - update commit message.
> >     
> >     pass dt_binding_check.
> >     
> >     make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx-rproc.yaml
> >       SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> >       CHKDT   Documentation/devicetree/bindings
> >       LINT    Documentation/devicetree/bindings
> >       DTEX    Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dts
> >       DTC_CHK Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dtb
> > 
> >  .../bindings/remoteproc/fsl,imx-rproc.yaml         | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > index df36e29d974ca..da108a39df435 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > @@ -59,6 +59,7 @@ properties:
> >      maxItems: 32
> >  
> >    power-domains:
> > +    minItems: 2
> >      maxItems: 8
> >  
> >    fsl,auto-boot:
> > @@ -99,6 +100,19 @@ allOf:
> >        properties:
> >          fsl,iomuxc-gpr: false
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          not:
> > +            contains:
> > +              enum:
> > +                - fsl,imx8qxp-cm4
> > +                - fsl,imx8qm-cm4
> > +    then:
> > +      properties:
> > +        power-domains:
> > +          minItems: 8
> 
> What happened with the "else:"? How many power domains is needed for
> other devices?

So far, only fsl,imx8qxp-cm4 ind fsl,imx8qm-cm4 need power domain (2-8). 
Power-domains is option property. 

Can I just remove whole "if"?

Frank 


> 
> Best regards,
> Krzysztof
>