Received-SPF: pass (google.com: domain of linux-kernel+bounces-206417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 7 Jun 2024 16:39:33 +0100
From: Mark Brown <broonie@kernel.org>
To: Dev Jain <dev.jain@arm.com>
Cc: alx@kernel.org, linux-man@vger.kernel.org, mingo@kernel.org,
	tglx@linutronix.de, mark.rutland@arm.com, ryan.roberts@arm.com,
	suzuki.poulose@arm.com, Anshuman.Khandual@arm.com,
	DeepakKumar.Mishra@arm.com, AneeshKumar.KizhakeVeetil@arm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] signal.7: Clearly describe ucontext kernel dump to
 userspace
Message-ID: <ZmMptdPt_Zw9Xrlt@finisterre.sirena.org.uk>
References: <20240607123119.769044-1-dev.jain@arm.com>
 <20240607123119.769044-2-dev.jain@arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FgfOfkjE5YCa53Sa"
Content-Disposition: inline
In-Reply-To: <20240607123119.769044-2-dev.jain@arm.com>


--FgfOfkjE5YCa53Sa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 07, 2024 at 06:01:18PM +0530, Dev Jain wrote:

>  .I ucontext_t
> -object that is pointed to by the third argument of the signal handler.)
> +object that is pointed to by the third argument of the signal handler.
> +We emphasize on the fact that this object contains context information

s/We emphasize on the fact that/Note that/

feels more idiomatic.

> +of the thread, present before jumping into the handler; the set of
> +blocked signals for the current thread would be updated from struct

s/would/will/

> +sigaction only after
> +.I ucontext_t
> +has been dumped to userspace. This semantically makes sense since the
> +context for which the signals have been blocked, remains only during
> +execution of the handler.)

I'd drop the "this semantically makes sense" and reword the last bit to
be something like "The ucontext reflects the state at the time the
signal is delivered rather than in the handler" for idiom reasons.

--FgfOfkjE5YCa53Sa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZjKbQACgkQJNaLcl1U
h9DppAf/X/RgRQlFGYhnwa7n+Gun0/AE+RDnThpp7qJUCOTlC3KBN8jKNDEwdtUO
mWctBu5dUXKBhDvTbfZwL1LddxI6sRrWgxPxsneZBCVEositfWCs7I7txE0ZjF0E
tiqeLOLrD/KP1fCd6PbISmA4ZoMp9zC4i5yyPkzNaTTHhHIwM/wD34NaWo3savDp
8cTVUcqHpXnMw9w2B8FiGIZgPEHLSQDRLDEwUTUefAqjJ3+O2UAlDgFfSC53vZvn
07VqZhG3lp1u+QOparz7FyudXietZmrIhk1jLLqPJSPENSWYVdUqBweOYPMZe4AR
lrqpSqp4CAOquBDNzksis1vthNUlgA==
=jZG/
-----END PGP SIGNATURE-----

--FgfOfkjE5YCa53Sa--