Received-SPF: pass (google.com: domain of linux-kernel+bounces-206458-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <90fc6f8c-0f5b-4ed4-8bdb-b6eb9d0298b4@gmx.de>
Date: Fri, 7 Jun 2024 18:08:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4a 6/6] hwmon: (spd5118) Add configuration option for
 auto-detection
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Wolfram Sang <wsa+renesas@sang-engineering.com>,
 =?UTF-8?Q?Ren=C3=A9_Rebe?= <rene@exactcode.de>,
 =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 Stephen Horvath <s.horvath@outlook.com.au>
References: <20240604040237.1064024-7-linux@roeck-us.net>
 <20240605021907.4125716-1-linux@roeck-us.net>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240605021907.4125716-1-linux@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:TyLAve/e7hk=;iIp8HhroBI320UomHSANDvoe2ic
 9qEpLl+iEwFsw1VLWTKjmHPA7M4WuRcBjdAsTRzLyQm8037LBMAtU+lnaHhc/pncuguQbW2mQ
 yeCVDLsW9pdN6Rc7GX0/tJ6z7ku8iyk7m1PfgBuXCTJ1WzaCTqKR3Dp+KXqU5lx9zEpdnzg0E
 c9OMD1rIJVOYCOmVgCIo503yy1WomF6l3flPZu7rTgfAHGgkhlO9p3Uov2lc5ag6bqRQewIZP
 7ebCPHTzvSPQa53vYuzVlgRzEadfHUnBs4/wEjHCXO9Jpwtv/+HKJFPL+wtjOgkTPPqpVUxXz
 Aq+9TeyUlXgqpZCNDScvCOJGkSTlJF9Fa4rps96NRTKhdzxRzufEcIKBAGCPAfM3bbsliyu2n
 0s1btnYcTEJQ69YLr1DZt1bJLU9ZhW/N7nDqt5omJ3SPyQuPfozfW+avJLC+GCu0v9VzaQFC/
 ha4Cu6zxpWZmbMq72PemVazRbL7oPFA8a537DlQXLCfbzN52gKqWG2iVZnjc9ngFOiKcP3QqD
 Me8YCojiwT6YgdqkOIYTpTQ7UH9IXrEIqcqcUE2yORX439QIvDVMXdGCBm0FUca6846PYpJCq
 S6BENIkj4HjY+2xfc7z4LfyFqSknTST28ziyAAodClUw3HJfiuUomoVPT3X14jtrAT/IHuDXG
 Kb1N0qPBk5NPz1RenZI1P3bF5H/2VSlhRPbvM1kwxkzTibDW+5uv+THyuIBmMRoK7SW2XKL00
 svRyrzHOJ+v51ckSbQ9Yge/o2InLpYescUwDl02d5Hxg9nymY0xRS/zjN4fRqD1wqCHYvzlWl
 EYYXMsp653HQoO8OSu6MV+2tcE781cDRTgXxtprAur0GE=

Am 05.06.24 um 04:19 schrieb Guenter Roeck:

> With SPD5118 chip detection for the most part handled by the i2c-smbus
> core using DMI information, the spd5118 driver no longer needs to
> auto-detect spd5118 compliant chips.
>
> Auto-detection by the driver is still needed on systems with no DMI supp=
ort
> or on systems with more than eight DIMMs and can not be removed entirely=
.
> However, it affects boot time and introduces the risk of mis-identifying
> chips. Add configuration option to be able to disable it on systems wher=
e
> chip detection is handled outside the driver.

Tested-by: Armin Wolf <W_Armin@gmx.de>

> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Sent as v4a to avoid resending the entire series.
>
> v4a:
>      Do not auto-select SENSORS_SPD5118_DETECT if DMI is disabled
>      Modify help text of SENSORS_SPD5118_DETECT
>      Default SENSORS_SPD5118_DETECT to y if (!DMI || !X86)
>
> v4: New patch
>
>   drivers/hwmon/Kconfig   | 19 +++++++++++++++++++
>   drivers/hwmon/spd5118.c |  4 +++-
>   2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 7a84e7637b51..d5eced417fc3 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -2193,6 +2193,25 @@ config SENSORS_SPD5118
>   	  This driver can also be built as a module. If so, the module
>   	  will be called spd5118.
>
> +config SENSORS_SPD5118_DETECT
> +	bool "Enable detect function"
> +	depends on SENSORS_SPD5118
> +	default (!DMI || !X86)
> +	help
> +	  If enabled, the driver auto-detects if a chip in the SPD address
> +	  range is compliant to the SPD51888 standard and auto-instantiates
> +	  if that is the case. If disabled, SPD5118 compliant devices have
> +	  to be instantiated by other means. On X86 systems with DMI support
> +	  this will typically be done from DMI DDR detection code in the
> +	  I2C SMBus subsystem. Devicetree based systems will instantiate
> +	  attached devices if the DIMMs are listed in the devicetree file.
> +
> +	  Disabling the detect function will speed up boot time and reduce
> +	  the risk of mis-detecting SPD5118 compliant devices. However, it
> +	  may result in missed DIMMs under some circumstances.
> +
> +	  If unsure, say Y.
> +
>   config SENSORS_TC74
>   	tristate "Microchip TC74"
>   	depends on I2C
> diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
> index 5cb5e52c0a38..19d203283a21 100644
> --- a/drivers/hwmon/spd5118.c
> +++ b/drivers/hwmon/spd5118.c
> @@ -313,7 +313,7 @@ static bool spd5118_vendor_valid(u8 bank, u8 id)
>   }
>
>   /* Return 0 if detection is successful, -ENODEV otherwise */
> -static int spd5118_detect(struct i2c_client *client, struct i2c_board_i=
nfo *info)
> +static int __maybe_unused spd5118_detect(struct i2c_client *client, str=
uct i2c_board_info *info)
>   {
>   	struct i2c_adapter *adapter =3D client->adapter;
>   	int regval;
> @@ -647,7 +647,9 @@ static struct i2c_driver spd5118_driver =3D {
>   	},
>   	.probe		=3D spd5118_probe,
>   	.id_table	=3D spd5118_id,
> +#ifdef CONFIG_SENSORS_SPD5118_DETECT
>   	.detect		=3D spd5118_detect,
> +#endif
>   	.address_list	=3D normal_i2c,
>   };
>