Received-SPF: pass (google.com: domain of linux-kernel+bounces-206456-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c939b0c7-2c8c-4cf1-8d5c-9309ce0b371a@gmx.de>
Date: Fri, 7 Jun 2024 18:06:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 5/6] i2c: smbus: Support DDR5 SPD EEPROMs
To: Guenter Roeck <linux@roeck-us.net>, linux-hwmon@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Wolfram Sang <wsa+renesas@sang-engineering.com>,
 =?UTF-8?Q?Ren=C3=A9_Rebe?= <rene@exactcode.de>,
 =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 Stephen Horvath <s.horvath@outlook.com.au>
References: <20240604040237.1064024-1-linux@roeck-us.net>
 <20240604040237.1064024-6-linux@roeck-us.net>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240604040237.1064024-6-linux@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:5FObOyZ0MWA=;g4SABbYYlkx5KCNJjhK+xGdWk7M
 5ftpeTThh7KQ3YRrcb+RwIYzlflxyH9cMYpQ3KaWB4plqiRq9JYd+dwVFh69fQdROQnVKyWTN
 EbMSAZV2R7dFdf8fVRlpSezV+zJKC44SjTxcC3mPVXzx6oxP0esBOKtLPpazBtYkSU3UHnHSE
 i6xsBeBfwt4uc7+FU/w0PjAcAAu6NkTStRebWIfmxT0aNupGrV47S4mOoF1SGiXoF83FhUN9s
 uB27/gCSCpvkRVvG0SkZ0GDkHjTRJq27kXbeN1/EHoMZpXwctI3hBprhNMclEHDblUvETKict
 X5fP7/6NRqfVdQS7DwM5pj2CcorfEg93XJObAxB48AC7MHKkbut92a8cuJESl7nuRiAjRPD8D
 0CdSEOAC/GYNN/5rvSc7zNq/dgrMbtRZ6e+rqZ+qs1x6OFatCcygsf5OWDbY5Uqa0kimlFThk
 sWLjy+maf2ngG2ndCNvY7YTBDhhhVAt3JwH4BbcSSbnCS8i+dfuCpD0fgws2XOhx/YLuk999X
 CrbXVqbIbx6fbyTdNTGTBuLKwXK7UShyiUd9u2nso26a3fpT1xpmkfjy1LKKpK6/OHgkavsV5
 O2P1QU2RwCx4kqJZI/IHUGR2vJBB+0NY0SBRrkYTkpG2ixnYooaIG757CLkFN855FjgSxwg6S
 AcrPXvj0NbQY3iCAzlV27GtH9QqZ7DUmySWe1SIZKDbJ+wsQPhvv+UimWjONGpghgE7xR5GtU
 4df46+9/I0y5s90IK7qODXCewsyQYQAnbmE/+yWm1ZuxpY51Zmn0AVFmO6ZOI1Zk3Hv5+0/yV
 oYCM2rG+WHOhkg2XIvhLq02VoFNyLAQXuwJpBWiZL41Ow=

Am 04.06.24 um 06:02 schrieb Guenter Roeck:

> Detect DDR5 memory and instantiate the SPD5118 driver automatically.

Hi,

the text "Only works for DDR, DDR2, DDR3 and DDR4 for now" should be updat=
ed too.
With this fixed:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

>
> Suggested-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v5: New patch
>
>   drivers/i2c/i2c-smbus.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
> index 97f338b123b1..8a0dab835761 100644
> --- a/drivers/i2c/i2c-smbus.c
> +++ b/drivers/i2c/i2c-smbus.c
> @@ -382,6 +382,10 @@ void i2c_register_spd(struct i2c_adapter *adap)
>   	case 0x1E:	/* LPDDR4 */
>   		name =3D "ee1004";
>   		break;
> +	case 0x22:	/* DDR5 */
> +	case 0x23:	/* LPDDR5 */
> +		name =3D "spd5118";
> +		break;
>   	default:
>   		dev_info(&adap->dev,
>   			 "Memory type 0x%02x not supported yet, not instantiating SPD\n",