Received-SPF: pass (google.com: domain of linux-kernel+bounces-206498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 7 Jun 2024 09:35:30 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] media: c8sectpfe: Add missing parameter names
Message-ID: <20240607163530.GC2483293@thelio-3990X>
References: <20240606-c8sectpfe-v1-1-c4b18f38295d@chromium.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606-c8sectpfe-v1-1-c4b18f38295d@chromium.org>

On Thu, Jun 06, 2024 at 01:01:07PM +0000, Ricardo Ribalda wrote:
> clang 19 complains about the missing parameter name. Let's add it.
> 
> drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h:19:62: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406050908.1kL1C69p-lkp@intel.com/
> Fixes: e22b4973ee20 ("media: c8sectpfe: Do not depend on DEBUG_FS")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> index 8e1bfd860524..3fe177b59b16 100644
> --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-debugfs.h
> @@ -16,8 +16,8 @@
>  void c8sectpfe_debugfs_init(struct c8sectpfei *);
>  void c8sectpfe_debugfs_exit(struct c8sectpfei *);
>  #else
> -static inline void c8sectpfe_debugfs_init(struct c8sectpfei *) {};
> -static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *) {};
> +static inline void c8sectpfe_debugfs_init(struct c8sectpfei *fei) {};
> +static inline void c8sectpfe_debugfs_exit(struct c8sectpfei *fei) {};
>  #endif
>  
>  #endif /* __C8SECTPFE_DEBUG_H */
> 
> ---
> base-commit: 1aea3d1d4a21e3e7895663b848ffae79ee82e065
> change-id: 20240606-c8sectpfe-5f00b9867f36
> 
> Best regards,
> -- 
> Ricardo Ribalda <ribalda@chromium.org>
>