Received-SPF: pass (google.com: domain of linux-kernel+bounces-206505-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a69b0e95-f89e-46b6-bf25-98984e95c751@amperemail.onmicrosoft.com>
Date: Fri, 7 Jun 2024 23:46:52 +0700
User-Agent: Mozilla Thunderbird
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: max31790: Add
 maxim,pwmout-pin-as-tach-input property
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Guenter Roeck <linux@roeck-us.net>, Conor Dooley <conor@kernel.org>
Cc: Chanh Nguyen <chanh@os.amperecomputing.com>,
 Jean Delvare <jdelvare@suse.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>,
 Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240414042246.8681-1-chanh@os.amperecomputing.com>
 <20240414042246.8681-4-chanh@os.amperecomputing.com>
 <13b195e6-cbbd-4f74-a6fa-d874cb4aaa45@linaro.org>
 <065243cc-09cf-4087-8842-bd4394fb324f@amperemail.onmicrosoft.com>
 <d549cf2b-a7fa-4644-8fcb-3c420503ee01@amperemail.onmicrosoft.com>
 <20240423-gallantly-slurp-24adbfbd6f09@spud>
 <ab5cfd8c-0e88-4194-a77e-5ffbb6890319@amperemail.onmicrosoft.com>
 <396b47f5-9604-44ab-881f-94d0664bcab8@roeck-us.net>
 <0dcc8788-604a-49c1-8c6b-fdbfa9192039@amperemail.onmicrosoft.com>
 <da94fde6-3286-44eb-a543-c2ac4d11cd32@roeck-us.net>
 <8fb38eb3-bb94-49cc-b5bc-80989d7876b9@amperemail.onmicrosoft.com>
 <a20479be-a4cf-4fb5-8d37-277d14a93224@linaro.org>
Content-Language: en-US
In-Reply-To: <a20479be-a4cf-4fb5-8d37-277d14a93224@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qnc0SGcyTlEzL25PakpuNXlVNDdPREFjdnZTVld1NStNQmIvenUrMHdSTmg0?=
 =?utf-8?B?QXR1TjdQWUIwdGtVdTlXU0Y1bStwOFFXMk5uRXBQTTdmRi82QVY2TldDcml4?=
 =?utf-8?B?UWhncm0rTzNVNGoxcktBKzk0eDlUMUxEMkE1TURiZk1UaUF3b3ltQzk1c0dq?=
 =?utf-8?B?M0xTdThDRFQ5dlpSNE9hL1RFNmwrOEtGdnMxVVZGeHZjd2hhNjFiQ0h4M2lp?=
 =?utf-8?B?aFRpOUk1VUpyRC83dTZ2WDlqb1JVdWVJemZKL0VkU1k0VHBWVnJYcW5mQ3do?=
 =?utf-8?B?c3pQNC9aQmlqVlEwWHgybGlUMDJMUzBQRUYxdkhDbFRoQ0ZMMzRxdzgyclp1?=
 =?utf-8?B?VGpNdG5ZU2VzRmhuVHJsZWw4ayt3dEl3Q0xTaFp4enRNemFtZStJeDZSY0po?=
 =?utf-8?B?VmtsTEZ4cWNuRVQwb2hqbjBHTFp0eGFvRG1OTkV2L1Zjd01WVG9heEVzcDZ3?=
 =?utf-8?B?T0tCZHNnN3B4U3pKK2hsNnU4LzBpOFlmbVJJbDdpaFZNS1BuUlFzbitjV09q?=
 =?utf-8?B?VkFMMGZrZ0duQU4vSXlRVDRuaUR1czRscGdSak9FU0NXUkpydVg4MnNaWStz?=
 =?utf-8?B?NzlCa0s5KzVTUlAzWUQyR25tVDd4Y3hCaU41c1MxaVlHVCtmNmordk1mSHEw?=
 =?utf-8?B?SG5IRlV5ZTNvTkg1QjZ5Y2F1dlJzY0FVWVhCd2ZpR1dwbk40T2pQdndwVkFu?=
 =?utf-8?B?TnZHcHNyNUFTdFFIVVo0bWFwSzlVVVRmU2QxbUNUWnNUV0U3RjJFVHduYmZC?=
 =?utf-8?B?Z0J4S3hrVERqWnJpOE4xdHlvMjFDK213MVQzRHc4aW1DNlpoaUlPRHpOb1lw?=
 =?utf-8?B?N29BZGJmWTJDL1F6TEJhZmRzMmlZVXBnWDNxbXYrbytUR0Z0MU9GM1grQ0pP?=
 =?utf-8?B?dXRBeFFLb1I0dXVmdTAyVmZrdndaQzdvMy9sNXc1WlRqTCtQUDNYeVBrUzFt?=
 =?utf-8?B?UnZ1NWQ3c1JsUVZaV3JZTXBybTJzdVBmYk1nZ25VN2owR3YwNTY3UkV4ZnJq?=
 =?utf-8?B?ZE1Sa0lKUExWNWowUWY5WVBZWE96aWpSS1VjV3lUUGxEZkZyVFVFazl5Y1FZ?=
 =?utf-8?B?bGx5SlJGU055SjhMNEg3VGs0VEtXaVh6WmZiK0lubDI3TEV5Zzg1eDlYSG1Q?=
 =?utf-8?B?UVhkRmgxVWRwTDgyNHR3WlcyZVVtMTNab05qenUrcWxjN1g2cVk3cDEvUHFt?=
 =?utf-8?B?QjBlSmtBS3BJdWhUTW5wWDczVE9zaWxYdjcybUd0WlRSd0pKUEFnR3ZZS09u?=
 =?utf-8?B?aFoyUjFHa0xtcFhkMHhRdHMxZ05SQWJlbEFHNDdtanVhWk9MLzJtRHJaWitl?=
 =?utf-8?B?U2oxSDg1S01TR1doWm5MWldLWlE3eVF4bTkvRnhYeWZCamdnQ2dITHJWNzFR?=
 =?utf-8?B?bnN4NGJCSjhyNGVxRy8yZy85RzVPNzZGK1BBamdVcGhXa2o1V1pXYjQxdVJL?=
 =?utf-8?B?ZkJ6eWVjUE1qV052eHZwT0svTUlkYWdLRWNwbkZOQVB2SnJDOHhDNEJnYlFs?=
 =?utf-8?B?SXc1OHVhQ1hxV1h4MUZMc3lobGlEZzBtMHlNYWZ4ZGtoL2pZNWVQb2xnTFow?=
 =?utf-8?B?aXFsUkYzdWI2UUQzQ3dVaWhBbEU0VVFVVWZ0QXVjdU14MmlMNXh4RXREWUN5?=
 =?utf-8?B?VC83K1BqZTNOVmUrN3IwbHJ3NmJmYlM3UUhlUlBKS3diUE0zaWhTWDVLVms0?=
 =?utf-8?B?ZnBvRFpONVNaN0hpbXhkRnlWamVLTzdLdjlVcEx0eXZ5cEZXUHFFZ2VVbVBu?=
 =?utf-8?B?bFZXaFJKY0RRaVpTY29JNTkwVlVpRHN2TDhPQ0Zwd0txUmhacktJdWo2NE1v?=
 =?utf-8?B?UjlPMERDOERZdEM1RVpnSTZNM1RsOFluM21sV2k2MlRnaTIwTjFDRWhkYlFE?=
 =?utf-8?B?RXRaYnlhM0RjMDRCVGZnbnlpYjRVdy9GSlV2RDF5SHF5MnFyWVMvanl6TWYy?=
 =?utf-8?B?SllORTIzM3lxMTk5TTJkWjVsSEluKzYzcTNsOXVzdkt0Q3BpeW9wVTBFT2ts?=
 =?utf-8?B?SzlCRXFIYXBQYzM3VFJrWDVqeW03UlNIczhCekdlUVpEdzJ1SUlpVWxHRTBx?=
 =?utf-8?B?dkxIVnR1b2h0ek9hZjRwUHloRlVFNGZUa3FERWlpcnhhcjE5aDYvSDZRV1Aw?=
 =?utf-8?B?dnRjd1RYK3hIbFE0cUlQN0pzWTIzSllxYTNQUkg1d3lpRHEwZXc4ZFBnUTZT?=
 =?utf-8?Q?16w5E93uBu/V14HDC8JU55Y=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e8dcf05-e880-4725-74d8-08dc871174e6
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 16:47:03.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q+BHTRgK3wjU3RbdgXnRvnPmlg/Oo7OmA6eG9D91XtzXgpkYzE2lxsKZ9ReBd7SbUnMCflsuq/2ptEDnsfALTyOmkD4v1RxqsIgyeUGZC8uhPvMdrkP3lMqOGMo03/6+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB7051


On 09/05/2024 15:29, Krzysztof Kozlowski wrote:
> On 08/05/2024 05:44, Chanh Nguyen wrote:
>>>>>>
>>>>>
>>>>> I am not even sure how to define tach-ch to mean "use the pwm output pin
>>>>> associated with this tachometer input channel not as pwm output
>>>>> but as tachometer input". That would be a boolean, not a number.
>>>>>
>>>>
>>>> Thank Guenter,
>>>>
>>>> I reviewed again the "tach-ch" property, which is used in the
>>>> https://elixir.bootlin.com/linux/v6.9-rc6/source/Documentation/devicetree/bindings/hwmon/aspeed,g6-pwm-tach.yaml#L68 and https://elixir.bootlin.com/linux/v6.9-rc6/source/drivers/hwmon/aspeed-g6-pwm-tach.c#L434
>>>>
>>>> That is something completely different from my purpose.
>>>>
>>>
>>> Based on its definition, tach-ch is associated with fans, and it looks
>>> like the .yaml file groups multiple sets of fans into a single
>>> fan node.
>>>
>>> In the simple case that would be
>>>       tach-ch = <1>
>>> ...
>>>       tach-ch = <12>
>>>
>>> or, if all fans are controlled by a single pwm
>>>       tach-ch = <1 2 3 4 5 6 8 9 10 11 12>
>>>
>>> The existence of tachometer channel 7..12 implies that pwm channel
>>> (tachometer
>>> channel - 6) is used as tachometer channel. That should be sufficient to
>>> program
>>> the chip for that channel. All you'd have to do is to ensure that pwm
>>> channel
>>> "X" is not listed as tachometer channel "X + 6", and program pwm channel
>>> "X - 6"
>>> for tachometer channels 7..12 as tachometer channels.
>>>
>>
>> Hi Guenter,
>>
>> I applied the patch [2/3] in my patch series
>> (https://lore.kernel.org/lkml/20240414042246.8681-3-chanh@os.amperecomputing.com/)
>>
>> My device tree is configured as below, I would like to configure PWMOUT
>> pins 5 and 6 to become the tachometer input pins.
>>
> 
> And what is wrong in described common tach-ch property? I think we
> explained it three times and you did not provide any arguments, what's
> missing. Instead you say "I want something like this in DTS" which is
> not an argument and does not help discussion.
> 

Hi Krzysztof,

Apologies for any inconvenience caused by the delayed response.

I'll to support the child nodes by having different tach-ch values. I 
suggest the child nodes and the "tach-ch" is optional, it will not be 
added to "required:". Do you have any comments? Please help me share!

This is a brief binding
...
properties:
   compatible:
     const: maxim,max31790

   reg:
     maxItems: 1

   clocks:
     maxItems: 1

   resets:
     maxItems: 1

patternProperties:
   "^fan-[0-9]+$":
     $ref: fan-common.yaml#
     unevaluatedProperties: false

required:
   - compatible
   - reg

additionalProperties: false

examples:
   - |
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;

       pwm_provider: fan-controller@20 {
         compatible = "maxim,max31790";
         reg = <0x20>;
         clocks = <&sys_clk>;
         resets = <&reset 0>;

         fan-0 {
           pwms = <&pwm_provider 1>;
           tach-ch = <1 2>;
         };

         fan-1 {
           pwms = <&pwm_provider 2>;
           tach-ch = <7 8>;
         };
       };
     };


If it's OK, I'm going to push the patch series v3 soon.

Thanks,
Chanh Ng

> Best regards,
> Krzysztof
>