Received-SPF: pass (google.com: domain of linux-kernel+bounces-206513-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Uwe =?utf-8?Q?Kleine-K=C3=B6nig?=" <ukleinek@baylibre.com>
Date: Fri, 7 Jun 2024 18:43:23 +0200
To: Benson Leung <bleung@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>, linux-pwm@vger.kernel.org, 
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] pwm: cros-ec: Don't care about consumers in
 .get_state()
Message-ID: <loyvxce22gz6gwcp7vgjbttbtasmoyjwf6bdash4kqzhsf4na7@zf627ythm2ge>
References: <20240607084416.897777-5-u.kleine-koenig@baylibre.com>
 <20240607084416.897777-6-u.kleine-koenig@baylibre.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="mhwn6reey4op4eyi"
Content-Disposition: inline
In-Reply-To: <20240607084416.897777-6-u.kleine-koenig@baylibre.com>


--mhwn6reey4op4eyi
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 07, 2024 at 10:44:15AM +0200, Uwe Kleine-K=F6nig wrote:
> The get_state() callback is never called (in a visible way) after there
> is a consumer for a pwm device. The core handles loosing the information
> about duty_cycle just fine.
>=20
> Simplify the driver accordingly.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@baylibre.com>
> ---
>  drivers/pwm/pwm-cros-ec.c | 33 +--------------------------------
>  1 file changed, 1 insertion(+), 32 deletions(-)
>=20
> diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
> index 606ccfdaf4cc..ba4ee0b507b7 100644
> --- a/drivers/pwm/pwm-cros-ec.c
> +++ b/drivers/pwm/pwm-cros-ec.c
> @@ -25,15 +25,6 @@
>  struct cros_ec_pwm_device {
>  	struct cros_ec_device *ec;
>  	bool use_pwm_type;
> -	struct cros_ec_pwm *channel;
> -};

I forgot to drop the kernel doc comment. Unless I get some feedback that
makes me send a v2, I'll squash the following into this patch when
applying:

diff --git a/drivers/pwm/pwm-cros-ec.c b/drivers/pwm/pwm-cros-ec.c
index fcc33a2cb878..189301dc395e 100644
--- a/drivers/pwm/pwm-cros-ec.c
+++ b/drivers/pwm/pwm-cros-ec.c
@@ -20,7 +20,6 @@
  *
  * @ec: Pointer to EC device
  * @use_pwm_type: Use PWM types instead of generic channels
- * @channel: array with per-channel data
  */
 struct cros_ec_pwm_device {
 	struct cros_ec_device *ec;

Best regards
Uwe

--mhwn6reey4op4eyi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmZjOKYACgkQj4D7WH0S
/k4gHwf+IZdctA9vZgZrUZACvGGOpgs2zu3k4EIKxgfFK1nwlxmXo2yYY+JpGCP8
UMzDV4Xen8UDwVhfjQtvMkZ0ZepmO60NNQqHSkbaws5CbtyeF6vvlktE0+w22Y+Y
71+B8ShFk6pOS4YVEFNPh+kB+LjhRZ0MwdmxJUWBguxqHGIEruOrHVds0jiPlcnW
2JSnIkNiQF5Tpt1lDtY634BVhb8Io/E6ZTYR7MPtD/BqAXwNg+jheyNGFSYUAeu/
jsorkAXn+rwz03Fkrk5x05dNUXY3ikxUywJrZbTliqjKIP+BjQ4F2a623fygl0tt
MzmI9xu7YcT3VDE3vitmLOR7c5c5Aw==
=bXer
-----END PGP SIGNATURE-----

--mhwn6reey4op4eyi--