Received-SPF: pass (google.com: domain of linux-kernel+bounces-206122-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
To: Lyndon Sanche <lsanche@lyndeno.ca>, Hans de Goede <hdegoede@redhat.com>, 
 =?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20240604-dell-pc-double-free-v1-1-6d81255b2a44@weissschuh.net>
References: <20240604-dell-pc-double-free-v1-1-6d81255b2a44@weissschuh.net>
Subject: Re: [PATCH] platform/x86: dell-pc: avoid double free and invalid
 unregistration
Message-Id: <171776656561.2612.17760986388744096307.b4-ty@linux.intel.com>
Date: Fri, 07 Jun 2024 16:22:45 +0300
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Tue, 04 Jun 2024 23:41:24 +0200, Thomas Weißschuh wrote:

> If platform_profile_register() fails it does kfree(thermal_handler) and
> leaves the pointer value around.
> Any call to thermal_cleanup() will try to kfree(thermal_handler) again.
> This will happen right away in dell_init().
> In addition, platform_profile_remove() will be called although no
> profile is registered.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-pc: avoid double free and invalid unregistration
      commit: dd637f5cd5f334d2d014872544470031415cec3b

--
 i.