Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1201255lqt; Fri, 7 Jun 2024 10:43:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV97JKH1NASUdp+1Tlhb+wFsRt7JkJ94f0gmIDyznl2ShbmqDqNoGtHL0x+eOQjShA1/13WXUWFyNkdR9aMi1poX6EW5zGPMesl5b2G0A== X-Google-Smtp-Source: AGHT+IHaX8Gt1t463l2v85/grR7OJft37bS597wW4j44tlhGVo2uHfJfHuS4b5MNobJ0jzSsvEa9 X-Received: by 2002:a50:ccd4:0:b0:579:b6d:b8ba with SMTP id 4fb4d7f45d1cf-57c50932e44mr1689754a12.22.1717782180499; Fri, 07 Jun 2024 10:43:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717782180; cv=pass; d=google.com; s=arc-20160816; b=B6NEyBDGyAXnaH0CRaK4UyyYguIexdpf9pJHji0SawQalZ7pHm5vMx5WYFQDVKQZWc bkKl7tmwGty/Kh38Cb1MfG/gkWKvsr2b99ue5ezoMw+LImzczjCuisaRAJNY5s8NVI4v mh/jWBD8Ct82tFVzr5o2R6y2K5M4klb+YcHk4CI/Z4kfpGjlqhP86p09/hUllIL4xqX3 rMETkIvlnEqJkgX5+wuaWUNgVUHEnFWKMHuc9AAWeA8zUU0w6DhZp6gt5/ziXv/4x7Pf 0mJOS/nkAENLMLEnp8kvXkG80AqkQzADtxS8h2uIsY2+r8loAQFY19uOjiiBy39TG1zN 1xPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=DK/doUF7yTTXX8iTuUnOBTZFHOckh/vitC+oaavQikg=; fh=T0Q3HcpJpjjreIvchP1/VzhWV8wf235rqW/y/zU4G7I=; b=xpQxjO1z22yW+8iwNW4Jc2yXo6RFWC6Bu/unt5DMeJwiRHktd4GwMWwz9Id4cNTySp GM+/R0+E0QTd7NKTpnVV2ls7gwwzYKT6swBsqsI4BjuZ7e8/N3UBhhPN5xqYD98sgrmE ZI6yMpEaqu/+RDSNBZm6zc8I7ftm0Sct4908dZrmLh1C/Pu+g7jxD9ZF2HLC5LvdNxow /lhsk9BAY6IOzfUluEFHRU2q6yEn7bIACEyCoRd4Vibq9Y7sijG7jsufV29DdM3expAM QZ4L6YpbisonQaGoQQrCCkirZnw/H07w2buC0pLSOS1hiCBfnBHa0eftkejcS3QUBOIS OdXQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NIwXHJ+D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-206559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c67d275edsi186469a12.211.2024.06.07.10.43.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 10:43:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-206559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NIwXHJ+D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-206559-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206559-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2B4D41F229DB for ; Fri, 7 Jun 2024 17:42:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1D1E919B594; Fri, 7 Jun 2024 17:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NIwXHJ+D" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38CFE13793E; Fri, 7 Jun 2024 17:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717782160; cv=none; b=sE023S2FISsk5VsKtLj3UJYLHSCXF6ImflSWz87JCuMOSd2zNGQSMKz3lghXmr3ERBdzYFJFosMf7jEf3dznJaM0bk89sOVvUafbzrf8tWMDLmMV4Rv+OgaGq7yncid+Djv2IpUbAj18WAG3mXtHNW5iBLrk4aB//LrrqfqcvI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717782160; c=relaxed/simple; bh=f/Gzsxd+eQ/cbzkdzNthU2SrdFC/gyNJ6J4i3UG2L8c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=euo85/VJyoICY6wRzu+qmDrWsh60tCBCmuJK51RNkt+t0ih+euBAw7yT6tMUk2UU6zT32VZCXzKjUdZScEyALI5cCN0h/svMMANAMG/zULOGAJIvLCXISedcJsjxTvZzXg0acbloUUGKqW74UR09lFyii/YJIHK2dzBGf9TRKyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NIwXHJ+D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71EB6C2BBFC; Fri, 7 Jun 2024 17:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717782159; bh=f/Gzsxd+eQ/cbzkdzNthU2SrdFC/gyNJ6J4i3UG2L8c=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=NIwXHJ+D/tS2Se2b0FvpeowBahmQ7+buX+CNSGzFME93XigN3t53gZcrhrJ6HJXKX fpQ8DB1Kev7tkyc41aHutru1cMLho4nGn5PLmZyLcYfc0dT97sxs8jd1IRw7W2qc2Y FW5VlBmxbtxgBogUJZ9paCnaI+hkmQQA7k66gZ0Lez01wOO7m7ogbDM/5vp4Ca5JBC eyCL2D3KMhRFGJVv5hLM/CIM0f8gzU2CE/GlnuSlbR1RqfJgOwWSGDcptDJyXYsUjn WOq0GlGtJeLxOXZgETfvFtmv4jLOp8cNGf5eULOgeJ2NGfgqd4eqhhCUSDt1wmZLPG SQ114lhIXviFg== Date: Fri, 7 Jun 2024 12:42:37 -0500 From: Bjorn Helgaas To: Wei Huang Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, alex.williamson@redhat.com, gospo@broadcom.com, michael.chan@broadcom.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, andrew.gospodarek@broadcom.com, manoj.panicker2@amd.com, Eric.VanTassell@amd.com, vadim.fedorenko@linux.dev, horms@kernel.org, bagasdotme@gmail.com Subject: Re: [PATCH V2 4/9] PCI/TPH: Implement a command line option to force No ST Mode Message-ID: <20240607174237.GA853301@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531213841.3246055-5-wei.huang2@amd.com> On Fri, May 31, 2024 at 04:38:36PM -0500, Wei Huang wrote: > When "No ST mode" is enabled, end-point devices can generate TPH headers > but with all steering tags treated as zero. A steering tag of zero is > interpreted as "using the default policy" by the root complex. This is > essential to quantify the benefit of steering tags for some given > workloads. > #ifdef CONFIG_PCIE_TPH > int pcie_tph_disable(struct pci_dev *dev); > +int tph_set_dev_nostmode(struct pci_dev *dev); Exported functions need a "pci" or "pcie_" prefix. We haven't been completely consistent on this; we have "pci_acs_*", which is obviously PCIe-specific, but we do also have pcie_find_root_port() etc.