Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp1201517lqt; Fri, 7 Jun 2024 10:43:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW0o7EBfO0i7q89eiWbJvDqeEvF9YUsJaywrVanMc/eR5zw6aZIPhYp8pu12RPwzIhczuyLSmaKxHOJbZPBUoVTT2bWeSWm9CU9yJbJRA== X-Google-Smtp-Source: AGHT+IFmZX+bAnAb/H2lktaYdbNa88oEOh37MzdWdGw0KMx4uafa1zOidVXq+tJY91IG3tLuDbYF X-Received: by 2002:a05:6214:440a:b0:6ae:2da4:fd89 with SMTP id 6a1803df08f44-6b059bdc31emr36957946d6.31.1717782214037; Fri, 07 Jun 2024 10:43:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717782214; cv=pass; d=google.com; s=arc-20160816; b=hxYmxNc2985ynpCemUGBDfyOgViP/9ovWLzdZFAdn39zpD7TUxBnXJowoivLgGoj9f 89wLHrnwoFlunhXpFJ6ggQh74AKD+uR1tvw0Ghhd2Wraf+rJX3dtZbc7hAhL5qY9+mrv toCHYSn10uRstv3b9eD7MHlAkvxSsmWomslof9ttyHyqHuN04DLziF3Ll/ZH01UdPVOX Z2xMswb4zTwnAtxmOwl2UzPBFoLMQ7mqEaXiG912FFsa77qbrREBS/elj34grZ/iaCRB 4oA/0/+DJ7s4scEoWZDJEy4rBnmzYKuPM1OkpLifeqkTL6An4p6C2AtTti6gmcWFI0fs /XxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0lO4M4B/1doX05fiJSFcuot4ycZ2kQVZj5LylAFu1X8=; fh=zv0Ult5abkBfi4hqC1WAYkdHfKTKRKHFiq8x0WT4ML8=; b=FsaitFGnNcYcX793TAaPCRBlqH1FCoqmwpNVtgERAW5Yu768RsGLE7eGjszQlVC/9V F6g601saLjB/M1U8d3/7Yg6Sz4G5RkFxZBOxTv5LtWAz5bw6dMhZdTC3tKlp0vBGT5iG 8JeJuKzW3ExTCblqncpWvmGpgPdELSz8xAKn0Wp7GyX5E9vhcDfVADWIB6ngpD0mLF8F VNE4KTbEkXWreTW5t7j0xu5EjdYJ28XEae+tij/hD0k8Tq2Fj/cZ30LRFBnwMy1SZ1F0 Hju3gdtib6DZ0H3qAZyjyem7+/Zoq6toPz31eZgS4t4SfNWVgjtDkqmZsGInXm85X62U EXgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WJfaBeZj; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-206560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6b04f9fe043si42985646d6.435.2024.06.07.10.43.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jun 2024 10:43:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-206560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WJfaBeZj; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-206560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-206560-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EAE231C217F1 for ; Fri, 7 Jun 2024 17:43:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A9F919B3C4; Fri, 7 Jun 2024 17:43:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WJfaBeZj" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF28619066F; Fri, 7 Jun 2024 17:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717782200; cv=none; b=aTvKkSpQvWJejn6gepfwr3aKuW8aVQ72rMGqvTm1fUHFFxiYay6YgrT20CXTXDoofQbqK0BBwGN6l0tLALBF1BnsDfKXVonQe1ImeMCEdh2/c2WP/Nxt8fpP2sYCvsz/ZTEgsxTdk+bT5FCPjBe0LeGbdOimn4ddZwTh6l60QOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717782200; c=relaxed/simple; bh=BljvyepxXT4x1++sRMx+Q1dhUFcguaAkYXBQIoz5Y4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u2Ak+rd1HKBCnSlNEMoNBV27kN0L2rWFanD3as4vAI35tdnN60NM42Vn8pWVcC0QC3ZIqK0rdBzBDFoyfrvnF9EcLrdXfDsfl4Vg0yLV/7088RcorAgZHk/MmQEPE+Thbf+ffxUscoy0DMvKNTwCgTUem0VqD/tPerZdLiswsEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WJfaBeZj; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717782199; x=1749318199; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=BljvyepxXT4x1++sRMx+Q1dhUFcguaAkYXBQIoz5Y4E=; b=WJfaBeZjgqqYqaxW+5mccoqY9f8ou+TZJRYEHQdcRfWT6Dj00J5uAMGl Mzn4qX0Hwix/KcX7aupvnGeoMRVNj03dmE8k1uQBVJPNBtGdWUnm76OMR +BIJ+M87tUwTGpE1vwuhGV7o2g0r+Kj5MK2m6lr6Q+COEBzkEYLe+Y+ut gP4+q0T7GOlbXYHKZMWqmL/qlsUHd9ndV1+CNK+mudjcGPrsGHXZdAwmD qcM3i+TkYUfqUNEvAFZBKs0KlUTWjlO55t8Kuc5V1U8ux7JqMnilrEkkC ofTlBHpoHD/4+xQ167uIfiM4Vyq+x1wTwQTHzxjzaxBttTdZH67Zih9zz w==; X-CSE-ConnectionGUID: ICIHYRfYTVaBL6QvHIMtFw== X-CSE-MsgGUID: Drkyf0ZWSaWDLEQ2VgSz/Q== X-IronPort-AV: E=McAfee;i="6600,9927,11096"; a="25918177" X-IronPort-AV: E=Sophos;i="6.08,221,1712646000"; d="scan'208";a="25918177" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2024 10:43:19 -0700 X-CSE-ConnectionGUID: vbNlkgoBRPyz/3hCWYQDkA== X-CSE-MsgGUID: 1NbwmMqBRiuhN/hdh3cqJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,221,1712646000"; d="scan'208";a="69560613" Received: from msatwood-mobl.amr.corp.intel.com (HELO [10.125.109.219]) ([10.125.109.219]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2024 10:43:16 -0700 Message-ID: <1d405428-3847-4862-b146-dd57711c881e@intel.com> Date: Fri, 7 Jun 2024 10:43:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] x86/sgx: Resolve EREMOVE page vs EAUG page data race To: Haitao Huang , Dmitrii Kuvaiskii , dave.hansen@linux.intel.com, jarkko@kernel.org, kai.huang@intel.com, reinette.chatre@intel.com, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mona.vij@intel.com, kailun.qin@intel.com, stable@vger.kernel.org References: <20240517110631.3441817-1-dmitrii.kuvaiskii@intel.com> <20240517110631.3441817-3-dmitrii.kuvaiskii@intel.com> <01bb6519-680e-45bf-b8bd-34763658aa17@intel.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/3/24 11:42, Haitao Huang wrote: >> Second, convince me that this _needs_ a new bit.  Why can't we just have >> a bit that effectively means "return EBUSY if you see this bit when >> handling a fault". > > IIUC, reclaimer_writing_to_pcmd() also uses > SGX_ENCL_PAGE_BEING_RECLAIMED to check if a page is about being > reclaimed in order to prevent its VA slot fro being freed. So I think we > do need separate bit for EREMOVE which does not write to VA slot? I think the bits should be centered around what action the code needs to take and not what is being done to the page. Right now, SGX_ENCL_PAGE_BEING_RECLAIMED has two logical meanings: 1. Don't load the page 2. The page is in the backing store But now folks are suggesting that a new bit is added which means "do #1, but not #2". Let's take a step back and look at what logical outcomes we want in the code and then create the bits based on _that_.