Received-SPF: pass (google.com: domain of linux-kernel+bounces-206598-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240509184502.52480-1-mario.limonciello@amd.com> <c9e4b02d-6e3a-4813-8c87-769944176ff2@redhat.com>
In-Reply-To: <c9e4b02d-6e3a-4813-8c87-769944176ff2@redhat.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Fri, 7 Jun 2024 20:25:23 +0200
Message-ID: <CAJZ5v0j3crbhGw8-nnacO9V1-7wOnLh0rSUXm8mnXy3xzb_uZA@mail.gmail.com>
Subject: Re: [PATCH] ACPI: x86: Force StorageD3Enable on more products
To: Hans de Goede <hdegoede@redhat.com>, Mario Limonciello <mario.limonciello@amd.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Yilin.Chen@amd.com, Randy.Perez@amd.com, Michael.Chiu@amd.com, 
	stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, May 12, 2024 at 9:05=E2=80=AFPM Hans de Goede <hdegoede@redhat.com>=
 wrote:
>
> Hi,
>
> On 5/9/24 8:45 PM, Mario Limonciello wrote:
> > A Rembrandt-based HP thin client is reported to have problems where
> > the NVME disk isn't present after resume from s2idle.
> >
> > This is because the NVME disk wasn't put into D3 at suspend, and
> > that happened because the StorageD3Enable _DSD was missing in the BIOS.
> >
> > As AMD's architecture requires that the NVME is in D3 for s2idle, adjus=
t
> > the criteria for force_storage_d3 to match *all* Zen SoCs when the FADT
> > advertises low power idle support.
> >
> > This will ensure that any future products with this BIOS deficiency don=
't
> > need to be added to the allow list of overrides.
> >
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>
> Thanks, patch looks good to me:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Applied as 6.10-rc material, thanks!