Received-SPF: pass (google.com: domain of linux-kernel+bounces-206613-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 7 Jun 2024 14:52:35 -0400
From: Frank Li <Frank.li@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] arm64: dts: imx8qm: add lvds subsystem
Message-ID: <ZmNW81FbILhkTAlg@lizhi-Precision-Tower-5810>
References: <20240606-imx8qm-dts-usb-v1-0-565721b64f25@nxp.com>
 <20240606-imx8qm-dts-usb-v1-1-565721b64f25@nxp.com>
 <AM6PR04MB5941C0BBD0A64A9AFDD8EC5A88FB2@AM6PR04MB5941.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AM6PR04MB5941C0BBD0A64A9AFDD8EC5A88FB2@AM6PR04MB5941.eurprd04.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?V1SO9Ve5O/Fx7U/gQ+pcGtpY228F1uRnlR7q89l4s4eqSIG0+7xcvxSbqp0X?=
 =?us-ascii?Q?1v+rnLwATNqLlqxGJ4w9qbp+N0IQ3VdO96nMinNCosPukJA86ymV/8KfWDvu?=
 =?us-ascii?Q?SaA+mKBxIj4M1Cpp2d6x7ZFJ4w4qqb0F4c8TQDNQBcJJLqplUBPJUL15dqSX?=
 =?us-ascii?Q?cBytFSk5LTI15IcpqkkuEauZePG7CWaGc5Dt9OXNOS9EELzGcs1cOFWC/DEK?=
 =?us-ascii?Q?nuct2erqoVJ2hD9yC9y3Ns3nBCkRZuhEXftAHJeiDu9Ied9hAHInaMIQW9Xs?=
 =?us-ascii?Q?yb210TWTJxY7DDwy1iF0CpyAHe0aGZ5t3+hyLuXEGRwHeWz/8bMXWo8DgLhg?=
 =?us-ascii?Q?gKo0riIaLaMcRD8KzttGvX/wUnfIoisVya4pSoKjEAhnbg6gOeJ3dDWmlpB9?=
 =?us-ascii?Q?NCiIL/uKsqgOX4WkotytZno/AG9X+MJUsDq0WZOe6GpkT8tuX60esbxqRmY6?=
 =?us-ascii?Q?4fi9nldqghQtXwfhSQJB8xx1Lf7kNduxW3HqivKRNsI87JBnLrDpFxfVnmW6?=
 =?us-ascii?Q?BF0VQutpOg8YJ5rnsKBYl2M9AyyQ2tDHa8svhvFUwZHjKVIQz0MT1QAbW1SJ?=
 =?us-ascii?Q?V1jZY3arkw441AP5/aLWagnlu0mcdRNIPx3MxCEFMraHbE3jcm3enkXYZYTq?=
 =?us-ascii?Q?6Pk+7XgCcNfWIiy4UewX/MrltWQytEfCJcenPujBl0cYBiiH1h9CEu49BfYW?=
 =?us-ascii?Q?5//6yFj1Sj5aR90PwHTepthg6FdxSyFEIdLES4z0BCi77wL41baXd18hGx65?=
 =?us-ascii?Q?4FDMZFpYqiB0eMPMldbQl/Lz5RA5/GR9b161cH1WLpn79bFjaMKvRDZ/N+OK?=
 =?us-ascii?Q?tFIlawYn/PVW4mRKkBeKEGZepzI4UCqB4gSZT9xFqGZWL49WP3aaZMo62iVQ?=
 =?us-ascii?Q?RPJBIiXsB8jA2FmUQGWQVnoLDWiafAMaaY38SVndk2c/Diz/TnSKhgF5z2oc?=
 =?us-ascii?Q?ONb2N5X0BuQg7drMAulf03U64QFYv1nNzHQcJTC6eL6WEk/aa5Vg9OZt4LFM?=
 =?us-ascii?Q?YI+EDpcZXpCK23QcYuYQOXfNHoTrG3fqP7QPn8PSVCaWgoyJ+IiE8Qqi6kdp?=
 =?us-ascii?Q?GW4RX2Sqoh7ao2lBaxXQG1nd8yMz9+o4fwI2hQ1OaCChsSgdJcLj3a9HdIMH?=
 =?us-ascii?Q?F1agF0OlobcTdbiHB/nV/+bfU7Z+dMscnkT5QA0P0yGFYiuiNS5yf+FmAplo?=
 =?us-ascii?Q?XAnDuuNxxYCyKFErtAypaYL3h4fOivZZm8PuRWDuZpDQjm4jVg8Whx3tLu3N?=
 =?us-ascii?Q?glKBoPsczxK5okIxe64gFAHfDFO4TynstgvQP8H74hS4NHuFspwOQSfFqG0U?=
 =?us-ascii?Q?QbfN2BXfPvUZ5nkVH5lsLhzFOA++rsdkPGWRo8Nkx9zGpJ5mGX5UZwD6DJWO?=
 =?us-ascii?Q?0yiESVv84BcOHj/FlXOAP7jkzUSpguNdLw1LeIWxVreGj7nbVcE9YzsCcTBF?=
 =?us-ascii?Q?e6A8SKgsHtQIy2cpki6PlnSXwx99xmiezIJmPrZrt9+YvFB9CUratIKi0c+P?=
 =?us-ascii?Q?jxAMNMFhyfGp550GBrsAkxrEVBkj/fp+XRcB2ql3sC9UmPCXYx59oW8VsWMm?=
 =?us-ascii?Q?12Ccx1MD/J7zDTEB+bk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b5febc1-b5da-4436-2643-08dc872303e8
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 18:52:44.1321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TsQ+iuhHaSmBRMHsaC8pDfdmwLuJhMa7eej5EFd/pqQ867ZJLGrvxYY/oK4YW6ZZz7n6f7xgdSq+evdNa37vSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8746

On Fri, Jun 07, 2024 at 01:28:35AM +0000, Peng Fan wrote:
> > Subject: [PATCH 1/7] arm64: dts: imx8qm: add lvds subsystem
> > 
> > Add irqstear, pwm and i2c in lvds subsystem.
> 
> irqsteer
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi | 231
> > ++++++++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi         |   1 +
> >  2 files changed, 232 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > new file mode 100644
> > index 0000000000000..eb8208cddeaf9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > @@ -0,0 +1,231 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> 
> GPL-2.0-only and MIT?
> 
> > +
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +/{
> > +
> > +	lvds1_ipg_clk: lvds0_ipg_clk: clock-controller-lvds-ipg {
> 
> Two alias name?

It is alllowed by dt. link to one fixed 24M clock. of course we can change
lvds1_ipg_clk to lvds0_ipg_clk.

To avoid confuse, I'd better use two name to align node nams.

Frank

> 
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +		clock-output-names = "lvds0_ipg_clk";
> > +	};
> > +
> 
> Regards,
> Peng.